trace2: use warning() directly in tr2_dst_malformed_warning()
diff mbox series

Message ID 2492824a-6aff-8b82-801a-808ee944a99e@web.de
State New
Headers show
Series
  • trace2: use warning() directly in tr2_dst_malformed_warning()
Related show

Commit Message

René Scharfe Aug. 25, 2019, 5:44 p.m. UTC
Let warning() format the message instead of using an intermediate strbuf
for that.  This is shorter, easier to read and avoids an allocation.

Signed-off-by: René Scharfe <l.s.r@web.de>
---
 trace2/tr2_dst.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

--
2.23.0

Comments

Jeff Hostetler Sept. 4, 2019, 9:14 a.m. UTC | #1
On 8/25/2019 1:44 PM, René Scharfe wrote:
> Let warning() format the message instead of using an intermediate strbuf
> for that.  This is shorter, easier to read and avoids an allocation.
> 
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
>   trace2/tr2_dst.c | 9 ++-------
>   1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/trace2/tr2_dst.c b/trace2/tr2_dst.c
> index 5dda0ca1cd..c69857515f 100644
> --- a/trace2/tr2_dst.c
> +++ b/trace2/tr2_dst.c
> @@ -215,13 +215,8 @@ static int tr2_dst_try_unix_domain_socket(struct tr2_dst *dst,
>   static void tr2_dst_malformed_warning(struct tr2_dst *dst,
>   				      const char *tgt_value)
>   {
> -	struct strbuf buf = STRBUF_INIT;
> -
> -	strbuf_addf(&buf, "trace2: unknown value for '%s': '%s'",
> -		    tr2_sysenv_display_name(dst->sysenv_var), tgt_value);
> -	warning("%s", buf.buf);
> -
> -	strbuf_release(&buf);
> +	warning("trace2: unknown value for '%s': '%s'",
> +		tr2_sysenv_display_name(dst->sysenv_var), tgt_value);
>   }
> 
>   int tr2_dst_get_trace_fd(struct tr2_dst *dst)
> --
> 2.23.0
> 

good catch!  thanks!

Jeff

Patch
diff mbox series

diff --git a/trace2/tr2_dst.c b/trace2/tr2_dst.c
index 5dda0ca1cd..c69857515f 100644
--- a/trace2/tr2_dst.c
+++ b/trace2/tr2_dst.c
@@ -215,13 +215,8 @@  static int tr2_dst_try_unix_domain_socket(struct tr2_dst *dst,
 static void tr2_dst_malformed_warning(struct tr2_dst *dst,
 				      const char *tgt_value)
 {
-	struct strbuf buf = STRBUF_INIT;
-
-	strbuf_addf(&buf, "trace2: unknown value for '%s': '%s'",
-		    tr2_sysenv_display_name(dst->sysenv_var), tgt_value);
-	warning("%s", buf.buf);
-
-	strbuf_release(&buf);
+	warning("trace2: unknown value for '%s': '%s'",
+		tr2_sysenv_display_name(dst->sysenv_var), tgt_value);
 }

 int tr2_dst_get_trace_fd(struct tr2_dst *dst)