[v8,02/10] drm/i915/display: Add debug log for color parameters
diff mbox series

Message ID 1566800772-18412-3-git-send-email-swati2.sharma@intel.com
State New
Headers show
Series
  • drm/i915: adding state checker for gamma lut value
Related show

Commit Message

Swati Sharma Aug. 26, 2019, 6:26 a.m. UTC
Add debug log for color related parameters like gamma_mode, gamma_enable,
csc_enable, etc inside intel_dump_pipe_config().

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Shankar, Uma Aug. 28, 2019, 2:07 p.m. UTC | #1
>-----Original Message-----
>From: Sharma, Swati2
>Sent: Monday, August 26, 2019 11:56 AM
>To: intel-gfx@lists.freedesktop.org
>Cc: Nikula, Jani <jani.nikula@intel.com>; Sharma, Shashank
><shashank.sharma@intel.com>; Manna, Animesh <animesh.manna@intel.com>;
>Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>; daniel.vetter@ffwll.ch;
>ville.syrjala@linux.intel.com; Shankar, Uma <uma.shankar@intel.com>; Sharma,
>Swati2 <swati2.sharma@intel.com>
>Subject: [v8][PATCH 02/10] drm/i915/display: Add debug log for color parameters
>
>Add debug log for color related parameters like gamma_mode, gamma_enable,
>csc_enable, etc inside intel_dump_pipe_config().
>
>Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_display.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_display.c
>b/drivers/gpu/drm/i915/display/intel_display.c
>index b51d1ce..ca88c70 100644
>--- a/drivers/gpu/drm/i915/display/intel_display.c
>+++ b/drivers/gpu/drm/i915/display/intel_display.c
>@@ -12138,6 +12138,15 @@ static void intel_dump_pipe_config(const struct
>intel_crtc_state *pipe_config,
>
> 	intel_dpll_dump_hw_state(dev_priv, &pipe_config->dpll_hw_state);
>
>+	if (IS_CHERRYVIEW(dev_priv))
>+		DRM_DEBUG_KMS("cgm_mode:%d gamma_mode:%d
>gamma_enable:%d csc_enable:%d\n",
>+			       pipe_config->cgm_mode, pipe_config->gamma_mode,
>+			       pipe_config->gamma_enable, pipe_config->csc_enable);

Alignment seems to be off.

>+	else
>+		DRM_DEBUG_KMS("csc_mode:%d gamma_mode:%d
>gamma_enable:%d csc_enable:%d\n",
>+			       pipe_config->csc_mode, pipe_config->gamma_mode,
>+			       pipe_config->gamma_enable, pipe_config->csc_enable);

Same here.

>+
> dump_planes:
> 	if (!state)
> 		return;
>--
>1.9.1

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index b51d1ce..ca88c70 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -12138,6 +12138,15 @@  static void intel_dump_pipe_config(const struct intel_crtc_state *pipe_config,
 
 	intel_dpll_dump_hw_state(dev_priv, &pipe_config->dpll_hw_state);
 
+	if (IS_CHERRYVIEW(dev_priv))
+		DRM_DEBUG_KMS("cgm_mode:%d gamma_mode:%d gamma_enable:%d csc_enable:%d\n",
+			       pipe_config->cgm_mode, pipe_config->gamma_mode,
+			       pipe_config->gamma_enable, pipe_config->csc_enable);
+	else
+		DRM_DEBUG_KMS("csc_mode:%d gamma_mode:%d gamma_enable:%d csc_enable:%d\n",
+			       pipe_config->csc_mode, pipe_config->gamma_mode,
+			       pipe_config->gamma_enable, pipe_config->csc_enable);
+
 dump_planes:
 	if (!state)
 		return;