diff mbox series

http: don't leak urlmatch_config.vars

Message ID 20190826074911.23792-1-mh@glandium.org (mailing list archive)
State New, archived
Headers show
Series http: don't leak urlmatch_config.vars | expand

Commit Message

Mike Hommey Aug. 26, 2019, 7:49 a.m. UTC 
Signed-off-by: Mike Hommey <mh@glandium.org>
---
 http.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Junio C Hamano Aug. 26, 2019, 6:09 p.m. UTC | #1 
Mike Hommey <mh@glandium.org> writes:

> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---
>  http.c | 1 +
>  1 file changed, 1 insertion(+)

This matches what builtin/config.c::get_urlmatch() does, which makes
sense.

Thanks.

>
> diff --git a/http.c b/http.c
> index 27aa0a3192..9e33584f2d 100644
> --- a/http.c
> +++ b/http.c
> @@ -1073,6 +1073,7 @@ void http_init(struct remote *remote, const char *url, int proactive_auth)
>  
>  	git_config(urlmatch_config_entry, &config);
>  	free(normalized_url);
> +	string_list_clear(&config.vars, 1);
>  
>  #if LIBCURL_VERSION_NUM >= 0x073800
>  	if (http_ssl_backend) {
diff mbox series

Patch

diff --git a/http.c b/http.c
index 27aa0a3192..9e33584f2d 100644
--- a/http.c
+++ b/http.c
@@ -1073,6 +1073,7 @@  void http_init(struct remote *remote, const char *url, int proactive_auth)
 
 	git_config(urlmatch_config_entry, &config);
 	free(normalized_url);
+	string_list_clear(&config.vars, 1);
 
 #if LIBCURL_VERSION_NUM >= 0x073800
 	if (http_ssl_backend) {