diff mbox series

ALSA: usb-audio: remove some dead code

Message ID 20190826134550.GA8842@mwanda (mailing list archive)
State New, archived
Headers show
Series ALSA: usb-audio: remove some dead code | expand

Commit Message

Dan Carpenter Aug. 26, 2019, 1:45 p.m. UTC 
We recently cleaned up the error handling in commit 52c3e317a857 ("ALSA:
usb-audio: Unify the release of usb_mixer_elem_info objects") but
accidentally left this stray return.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 sound/usb/mixer.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Takashi Iwai Aug. 26, 2019, 1:52 p.m. UTC | #1 
On Mon, 26 Aug 2019 15:45:50 +0200,
Dan Carpenter wrote:
> 
> We recently cleaned up the error handling in commit 52c3e317a857 ("ALSA:
> usb-audio: Unify the release of usb_mixer_elem_info objects") but
> accidentally left this stray return.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied now.


Takashi
diff mbox series

Patch

diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index a0468c4a6326..a607577f0097 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -2633,7 +2633,6 @@  static int parse_audio_selector_unit(struct mixer_build *state, int unitid,
 		usb_audio_err(state->chip, "cannot malloc kcontrol\n");
 		err = -ENOMEM;
 		goto error_name;
-		return -ENOMEM;
 	}
 	kctl->private_value = (unsigned long)namelist;
 	kctl->private_free = usb_mixer_selector_elem_free;