| Message ID | 20190827053656.32191-2-alastair@au1.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm: Minor cleanup | expand |
On Tue 27-08-19 15:36:54, Alastair D'Silva wrote: > From: Alastair D'Silva <alastair@d-silva.org> > > Use the function written to do it instead. > > Signed-off-by: Alastair D'Silva <alastair@d-silva.org> Acked-by: Michal Hocko <mhocko@suse.com> > --- > mm/sparse.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index 72f010d9bff5..e41917a7e844 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -11,6 +11,8 @@ > #include <linux/export.h> > #include <linux/spinlock.h> > #include <linux/vmalloc.h> > +#include <linux/swap.h> > +#include <linux/swapops.h> > > #include "internal.h" > #include <asm/dma.h> > @@ -898,7 +900,7 @@ static void clear_hwpoisoned_pages(struct page *memmap, int nr_pages) > > for (i = 0; i < nr_pages; i++) { > if (PageHWPoison(&memmap[i])) { > - atomic_long_sub(1, &num_poisoned_pages); > + num_poisoned_pages_dec(); > ClearPageHWPoison(&memmap[i]); > } > } > -- > 2.21.0
On 27.08.19 07:36, Alastair D'Silva wrote: > From: Alastair D'Silva <alastair@d-silva.org> > > Use the function written to do it instead. > > Signed-off-by: Alastair D'Silva <alastair@d-silva.org> > --- > mm/sparse.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index 72f010d9bff5..e41917a7e844 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -11,6 +11,8 @@ > #include <linux/export.h> > #include <linux/spinlock.h> > #include <linux/vmalloc.h> > +#include <linux/swap.h> > +#include <linux/swapops.h> > > #include "internal.h" > #include <asm/dma.h> > @@ -898,7 +900,7 @@ static void clear_hwpoisoned_pages(struct page *memmap, int nr_pages) > > for (i = 0; i < nr_pages; i++) { > if (PageHWPoison(&memmap[i])) { > - atomic_long_sub(1, &num_poisoned_pages); > + num_poisoned_pages_dec(); > ClearPageHWPoison(&memmap[i]); > } > } > Reviewed-by: David Hildenbrand <david@redhat.com>
On Tue, Aug 27, 2019 at 03:36:54PM +1000, Alastair D'Silva wrote: > From: Alastair D'Silva <alastair@d-silva.org> > > Use the function written to do it instead. > > Signed-off-by: Alastair D'Silva <alastair@d-silva.org> Acked-by: Mike Rapoport <rppt@linux.ibm.com> > --- > mm/sparse.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index 72f010d9bff5..e41917a7e844 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -11,6 +11,8 @@ > #include <linux/export.h> > #include <linux/spinlock.h> > #include <linux/vmalloc.h> > +#include <linux/swap.h> > +#include <linux/swapops.h> > > #include "internal.h" > #include <asm/dma.h> > @@ -898,7 +900,7 @@ static void clear_hwpoisoned_pages(struct page *memmap, int nr_pages) > > for (i = 0; i < nr_pages; i++) { > if (PageHWPoison(&memmap[i])) { > - atomic_long_sub(1, &num_poisoned_pages); > + num_poisoned_pages_dec(); > ClearPageHWPoison(&memmap[i]); > } > } > -- > 2.21.0 >
On Tue, Aug 27, 2019 at 03:36:54PM +1000, Alastair D'Silva wrote: >From: Alastair D'Silva <alastair@d-silva.org> > >Use the function written to do it instead. > >Signed-off-by: Alastair D'Silva <alastair@d-silva.org> Reviewed-by: Wei Yang <richardw.yang@linux.intel.com> >--- > mm/sparse.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/mm/sparse.c b/mm/sparse.c >index 72f010d9bff5..e41917a7e844 100644 >--- a/mm/sparse.c >+++ b/mm/sparse.c >@@ -11,6 +11,8 @@ > #include <linux/export.h> > #include <linux/spinlock.h> > #include <linux/vmalloc.h> >+#include <linux/swap.h> >+#include <linux/swapops.h> > > #include "internal.h" > #include <asm/dma.h> >@@ -898,7 +900,7 @@ static void clear_hwpoisoned_pages(struct page *memmap, int nr_pages) > > for (i = 0; i < nr_pages; i++) { > if (PageHWPoison(&memmap[i])) { >- atomic_long_sub(1, &num_poisoned_pages); >+ num_poisoned_pages_dec(); > ClearPageHWPoison(&memmap[i]); > } > } >-- >2.21.0
On Tue, Aug 27, 2019 at 03:36:54PM +1000, Alastair D'Silva wrote: > From: Alastair D'Silva <alastair@d-silva.org> > > Use the function written to do it instead. > > Signed-off-by: Alastair D'Silva <alastair@d-silva.org> Reviewed-by: Oscar Salvador <osalvador@suse.de> > --- > mm/sparse.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index 72f010d9bff5..e41917a7e844 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -11,6 +11,8 @@ > #include <linux/export.h> > #include <linux/spinlock.h> > #include <linux/vmalloc.h> > +#include <linux/swap.h> > +#include <linux/swapops.h> > > #include "internal.h" > #include <asm/dma.h> > @@ -898,7 +900,7 @@ static void clear_hwpoisoned_pages(struct page *memmap, int nr_pages) > > for (i = 0; i < nr_pages; i++) { > if (PageHWPoison(&memmap[i])) { > - atomic_long_sub(1, &num_poisoned_pages); > + num_poisoned_pages_dec(); > ClearPageHWPoison(&memmap[i]); > } > } > -- > 2.21.0 >
diff --git a/mm/sparse.c b/mm/sparse.c index 72f010d9bff5..e41917a7e844 100644 --- a/mm/sparse.c +++ b/mm/sparse.c @@ -11,6 +11,8 @@ #include <linux/export.h> #include <linux/spinlock.h> #include <linux/vmalloc.h> +#include <linux/swap.h> +#include <linux/swapops.h> #include "internal.h" #include <asm/dma.h> @@ -898,7 +900,7 @@ static void clear_hwpoisoned_pages(struct page *memmap, int nr_pages) for (i = 0; i < nr_pages; i++) { if (PageHWPoison(&memmap[i])) { - atomic_long_sub(1, &num_poisoned_pages); + num_poisoned_pages_dec(); ClearPageHWPoison(&memmap[i]); } }