media: dvb: redundant assignment to variable tmp
diff mbox series

Message ID 20190827111527.26337-1-colin.king@canonical.com
State New
Headers show
Series
  • media: dvb: redundant assignment to variable tmp
Related show

Commit Message

Colin King Aug. 27, 2019, 11:15 a.m. UTC
From: Colin Ian King <colin.king@canonical.com>

Variable tmp is being assigned a value that is never read and tmp
is being re-assigned a little later on. The assignment is redundant
and hence can be removed.

Addresses-Coverity: ("Ununsed value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/media/dvb-frontends/sp8870.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Dan Carpenter Aug. 27, 2019, 1:10 p.m. UTC | #1
On Tue, Aug 27, 2019 at 12:15:27PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Variable tmp is being assigned a value that is never read and tmp
> is being re-assigned a little later on. The assignment is redundant
> and hence can be removed.
> 
> Addresses-Coverity: ("Ununsed value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/media/dvb-frontends/sp8870.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/media/dvb-frontends/sp8870.c b/drivers/media/dvb-frontends/sp8870.c
> index 655db8272268..f6793c9c2dc3 100644
> --- a/drivers/media/dvb-frontends/sp8870.c
> +++ b/drivers/media/dvb-frontends/sp8870.c
> @@ -378,8 +378,6 @@ static int sp8870_read_ber (struct dvb_frontend* fe, u32 * ber)
>  	if (ret < 0)
>  		return -EIO;
>  
> -	tmp = ret & 0x3F;
> -

This is pre git code.  It's not clear if the tmp is supposed to be used
or if we can remove the sp8870_readreg() call also...  The problem is
that we're disabling the warning without necessarily writing the best
fix.  It's better to leave the warning there until we are more sure of
the correct fix.  The warning has useful information and it's not
hurting anyone.

regards,
dan carpenter

Patch
diff mbox series

diff --git a/drivers/media/dvb-frontends/sp8870.c b/drivers/media/dvb-frontends/sp8870.c
index 655db8272268..f6793c9c2dc3 100644
--- a/drivers/media/dvb-frontends/sp8870.c
+++ b/drivers/media/dvb-frontends/sp8870.c
@@ -378,8 +378,6 @@  static int sp8870_read_ber (struct dvb_frontend* fe, u32 * ber)
 	if (ret < 0)
 		return -EIO;
 
-	tmp = ret & 0x3F;
-
 	ret = sp8870_readreg(state, 0xC07);
 	if (ret < 0)
 		return -EIO;