drm/komeda: Add ACLK rate to sysfs
diff mbox series

Message ID 20190828110342.45936-1-mihail.atanassov@arm.com
State New
Headers show
Series
  • drm/komeda: Add ACLK rate to sysfs
Related show

Commit Message

Mihail Atanassov Aug. 28, 2019, 11:03 a.m. UTC
Expose node with the name 'aclk_hz'

Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
---
 drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

james qian wang (Arm Technology China) Aug. 28, 2019, 2:15 p.m. UTC | #1
Hi Mihail:

Looks good to me.

Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>

James.

On Wed, Aug 28, 2019 at 11:03:49AM +0000, Mihail Atanassov wrote:
> Expose node with the name 'aclk_hz'
> 
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index 0142ee991957..e8d67395a3b9 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -91,9 +91,19 @@ config_id_show(struct device *dev, struct device_attribute *attr, char *buf)
>  }
>  static DEVICE_ATTR_RO(config_id);
>  
> +static ssize_t
> +aclk_hz_show(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> +	struct komeda_dev *mdev = dev_to_mdev(dev);
> +
> +	return snprintf(buf, PAGE_SIZE, "%lu\n", clk_get_rate(mdev->aclk));
> +}
> +static DEVICE_ATTR_RO(aclk_hz);
> +
>  static struct attribute *komeda_sysfs_entries[] = {
>  	&dev_attr_core_id.attr,
>  	&dev_attr_config_id.attr,
> +	&dev_attr_aclk_hz.attr,
>  	NULL,
>  };
>  
> -- 
> 2.22.0
Ayan Halder Sept. 3, 2019, 1:46 p.m. UTC | #2
On Wed, Aug 28, 2019 at 02:15:15PM +0000, james qian wang (Arm Technology China) wrote:
> Hi Mihail:
> 
> Looks good to me.
> 
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
>
Pushed to drm-misc-next  5fcd055193c5d4cac6d205bd65e52c957ea057c2
And that verifies my new dim setup. :)
> James.
> 
> On Wed, Aug 28, 2019 at 11:03:49AM +0000, Mihail Atanassov wrote:
> > Expose node with the name 'aclk_hz'
> > 
> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> > ---
> >  drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > index 0142ee991957..e8d67395a3b9 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > @@ -91,9 +91,19 @@ config_id_show(struct device *dev, struct device_attribute *attr, char *buf)
> >  }
> >  static DEVICE_ATTR_RO(config_id);
> >  
> > +static ssize_t
> > +aclk_hz_show(struct device *dev, struct device_attribute *attr, char *buf)
> > +{
> > +	struct komeda_dev *mdev = dev_to_mdev(dev);
> > +
> > +	return snprintf(buf, PAGE_SIZE, "%lu\n", clk_get_rate(mdev->aclk));
> > +}
> > +static DEVICE_ATTR_RO(aclk_hz);
> > +
> >  static struct attribute *komeda_sysfs_entries[] = {
> >  	&dev_attr_core_id.attr,
> >  	&dev_attr_config_id.attr,
> > +	&dev_attr_aclk_hz.attr,
> >  	NULL,
> >  };
> >  
> > -- 
> > 2.22.0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch
diff mbox series

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
index 0142ee991957..e8d67395a3b9 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
@@ -91,9 +91,19 @@  config_id_show(struct device *dev, struct device_attribute *attr, char *buf)
 }
 static DEVICE_ATTR_RO(config_id);
 
+static ssize_t
+aclk_hz_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+	struct komeda_dev *mdev = dev_to_mdev(dev);
+
+	return snprintf(buf, PAGE_SIZE, "%lu\n", clk_get_rate(mdev->aclk));
+}
+static DEVICE_ATTR_RO(aclk_hz);
+
 static struct attribute *komeda_sysfs_entries[] = {
 	&dev_attr_core_id.attr,
 	&dev_attr_config_id.attr,
+	&dev_attr_aclk_hz.attr,
 	NULL,
 };