[V3,1/5] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible
diff mbox series

Message ID 20190830104502.7128-2-guillaume.gardet@arm.com
State Accepted
Commit 5833f5a5daf37f54ff7cc15f03ac0df201ccff92
Headers show
Series
  • Add GPU/Mali T604 node to arndale and snow (exynos5250)
Related show

Commit Message

Guillaume Gardet Aug. 30, 2019, 10:44 a.m. UTC
Add "samsung,exynos5250-mali" binding.

Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org
---
V3 changes:
  * add dt-bindings before node in device tree
V2 changes:
  * new file

 Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Sept. 2, 2019, 3:31 p.m. UTC | #1
On Fri, Aug 30, 2019 at 12:44:58PM +0200, Guillaume Gardet wrote:
> Add "samsung,exynos5250-mali" binding.
> 
> Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>
> 
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> V3 changes:
>   * add dt-bindings before node in device tree
> V2 changes:
>   * new file
> 
>  Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +

Thanks, entire set applied (with re-ordering and minor description
changes).

Best regards,
Krzysztof
Krzysztof Kozlowski Sept. 3, 2019, 6:56 a.m. UTC | #2
On Mon, 2 Sep 2019 at 17:31, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Fri, Aug 30, 2019 at 12:44:58PM +0200, Guillaume Gardet wrote:
> > Add "samsung,exynos5250-mali" binding.
> >
> > Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>
> >
> > Cc: Kukjin Kim <kgene@kernel.org>
> > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> > Cc: linux-arm-kernel@lists.infradead.org
> > ---
> > V3 changes:
> >   * add dt-bindings before node in device tree
> > V2 changes:
> >   * new file
> >
> >  Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +
>
> Thanks, entire set applied (with re-ordering and minor description
> changes).

Hi Guillaume,

I applied yesterday entire patchset but this dt-bindings patch causes
big merge conflict which will not be reasonable to resolve by Linus.
Can you rebase this patch on top of latest linux-next? Basically you
would need to add respective entries to new YAML file:
Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml

Send it to regular dt-bindings maintainers (scripts/get_maintainers.pl).

Best regards,
Krzysztof
Guillaume Gardet Sept. 3, 2019, 7:02 a.m. UTC | #3
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 03 September 2019 08:56
> To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>;
> Marek Szyprowski <m.szyprowski@samsung.com>; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung
> exynos5250 compatible
>
> On Mon, 2 Sep 2019 at 17:31, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Fri, Aug 30, 2019 at 12:44:58PM +0200, Guillaume Gardet wrote:
> > > Add "samsung,exynos5250-mali" binding.
> > >
> > > Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>
> > >
> > > Cc: Kukjin Kim <kgene@kernel.org>
> > > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > > Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> > > Cc: linux-arm-kernel@lists.infradead.org
> > > ---
> > > V3 changes:
> > >   * add dt-bindings before node in device tree
> > > V2 changes:
> > >   * new file
> > >
> > >  Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +
> >
> > Thanks, entire set applied (with re-ordering and minor description
> > changes).
>
> Hi Guillaume,

Hi,

>
> I applied yesterday entire patchset but this dt-bindings patch causes big
> merge conflict which will not be reasonable to resolve by Linus.
> Can you rebase this patch on top of latest linux-next? Basically you would
> need to add respective entries to new YAML file:
> Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
>
> Send it to regular dt-bindings maintainers (scripts/get_maintainers.pl).

IIUC, I just need to resend this patch (1/5) rebased to use yaml, instead of txt, no need to resend other patches, right?

Regards,
Guillaume

>
> Best regards,
> Krzysztof
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Krzysztof Kozlowski Sept. 3, 2019, 7:04 a.m. UTC | #4
On Tue, 3 Sep 2019 at 09:03, Guillaume Gardet <Guillaume.Gardet@arm.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: 03 September 2019 08:56
> > To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> > Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>;
> > Marek Szyprowski <m.szyprowski@samsung.com>; linux-arm-
> > kernel@lists.infradead.org
> > Subject: Re: [PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung
> > exynos5250 compatible
> >
> > On Mon, 2 Sep 2019 at 17:31, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >
> > > On Fri, Aug 30, 2019 at 12:44:58PM +0200, Guillaume Gardet wrote:
> > > > Add "samsung,exynos5250-mali" binding.
> > > >
> > > > Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>
> > > >
> > > > Cc: Kukjin Kim <kgene@kernel.org>
> > > > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > > > Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> > > > Cc: linux-arm-kernel@lists.infradead.org
> > > > ---
> > > > V3 changes:
> > > >   * add dt-bindings before node in device tree
> > > > V2 changes:
> > > >   * new file
> > > >
> > > >  Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +
> > >
> > > Thanks, entire set applied (with re-ordering and minor description
> > > changes).
> >
> > Hi Guillaume,
>
> Hi,
>
> >
> > I applied yesterday entire patchset but this dt-bindings patch causes big
> > merge conflict which will not be reasonable to resolve by Linus.
> > Can you rebase this patch on top of latest linux-next? Basically you would
> > need to add respective entries to new YAML file:
> > Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
> >
> > Send it to regular dt-bindings maintainers (scripts/get_maintainers.pl).
>
> IIUC, I just need to resend this patch (1/5) rebased to use yaml, instead of txt, no need to resend other patches, right?

Yes, correct. Just remember to send it to proper maintainers (previous
one skipped DT guys).

Best regards,
Krzysztof

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
index 9b298edec5b2..bdd1396d9cc3 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
@@ -17,6 +17,7 @@  Required properties:
   * which must be preceded by one of the following vendor specifics:
     + "allwinner,sun50i-h6-mali"
     + "amlogic,meson-gxm-mali"
+    + "samsung,exynos5250-mali"
     + "samsung,exynos5433-mali"
     + "rockchip,rk3288-mali"
     + "rockchip,rk3399-mali"