| Message ID | 1567490688-17872-1-git-send-email-zhongjiang@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | NFS: remove the redundant check when kfree an object in nfs_netns_client_release | expand |
> kfree has taken the null check in account.
I suggest to take another look at a similar patch.
NFS: fix ifnullfree.cocci warnings
https://lkml.org/lkml/2019/7/7/73
https://lore.kernel.org/patchwork/patch/1098005/
https://lore.kernel.org/r/alpine.DEB.2.21.1907071844310.2521@hadrien/
Regards,
Markus
On 2019/9/4 23:11, Markus Elfring wrote: >> kfree has taken the null check in account. > I suggest to take another look at a similar patch. How to fast find out the similar patch. Search the key word doesn't work well. Thanks, zhong jiang > NFS: fix ifnullfree.cocci warnings > https://lkml.org/lkml/2019/7/7/73 > https://lore.kernel.org/patchwork/patch/1098005/ > https://lore.kernel.org/r/alpine.DEB.2.21.1907071844310.2521@hadrien/ > > Regards, > Markus > > . >
>> I suggest to take another look at a similar patch. > How to fast find out the similar patch. Search the key word doesn't work well. This is a recurring development challenge, isn't it? The occurrence of related update suggestions can occasionally become more interesting. Regards, Markus
diff --git a/fs/nfs/sysfs.c b/fs/nfs/sysfs.c index 4f3390b..c489496 100644 --- a/fs/nfs/sysfs.c +++ b/fs/nfs/sysfs.c @@ -121,8 +121,7 @@ static void nfs_netns_client_release(struct kobject *kobj) struct nfs_netns_client, kobject); - if (c->identifier) - kfree(c->identifier); + kfree(c->identifier); kfree(c); }
kfree has taken the null check in account. hence it is unnecessary to add the null check before kfree the object. Just remove it. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- fs/nfs/sysfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)