| Message ID | 20190903125845.3117-1-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] xfsprogs: provide a few compatibility typedefs | expand |
On Tue, Sep 03, 2019 at 02:58:45PM +0200, Christoph Hellwig wrote: > Add back four typedefs that allow xfsdump to compile against the > headers from the latests xfsprogs. > > Reported-by: Murphy Zhou <jencce.kernel@gmail.com> > Signed-off-by: Christoph Hellwig <hch@lst.de> Looks ok (though really I looked at the previous broken version and look how far that got us :P) Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > --- > include/xfs.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/xfs.h b/include/xfs.h > index f2f675df..9c03d6bd 100644 > --- a/include/xfs.h > +++ b/include/xfs.h > @@ -37,4 +37,13 @@ extern int xfs_assert_largefile[sizeof(off_t)-8]; > #include <xfs/xfs_types.h> > #include <xfs/xfs_fs.h> > > +/* > + * Backards compatibility for users of this header, now that the kernel > + * removed these typedefs from xfs_fs.h. > + */ > +typedef struct xfs_bstat xfs_bstat_t; > +typedef struct xfs_fsop_bulkreq xfs_fsop_bulkreq_t; > +typedef struct xfs_fsop_geom_v1 xfs_fsop_geom_v1_t; > +typedef struct xfs_inogrp xfs_inogrp_t; > + > #endif /* __XFS_H__ */ > -- > 2.20.1 >
On Tue, Sep 03, 2019 at 02:58:45PM +0200, Christoph Hellwig wrote: > Add back four typedefs that allow xfsdump to compile against the > headers from the latests xfsprogs. > > Reported-by: Murphy Zhou <jencce.kernel@gmail.com> > Signed-off-by: Christoph Hellwig <hch@lst.de> Works fine. Thanks~ > --- > include/xfs.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/xfs.h b/include/xfs.h > index f2f675df..9c03d6bd 100644 > --- a/include/xfs.h > +++ b/include/xfs.h > @@ -37,4 +37,13 @@ extern int xfs_assert_largefile[sizeof(off_t)-8]; > #include <xfs/xfs_types.h> > #include <xfs/xfs_fs.h> > > +/* > + * Backards compatibility for users of this header, now that the kernel > + * removed these typedefs from xfs_fs.h. > + */ > +typedef struct xfs_bstat xfs_bstat_t; > +typedef struct xfs_fsop_bulkreq xfs_fsop_bulkreq_t; > +typedef struct xfs_fsop_geom_v1 xfs_fsop_geom_v1_t; > +typedef struct xfs_inogrp xfs_inogrp_t; > + > #endif /* __XFS_H__ */ > -- > 2.20.1 >
diff --git a/include/xfs.h b/include/xfs.h index f2f675df..9c03d6bd 100644 --- a/include/xfs.h +++ b/include/xfs.h @@ -37,4 +37,13 @@ extern int xfs_assert_largefile[sizeof(off_t)-8]; #include <xfs/xfs_types.h> #include <xfs/xfs_fs.h> +/* + * Backards compatibility for users of this header, now that the kernel + * removed these typedefs from xfs_fs.h. + */ +typedef struct xfs_bstat xfs_bstat_t; +typedef struct xfs_fsop_bulkreq xfs_fsop_bulkreq_t; +typedef struct xfs_fsop_geom_v1 xfs_fsop_geom_v1_t; +typedef struct xfs_inogrp xfs_inogrp_t; + #endif /* __XFS_H__ */
Add back four typedefs that allow xfsdump to compile against the headers from the latests xfsprogs. Reported-by: Murphy Zhou <jencce.kernel@gmail.com> Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/xfs.h | 9 +++++++++ 1 file changed, 9 insertions(+)