From patchwork Tue Sep 3 19:06:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11128625 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 97CFE1813 for ; Tue, 3 Sep 2019 19:07:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F9A321897 for ; Tue, 3 Sep 2019 19:07:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F9A321897 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D8DA897F5; Tue, 3 Sep 2019 19:07:01 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD7A2897F9 for ; Tue, 3 Sep 2019 19:06:59 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id r12so19578849edo.5 for ; Tue, 03 Sep 2019 12:06:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rMbe/90UeFfqEUrk4ND8PxMTYBDDkx6JYpo4F1BWcC8=; b=Gu7WsGQz5NGxesKbWvotVMlsEzdM1/OcQVxiEcPtN0xAACFkRg7h6RVzTDDEZC/eY3 +4+NtPH49I5DdCGPfvUyt4ofP21G7UJDelfEsZeeidWQ8LxSOoAIW4gb6D133OKJybxs DlvBm6uELmIU5oPk69FRg/GAAYp2OuCbpurtdXSOxBACDCT2oYgDytPX/P6R7NgtswYx YSASkmPEA4FwLXGecLCv2SkHyNcHab8jAAfieoMep2txLrph8FsXaRRywtlImeVGue7s ERhtJo03jgR1k9bQtqMheE/QT1V3jVI1kn5Lf3FUnn21qT8JnLt1ZVO2X2Hwp2wvao4M JEaw== X-Gm-Message-State: APjAAAUtkOQbV8H5UIzFhQxurXrvj5oVQDdlRTE54YzuCuYiptEkbX60 a+1DB/mcPzH40bnRIpxncXskgg== X-Google-Smtp-Source: APXvYqweLY86stxuQkQXezP/PFuo3lvwCfIEpFRc8/jxHYyer1v3jB8UP3B3FCjCKXceMYgpkvb9eA== X-Received: by 2002:a17:906:c08:: with SMTP id s8mr8462775ejf.66.1567537618355; Tue, 03 Sep 2019 12:06:58 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id b12sm3655583edj.93.2019.09.03.12.06.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 12:06:57 -0700 (PDT) From: Daniel Vetter To: DRI Development Date: Tue, 3 Sep 2019 21:06:41 +0200 Message-Id: <20190903190642.32588-2-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190903190642.32588-1-daniel.vetter@ffwll.ch> References: <20190903190642.32588-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rMbe/90UeFfqEUrk4ND8PxMTYBDDkx6JYpo4F1BWcC8=; b=GBOWMGKL2htvO3SG2dtez5oS9+y04XBknjNmJprvWjn75fZ0rnETw5swFSjkZtTClo ThuibSbiJQweoF8PUR9R6qvA0cNz8onWs/Gg6Wr38ugYlhNTuTjHWsD06MsQLBm80ycm gMsJ0Cu+sxjStk/RcC0NXV+LdYOEQf3dFZDxk= Subject: [Intel-gfx] [PATCH 2/3] drm/atomic: Reject FLIP_ASYNC unconditionally X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Daniel Vetter , Intel Graphics Development , Adam Jackson , Alex Deucher , Daniel Vetter , =?utf-8?q?Michel_D=C3=A4nzer?= Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" It's never been wired up. Only userspace that tried to use it (and didn't actually check whether anything works, but hey it builds) is the -modesetting atomic implementation. And we just shut that up. If there's anyone else then we need to silently accept this flag no matter what, and find a new one. Because once a flag is tainted, it's lost. Cc: Maarten Lankhorst Cc: Michel Dänzer Cc: Alex Deucher Cc: Adam Jackson Cc: Sean Paul Cc: David Airlie Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic_uapi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c index 5a5b42db6f2a..7a26bfb5329c 100644 --- a/drivers/gpu/drm/drm_atomic_uapi.c +++ b/drivers/gpu/drm/drm_atomic_uapi.c @@ -1305,8 +1305,7 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, if (arg->reserved) return -EINVAL; - if ((arg->flags & DRM_MODE_PAGE_FLIP_ASYNC) && - !dev->mode_config.async_page_flip) + if (arg->flags & DRM_MODE_PAGE_FLIP_ASYNC) return -EINVAL; /* can't test and expect an event at the same time. */