| Message ID | 1567582878-18739-1-git-send-email-zhongjiang@huawei.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath10k: Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element | expand |
zhong jiang <zhongjiang@huawei.com> wrote: > With the help of Coccinelle, ARRAY_SIZE can be replaced in ath10k_snoc_wlan_enable. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> I already got an identical patch so dropping this one. error: patch failed: drivers/net/wireless/ath/ath10k/snoc.c:976 error: drivers/net/wireless/ath/ath10k/snoc.c: patch does not apply stg import: Diff does not apply cleanly
On 2019/9/17 15:16, Kalle Valo wrote: > zhong jiang <zhongjiang@huawei.com> wrote: > >> With the help of Coccinelle, ARRAY_SIZE can be replaced in ath10k_snoc_wlan_enable. >> >> Signed-off-by: zhong jiang <zhongjiang@huawei.com> > I already got an identical patch so dropping this one. > > error: patch failed: drivers/net/wireless/ath/ath10k/snoc.c:976 > error: drivers/net/wireless/ath/ath10k/snoc.c: patch does not apply > stg import: Diff does not apply cleanly > Thank for your remainder. Sincerely, zhong jiang
diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index b491361..49fc044 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -976,8 +976,7 @@ static int ath10k_snoc_wlan_enable(struct ath10k *ar, sizeof(struct ath10k_svc_pipe_cfg); cfg.ce_svc_cfg = (struct ath10k_svc_pipe_cfg *) &target_service_to_ce_map_wlan; - cfg.num_shadow_reg_cfg = sizeof(target_shadow_reg_cfg_map) / - sizeof(struct ath10k_shadow_reg_cfg); + cfg.num_shadow_reg_cfg = ARRAY_SIZE(target_shadow_reg_cfg_map); cfg.shadow_reg_cfg = (struct ath10k_shadow_reg_cfg *) &target_shadow_reg_cfg_map;
With the help of Coccinelle, ARRAY_SIZE can be replaced in ath10k_snoc_wlan_enable. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- drivers/net/wireless/ath/ath10k/snoc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)