[1/1] .gitignore: stop ignoring `.manifest` files

Commit Message

Johannes Schindelin via GitGitGadget Sept. 5, 2019, 11:16 a.m. UTC

From: Johannes Schindelin <[e-mail]>

On Windows, it is possible to embed additional metadata into an
executable by linking in a "manifest", i.e. an XML document that
describes capabilities and requirements (such as minimum or maximum
Windows version). These XML documents are expected to be stored in
`.manifest` files.

At least _some_ Visual Studio versions auto-generate `.manifest` files
when none is specified explicitly, therefore we used to ask Git to
ignore them.

However, we do have a beautiful `.manifest` file now:
`compat/win32/git.manifest`, so neither does Visual Studio auto-generate
a manifest for us, nor do we want Git to ignore the `.manifest` files
anymore.

Further reading on auto-generated `.manifest` files:
https://docs.microsoft.com/en-us/cpp/build/manifest-generation-in-visual-studio

Signed-off-by: Johannes Schindelin <[e-mail]>
---
 .gitignore | 1 -
 1 file changed, 1 deletion(-)

Comments

Junio C Hamano Sept. 5, 2019, 5:44 p.m. UTC | #1

"Johannes Schindelin via GitGitGadget" <[e-mail]>
writes:

> ...
> Further reading on auto-generated `.manifest` files:
> https://docs.microsoft.com/en-us/cpp/build/manifest-generation-in-visual-studio
>
> Signed-off-by: Johannes Schindelin <[e-mail]>
> ---
>  .gitignore | 1 -
>  1 file changed, 1 deletion(-)

Thanks.

> diff --git a/.gitignore b/.gitignore
> index 521d8f4fb4..fc445edea9 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -231,7 +231,6 @@
>  *.ipdb
>  *.dll
>  .vs/
> -*.manifest
>  Debug/
>  Release/
>  /UpgradeLog*.htm

Patch

diff --git a/.gitignore b/.gitignore
index 521d8f4fb4..fc445edea9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -231,7 +231,6 @@ 
 *.ipdb
 *.dll
 .vs/
-*.manifest
 Debug/
 Release/
 /UpgradeLog*.htm