[BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c
diff mbox series

Message ID b99e39ce-30b9-4def-3b98-eb463e5ae57d@gmx.net
State Not Applicable
Headers show
Series
  • [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c
Related show

Commit Message

Otto Meier Sept. 5, 2019, 11:48 a.m. UTC
Hi i tried to use uart_C of the the odroid-c2.

I enabled it int the dts file. During boot it crashed when the
the sdcard slot is addressd.

After long search in the net i found this:

https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856


After changing the pin definitios accordingly erverything works.

Uart_c is functioning and sdcard ist working.

Patch attached

Bye Otto

Comments

Martin Blumenstingl Sept. 7, 2019, 2:57 p.m. UTC | #1
Hi Otto,

On Thu, Sep 5, 2019 at 1:49 PM Otto Meier <gf435@gmx.net> wrote:
>
> Hi i tried to use uart_C of the the odroid-c2.
>
> I enabled it int the dts file. During boot it crashed when the
> the sdcard slot is addressd.
>
> After long search in the net i found this:
>
> https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856
thank you for doing research on this...

>
> After changing the pin definitios accordingly erverything works.
>
> Uart_c is functioning and sdcard ist working.
>
> Patch attached
...as well as going the extra mile (writing a patch and submitting it)

your patch is looking good to me apart from some small formal issues:
- some typos in the commit message (int -> in, addressd -> addressed,
definitios -> definitions, ist -> is)
- please add the following line above your Signed-off-by line (to get
your fix also into -stable kernels): Fixes: 6db0f3a8a04e46 ("pinctrl:
amlogic: gxbb: add more UART pins")
- your "Signed-off-by" has to be in a specific format
- patches must be sent inline (not as attachment)
- the pinctrl maintainers are not Cc'ed (so they won't notice this patch)

here's a simplified version of the patch submission flow that I use:
- (change the code)
- git commit --signoff (give a good description why you are changing
things, include a Fixes line if appropriate)
- git format-patch HEAD~1
- run ./scripts/checkpatch.pl 0001-*.patch (fix all checkpatch errors,
"git commit --amend" the changes, then run git format-patch again)
- find the email recipients with: ./scripts/get_maintainer.pl 0001-*.patch
- run: git send-email 0001-*.patch --to=<maintainer or mailing list
email> --to=<another maintainer mailing list or email> --cc=<more
mailing lists...>

feel free to ask if you have any questions


I'm looking forward to an updated  patch!
Martin

Patch
diff mbox series

Hi i tried to use uart_C of the the odroid-c2.

I enabled it int the dts file. During boot it crashed when the
the sdcard slot is addressd.

After long search in the net i found this:

https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856


After changing the pin definitios accordingly erverything works.

Uart_c is functioning and sdcard ist working.



--- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c        2019-08-26 18:24:45.450089334 +0200
+++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c        2019-09-05 13:07:38.518637214 +0200
@@ -192,8 +192,8 @@  static const unsigned int uart_rts_b_pin
 
 static const unsigned int uart_tx_c_pins[]     = { GPIOY_13 };
 static const unsigned int uart_rx_c_pins[]     = { GPIOY_14 };
-static const unsigned int uart_cts_c_pins[]    = { GPIOX_11 };
-static const unsigned int uart_rts_c_pins[]    = { GPIOX_12 };
+static const unsigned int uart_cts_c_pins[]    = { GPIOY_11 };
+static const unsigned int uart_rts_c_pins[]    = { GPIOY_12 };
 
 static const unsigned int i2c_sck_a_pins[]     = { GPIODV_25 };
 static const unsigned int i2c_sda_a_pins[]     = { GPIODV_24 };
@@ -439,10 +439,10 @@  static struct meson_pmx_group meson_gxbb
        GROUP(pwm_f_x,          3,      18),
 
        /* Bank Y */
-       GROUP(uart_cts_c,       1,      19),
-       GROUP(uart_rts_c,       1,      18),
-       GROUP(uart_tx_c,        1,      17),
-       GROUP(uart_rx_c,        1,      16),
+       GROUP(uart_cts_c,       1,      17),
+       GROUP(uart_rts_c,       1,      16),
+       GROUP(uart_tx_c,        1,      19),
+       GROUP(uart_rx_c,        1,      18),
        GROUP(pwm_a_y,          1,      21),
        GROUP(pwm_f_y,          1,      20),
        GROUP(i2s_out_ch23_y,   1,      5),

signed off Otto Meier gf435@gmx.net