| Message ID | 20190905203527.1478314-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soundwire: add back ACPI dependency | expand |
On 05-09-19, 22:35, Arnd Bergmann wrote: > Soundwire gained a warning for randconfig builds without > CONFIG_ACPI during the linux-5.3-rc cycle: > > drivers/soundwire/slave.c:16:12: error: unused function 'sdw_slave_add' [-Werror,-Wunused-function] > > Add the CONFIG_ACPI dependency at the top level now. Did you run this yesterday or today. I have applied Srini's patches to add DT support for Soundwire couple of days back so we should not see this warning anymore > Fixes: 8676b3ca4673 ("soundwire: fix regmap dependencies and align with other serial links") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/soundwire/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig > index f518273cfbe3..c73bfbaa2659 100644 > --- a/drivers/soundwire/Kconfig > +++ b/drivers/soundwire/Kconfig > @@ -5,6 +5,7 @@ > > menuconfig SOUNDWIRE > tristate "SoundWire support" > + depends on ACPI > help > SoundWire is a 2-Pin interface with data and clock line ratified > by the MIPI Alliance. SoundWire is used for transporting data > -- > 2.20.0
On Fri, Sep 6, 2019 at 6:39 AM Vinod Koul <vkoul@kernel.org> wrote: > > On 05-09-19, 22:35, Arnd Bergmann wrote: > > Soundwire gained a warning for randconfig builds without > > CONFIG_ACPI during the linux-5.3-rc cycle: > > > > drivers/soundwire/slave.c:16:12: error: unused function 'sdw_slave_add' [-Werror,-Wunused-function] > > > > Add the CONFIG_ACPI dependency at the top level now. > > Did you run this yesterday or today. I have applied Srini's patches to > add DT support for Soundwire couple of days back so we should not see > this warning anymore This is on the latest linux-next, which is dated 20190904. As Stephen is not releasing any more linux-next kernels until later this month, I'm missing anything that came in afterwards. Arnd
On 06-09-19, 12:02, Arnd Bergmann wrote: > On Fri, Sep 6, 2019 at 6:39 AM Vinod Koul <vkoul@kernel.org> wrote: > > > > On 05-09-19, 22:35, Arnd Bergmann wrote: > > > Soundwire gained a warning for randconfig builds without > > > CONFIG_ACPI during the linux-5.3-rc cycle: > > > > > > drivers/soundwire/slave.c:16:12: error: unused function 'sdw_slave_add' [-Werror,-Wunused-function] > > > > > > Add the CONFIG_ACPI dependency at the top level now. > > > > Did you run this yesterday or today. I have applied Srini's patches to > > add DT support for Soundwire couple of days back so we should not see > > this warning anymore > > This is on the latest linux-next, which is dated 20190904. As Stephen is > not releasing any more linux-next kernels until later this month, I'm > missing anything that came in afterwards. That is interesting as next-20190904 has the DT changes :) Can you share the config you used to get this. I have two instances of sdw_slave_add() in next-20190904: drivers/soundwire/slave.c: sdw_slave_add(bus, &id, acpi_fwnode_handle(adev)); drivers/soundwire/slave.c: sdw_slave_add(bus, &id, of_fwnode_handle(node)); Thanks
On Fri, Sep 6, 2019 at 12:45 PM Vinod Koul <vkoul@kernel.org> wrote: > On 06-09-19, 12:02, Arnd Bergmann wrote: > > On Fri, Sep 6, 2019 at 6:39 AM Vinod Koul <vkoul@kernel.org> wrote: > > > > > > On 05-09-19, 22:35, Arnd Bergmann wrote: > > > > Soundwire gained a warning for randconfig builds without > > > > CONFIG_ACPI during the linux-5.3-rc cycle: > > > > > > > > drivers/soundwire/slave.c:16:12: error: unused function 'sdw_slave_add' [-Werror,-Wunused-function] > > > > > > > > Add the CONFIG_ACPI dependency at the top level now. > > > > > > Did you run this yesterday or today. I have applied Srini's patches to > > > add DT support for Soundwire couple of days back so we should not see > > > this warning anymore > > > > This is on the latest linux-next, which is dated 20190904. As Stephen is > > not releasing any more linux-next kernels until later this month, I'm > > missing anything that came in afterwards. > > That is interesting as next-20190904 has the DT changes :) Can you share > the config you used to get this. > > I have two instances of sdw_slave_add() in next-20190904: > > drivers/soundwire/slave.c: sdw_slave_add(bus, &id, acpi_fwnode_handle(adev)); > drivers/soundwire/slave.c: sdw_slave_add(bus, &id, of_fwnode_handle(node)); Ok, I remember now: the warning I got was actually on mainline. It's fixed in linux-next, but from all I can tell, 5.3-rc7 is still broken. Arnd
diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig index f518273cfbe3..c73bfbaa2659 100644 --- a/drivers/soundwire/Kconfig +++ b/drivers/soundwire/Kconfig @@ -5,6 +5,7 @@ menuconfig SOUNDWIRE tristate "SoundWire support" + depends on ACPI help SoundWire is a 2-Pin interface with data and clock line ratified by the MIPI Alliance. SoundWire is used for transporting data
Soundwire gained a warning for randconfig builds without CONFIG_ACPI during the linux-5.3-rc cycle: drivers/soundwire/slave.c:16:12: error: unused function 'sdw_slave_add' [-Werror,-Wunused-function] Add the CONFIG_ACPI dependency at the top level now. Fixes: 8676b3ca4673 ("soundwire: fix regmap dependencies and align with other serial links") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/soundwire/Kconfig | 1 + 1 file changed, 1 insertion(+)