[v2,2/3] usb: renesas_usbhs: simplify usbhs_status_get_device_state()
diff mbox series

Message ID 1567771431-13235-2-git-send-email-external.veeraiyan.c@de.adit-jv.com
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
  • [v2,1/3] usb: renesas_usbhs: enable DVSE interrupt
Related show

Commit Message

veeraiyan chidambaram Sept. 6, 2019, 12:03 p.m. UTC
From: Eugeniu Rosca <erosca@de.adit-jv.com>

Similar to usbhs_status_get_ctrl_stage(), *_get_device_state() is not
supposed to return any error code since its return value is the DVSQ
bitfield of the INTSTS0 register. According to SoC HW manual rev1.00,
every single value of DVSQ[2:0] is valid and none is an error:

Device State
000: Powered state
001: Default state
010: Address state
011: Configuration state
1xx: Suspended state

Hence, simplify the function body. The motivation behind dropping the
switch/case construct is being able to implement reading the suspended
state. The latter (based on the above DVSQ[2:0] description) doesn't
have a unique value, but is rather a list of states (which makes
switch/case less suitable for reading/validating it):

100: (Suspended) Powered state
101: (Suspended) Default state
110: (Suspended) Address state
111: (Suspended) Configuration state

Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
v2: No change
v1: https://patchwork.kernel.org/patch/10581485/

 drivers/usb/renesas_usbhs/mod.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff mbox series

diff --git a/drivers/usb/renesas_usbhs/mod.c b/drivers/usb/renesas_usbhs/mod.c
index 87e08b1512ad..3384308169f5 100644
--- a/drivers/usb/renesas_usbhs/mod.c
+++ b/drivers/usb/renesas_usbhs/mod.c
@@ -170,17 +170,7 @@  void usbhs_mod_remove(struct usbhs_priv *priv)
 int usbhs_status_get_device_state(struct usbhs_irq_state *irq_state)
-	int state = irq_state->intsts0 & DVSQ_MASK;
-	switch (state) {
-		return state;
-	}
-	return -EIO;
+	return (int)irq_state->intsts0 & DVSQ_MASK;
 int usbhs_status_get_ctrl_stage(struct usbhs_irq_state *irq_state)