| Message ID | 9e667f19-434e-ed30-78cb-9ddc6323c51e@web.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scsi: ufs-hisi: Use PTR_ERR_OR_ZERO() in ufs_hisi_get_resource() | expand |
> > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sat, 7 Sep 2019 14:25:31 +0200 > > Simplify this function implementation by using a known function. > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Reviewed-by: Avri Altman <avri.altman@wdc.com> > --- > drivers/scsi/ufs/ufs-hisi.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/scsi/ufs/ufs-hisi.c b/drivers/scsi/ufs/ufs-hisi.c index > f4d1dca962c4..a0ea57c19dbc 100644 > --- a/drivers/scsi/ufs/ufs-hisi.c > +++ b/drivers/scsi/ufs/ufs-hisi.c > @@ -454,10 +454,7 @@ static int ufs_hisi_get_resource(struct ufs_hisi_host > *host) > /* get resource of ufs sys ctrl */ > mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > host->ufs_sys_ctrl = devm_ioremap_resource(dev, mem_res); > - if (IS_ERR(host->ufs_sys_ctrl)) > - return PTR_ERR(host->ufs_sys_ctrl); > - > - return 0; > + return PTR_ERR_OR_ZERO(host->ufs_sys_ctrl); > } > > static void ufs_hisi_set_pm_lvl(struct ufs_hba *hba) > -- > 2.23.0
diff --git a/drivers/scsi/ufs/ufs-hisi.c b/drivers/scsi/ufs/ufs-hisi.c index f4d1dca962c4..a0ea57c19dbc 100644 --- a/drivers/scsi/ufs/ufs-hisi.c +++ b/drivers/scsi/ufs/ufs-hisi.c @@ -454,10 +454,7 @@ static int ufs_hisi_get_resource(struct ufs_hisi_host *host) /* get resource of ufs sys ctrl */ mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 1); host->ufs_sys_ctrl = devm_ioremap_resource(dev, mem_res); - if (IS_ERR(host->ufs_sys_ctrl)) - return PTR_ERR(host->ufs_sys_ctrl); - - return 0; + return PTR_ERR_OR_ZERO(host->ufs_sys_ctrl); } static void ufs_hisi_set_pm_lvl(struct ufs_hba *hba)