From patchwork Tue Sep 10 10:02:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 11139133 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0720076 for ; Tue, 10 Sep 2019 10:02:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E2EB72089F for ; Tue, 10 Sep 2019 10:02:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391894AbfIJKCH (ORCPT ); Tue, 10 Sep 2019 06:02:07 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:49084 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388547AbfIJKCH (ORCPT ); Tue, 10 Sep 2019 06:02:07 -0400 X-IronPort-AV: E=Sophos;i="5.64,489,1559512800"; d="scan'208";a="318878844" Received: from portablejulia.rsr.lip6.fr ([132.227.76.63]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Sep 2019 12:02:03 +0200 Date: Tue, 10 Sep 2019 12:02:04 +0200 (CEST) From: Julia Lawall X-X-Sender: julia@hadrien To: jassisinghbrar@gmail.com cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, robh+dt@kernel.org, masami.hiramatsu@linaro.org, orito.takao@socionext.com, Jassi Brar , kbuild-all@01.org Subject: [PATCH] dmaengine: milbeaut-hdmac: fix returnvar.cocci warnings Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org From: kbuild test robot Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: 7cff81f3886d ("dmaengine: milbeaut-hdmac: Add HDMAC driver for Milbeaut platforms") CC: Jassi Brar Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- url: https://github.com/0day-ci/linux/commits/jassisinghbrar-gmail-com/Add-support-for-AHB-DMA-controller-on-Milbeaut-series/20190910-142047 :::::: branch date: 2 hours ago :::::: commit date: 2 hours ago Please take the patch only if it's a positive warning. Thanks! milbeaut-hdmac.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/drivers/dma/milbeaut-hdmac.c +++ b/drivers/dma/milbeaut-hdmac.c @@ -171,7 +171,6 @@ static irqreturn_t milbeaut_hdmac_interr { struct milbeaut_hdmac_chan *mc = dev_id; struct milbeaut_hdmac_desc *md; - irqreturn_t ret = IRQ_HANDLED; u32 val; spin_lock(&mc->vc.lock); @@ -201,7 +200,7 @@ static irqreturn_t milbeaut_hdmac_interr out: spin_unlock(&mc->vc.lock); - return ret; + return IRQ_HANDLED; } static void milbeaut_hdmac_free_chan_resources(struct dma_chan *chan) @@ -289,7 +288,6 @@ static int milbeaut_hdmac_terminate_all( struct virt_dma_chan *vc = to_virt_chan(chan); struct milbeaut_hdmac_chan *mc = to_milbeaut_hdmac_chan(vc); unsigned long flags; - int ret = 0; u32 val; LIST_HEAD(head); @@ -311,7 +309,7 @@ static int milbeaut_hdmac_terminate_all( vchan_dma_desc_free_list(vc, &head); - return ret; + return 0; } static void milbeaut_hdmac_synchronize(struct dma_chan *chan)