[v4,2/6] dt-bindings: samsung: Update the CHIP ID binding documentation
diff mbox series

Message ID 20190910123618.27985-3-s.nawrocki@samsung.com
State Superseded
Headers show
Series
  • Exynos Adaptive Supply Voltage support
Related show

Commit Message

Sylwester Nawrocki Sept. 10, 2019, 12:36 p.m. UTC
This patch adds documentation of a new optional "samsung,asv-bin"
property in the chipid device node and documents requirement of
"syscon" compatible string.  These additions are needed to support
Exynos ASV (Adaptive Supply Voltage) feature.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
Changes since v3:
 - none

Changes since v2:
 - corrected patch summary line prefix, the patch moved in the
   sequence

Changes since v1 (RFC):
 - new patch
---
 .../devicetree/bindings/arm/samsung/exynos-chipid.txt  | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

--
2.17.1

Comments

Rob Herring Sept. 17, 2019, 6:13 p.m. UTC | #1
On Tue, 10 Sep 2019 14:36:14 +0200, Sylwester Nawrocki wrote:
> This patch adds documentation of a new optional "samsung,asv-bin"
> property in the chipid device node and documents requirement of
> "syscon" compatible string.  These additions are needed to support
> Exynos ASV (Adaptive Supply Voltage) feature.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> Changes since v3:
>  - none
> 
> Changes since v2:
>  - corrected patch summary line prefix, the patch moved in the
>    sequence
> 
> Changes since v1 (RFC):
>  - new patch
> ---
>  .../devicetree/bindings/arm/samsung/exynos-chipid.txt  | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Krzysztof Kozlowski Oct. 2, 2019, 3:48 p.m. UTC | #2
On Tue, Sep 17, 2019 at 01:13:22PM -0500, Rob Herring wrote:
> On Tue, 10 Sep 2019 14:36:14 +0200, Sylwester Nawrocki wrote:
> > This patch adds documentation of a new optional "samsung,asv-bin"
> > property in the chipid device node and documents requirement of
> > "syscon" compatible string.  These additions are needed to support
> > Exynos ASV (Adaptive Supply Voltage) feature.
> > 
> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> > ---
> > Changes since v3:
> >  - none
> > 
> > Changes since v2:
> >  - corrected patch summary line prefix, the patch moved in the
> >    sequence
> > 
> > Changes since v1 (RFC):
> >  - new patch
> > ---
> >  .../devicetree/bindings/arm/samsung/exynos-chipid.txt  | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> > 
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Dear Sylwester,

This will create conflicts with conversion to dt-schema (already picked
up by Rob).

Can you convert this patch to dt-schema format and send it for Rob?

Best regards,
Krzysztof
Sylwester Nawrocki Oct. 2, 2019, 4 p.m. UTC | #3
On 10/2/19 17:48, Krzysztof Kozlowski wrote:
> This will create conflicts with conversion to dt-schema (already picked
> up by Rob).
> 
> Can you convert this patch to dt-schema format and send it for Rob?

Sure, I will convert the patch.

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt
index 85c5dfd4a720..be3657e6c00c 100644
--- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt
+++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt
@@ -1,12 +1,18 @@ 
-SAMSUNG Exynos SoCs Chipid driver.
+SAMSUNG Exynos SoC series CHIPID subsystem

 Required properties:
-- compatible : Should at least contain "samsung,exynos4210-chipid".
+- compatible : Should at least contain "samsung,exynos4210-chipid", "syscon".

 - reg: offset and length of the register set

+Optional properties:
+ - samsung,asv-bin : Adaptive Supply Voltage bin selection. This can be used
+   to determine the ASV bin of an SoC if respective information is missing
+   in the CHIPID registers or in the OTP memory. Possible values: 0...3.
+
 Example:
 	chipid@10000000 {
 		compatible = "samsung,exynos4210-chipid";
 		reg = <0x10000000 0x100>;
+		samsung,asv-bin = <2>;
 	};