drm/i915/tgl: Disable rc6 for debugging
diff mbox series

Message ID 20190910153627.22820-1-chris@chris-wilson.co.uk
State New
Headers show
Series
  • drm/i915/tgl: Disable rc6 for debugging
Related show

Commit Message

Chris Wilson Sept. 10, 2019, 3:36 p.m. UTC
References: https://bugs.freedesktop.org/show_bug.cgi?id=111593
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_pci.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Chris Wilson Sept. 10, 2019, 4:13 p.m. UTC | #1
Quoting Patchwork (2019-09-10 17:06:36)
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14343/
> 
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_14343 that come from known issues:

tgl died in gem_exec_gttfill, so not rc6, or even runtime-pm, by itself.
Seems forcewake is the key.
-Chris
Chris Wilson Sept. 10, 2019, 7:43 p.m. UTC | #2
Quoting Patchwork (2019-09-10 18:24:49)
> == Series Details ==
> 
> Series: drm/i915/tgl: Disable rc6 for debugging (rev2)
> URL   : https://patchwork.freedesktop.org/series/66492/
> State : success
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_6861 -> Patchwork_14346
> ====================================================
> 
> Summary
> -------
> 
>   **SUCCESS**
> 
>   No regressions found.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14346/
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_14346:
> 
> ### IGT changes ###
> 
> #### Suppressed ####
> 
>   The following results come from untrusted machines, tests, or statuses.
>   They do not affect the overall result.
> 
>   * igt@i915_pm_rpm@basic-pci-d3-state:
>     - {fi-tgl-u}:         NOTRUN -> [SKIP][1]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14346/fi-tgl-u/igt@i915_pm_rpm@basic-pci-d3-state.html
> 
>   * igt@i915_pm_rpm@basic-rte:
>     - {fi-tgl-u}:         NOTRUN -> [FAIL][2]
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14346/fi-tgl-u/igt@i915_pm_rpm@basic-rte.html
> 
>   * igt@i915_selftest@live_gem_contexts:
>     - {fi-tgl-u}:         NOTRUN -> [DMESG-FAIL][3]
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14346/fi-tgl-u/igt@i915_selftest@live_gem_contexts.html

That worked a lot better! So the BIOS left rc6 enabled...
-Chris
Chris Wilson Sept. 10, 2019, 7:49 p.m. UTC | #3
Quoting Patchwork (2019-09-10 18:24:49)
>   * igt@i915_selftest@live_gem_contexts:
>     - {fi-tgl-u}:         NOTRUN -> [DMESG-FAIL][3]
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14346/fi-tgl-u/igt@i915_selftest@live_gem_contexts.html

Doesn't that look familiar. Same breakage as icl...
-Chris

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index fbe98a2db88e..b3cc8560696b 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -797,6 +797,7 @@  static const struct intel_device_info intel_tigerlake_12_info = {
 	.display.has_modular_fia = 1,
 	.engine_mask =
 		BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0) | BIT(VCS2),
+	.has_rc6 = false, /* XXX disabled for debugging */
 };
 
 #undef GEN