drm/i915/tgl: Disable rc6 for debugging
diff mbox series

Message ID 20190910161657.23037-1-chris@chris-wilson.co.uk
State New
Headers show
Series
  • drm/i915/tgl: Disable rc6 for debugging
Related show

Commit Message

Chris Wilson Sept. 10, 2019, 4:16 p.m. UTC
References: https://bugs.freedesktop.org/show_bug.cgi?id=111593
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_pci.c | 1 +
 drivers/gpu/drm/i915/intel_pm.c | 3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Matthew Auld Sept. 10, 2019, 7:56 p.m. UTC | #1
On Tue, 10 Sep 2019 at 17:17, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=111593
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Acked-by: Matthew Auld <matthew.auld@intel.com>
Chris Wilson Sept. 10, 2019, 8:33 p.m. UTC | #2
Quoting Matthew Auld (2019-09-10 20:56:48)
> On Tue, 10 Sep 2019 at 17:17, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=111593
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Acked-by: Matthew Auld <matthew.auld@intel.com>

Filled in the blurb and pushed. Let's see how this holds and in the
morning we can start tracking down what's missing.
-Chris

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index fbe98a2db88e..b3cc8560696b 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -797,6 +797,7 @@  static const struct intel_device_info intel_tigerlake_12_info = {
 	.display.has_modular_fia = 1,
 	.engine_mask =
 		BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0) | BIT(VCS2),
+	.has_rc6 = false, /* XXX disabled for debugging */
 };
 
 #undef GEN
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 528e90ed5de4..54a8b7705bc6 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -8671,8 +8671,7 @@  void intel_disable_gt_powersave(struct drm_i915_private *dev_priv)
 {
 	mutex_lock(&dev_priv->gt_pm.rps.lock);
 
-	if (HAS_RC6(dev_priv))
-		intel_disable_rc6(dev_priv);
+	intel_disable_rc6(dev_priv);
 
 	intel_disable_rps(dev_priv);
 	if (HAS_LLC(dev_priv))