| Message ID | 20190910190756.31432-3-jae.hyun.yoo@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: aspeed: refine mode detection flow | expand |
On Wed, 11 Sep 2019, at 04:37, Jae Hyun Yoo wrote: > Sometimes it detects a weird resolution such as 1024x287 when the > actual resolution is 1024x768. To resolve such an issue, this > commit adds clearing for hsync and vsync polarity register bits > at the beginning of the first mode detection. This is recommended > in the datasheet. I guess this answers my question on the previous patch's commit message. Maybe it should be in both? Andrew
On 9/11/2019 10:39 PM, Andrew Jeffery wrote: > > > On Wed, 11 Sep 2019, at 04:37, Jae Hyun Yoo wrote: >> Sometimes it detects a weird resolution such as 1024x287 when the >> actual resolution is 1024x768. To resolve such an issue, this >> commit adds clearing for hsync and vsync polarity register bits >> at the beginning of the first mode detection. This is recommended >> in the datasheet. > > I guess this answers my question on the previous patch's commit > message. Maybe it should be in both? I think the previous patch is a bug fix and this one is an enhancement patch. Better splitting them. Thanks, Jae
On Fri, 13 Sep 2019, at 02:36, Jae Hyun Yoo wrote: > On 9/11/2019 10:39 PM, Andrew Jeffery wrote: > > > > > > On Wed, 11 Sep 2019, at 04:37, Jae Hyun Yoo wrote: > >> Sometimes it detects a weird resolution such as 1024x287 when the > >> actual resolution is 1024x768. To resolve such an issue, this > >> commit adds clearing for hsync and vsync polarity register bits > >> at the beginning of the first mode detection. This is recommended > >> in the datasheet. > > > > I guess this answers my question on the previous patch's commit > > message. Maybe it should be in both? > > I think the previous patch is a bug fix and this one is an enhancement > patch. Better splitting them. I wasn't suggesting squashing the patches, I was suggesting updating the commit message of the first patch to better justify/explain the change. Andrew
On 9/12/2019 5:18 PM, Andrew Jeffery wrote: > > > On Fri, 13 Sep 2019, at 02:36, Jae Hyun Yoo wrote: >> On 9/11/2019 10:39 PM, Andrew Jeffery wrote: >>> >>> >>> On Wed, 11 Sep 2019, at 04:37, Jae Hyun Yoo wrote: >>>> Sometimes it detects a weird resolution such as 1024x287 when the >>>> actual resolution is 1024x768. To resolve such an issue, this >>>> commit adds clearing for hsync and vsync polarity register bits >>>> at the beginning of the first mode detection. This is recommended >>>> in the datasheet. >>> >>> I guess this answers my question on the previous patch's commit >>> message. Maybe it should be in both? >> >> I think the previous patch is a bug fix and this one is an enhancement >> patch. Better splitting them. > > I wasn't suggesting squashing the patches, I was suggesting updating > the commit message of the first patch to better justify/explain the > change. Okay. Will update the commit message of the first patch. Thanks, Jae
diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c index 8f77079da55a..929b3a5b8849 100644 --- a/drivers/media/platform/aspeed-video.c +++ b/drivers/media/platform/aspeed-video.c @@ -740,6 +740,8 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) } set_bit(VIDEO_RES_DETECT, &video->flags); + aspeed_video_update(video, VE_CTRL, + VE_CTRL_VSYNC_POL | VE_CTRL_HSYNC_POL, 0); aspeed_video_enable_mode_detect(video); rc = wait_event_interruptible_timeout(video->wait,
Sometimes it detects a weird resolution such as 1024x287 when the actual resolution is 1024x768. To resolve such an issue, this commit adds clearing for hsync and vsync polarity register bits at the beginning of the first mode detection. This is recommended in the datasheet. Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> --- drivers/media/platform/aspeed-video.c | 2 ++ 1 file changed, 2 insertions(+)