| Message ID | 20190911125717.28997-1-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/tgl: Disable read-only support | expand |
Chris Wilson <chris@chris-wilson.co.uk> writes: > The same read-only affliction as befell Icelake is affecting Tigerlake. > Disable the read-only support as cleary it was not fixed. > > Testcase: igt/i915_selftests/live_gem_context > References: 3936867dbc1e ("drm/i915: Disable read only ppgtt support for gen11") > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c > index e4f66bfe74c2..a09a9b62afbe 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -1486,8 +1486,10 @@ static struct i915_ppgtt *gen8_ppgtt_create(struct drm_i915_private *i915) > * > * Gen11 has HSDES#:1807136187 unresolved. Disable ro support > * for now. > + * > + * Gen12 has inherited the same read-only fault issue from gen11. > */ > - ppgtt->vm.has_read_only = INTEL_GEN(i915) != 11; > + ppgtt->vm.has_read_only = !IS_GEN_RANGE(i915, 11, 12); > > /* There are only few exceptions for gen >=6. chv and bxt. > * And we are not sure about the latter so play safe for now. > -- > 2.23.0
Quoting Mika Kuoppala (2019-09-11 14:08:10) > Chris Wilson <chris@chris-wilson.co.uk> writes: > > > The same read-only affliction as befell Icelake is affecting Tigerlake. > > Disable the read-only support as cleary it was not fixed. > > > > Testcase: igt/i915_selftests/live_gem_context > > References: 3936867dbc1e ("drm/i915: Disable read only ppgtt support for gen11") > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> > > Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> Pushed, we can try again later, but for now this should remove one more fail when Tigerlake comes back online. Provided it survives long enough to run selftests. -Chris
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index e4f66bfe74c2..a09a9b62afbe 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c @@ -1486,8 +1486,10 @@ static struct i915_ppgtt *gen8_ppgtt_create(struct drm_i915_private *i915) * * Gen11 has HSDES#:1807136187 unresolved. Disable ro support * for now. + * + * Gen12 has inherited the same read-only fault issue from gen11. */ - ppgtt->vm.has_read_only = INTEL_GEN(i915) != 11; + ppgtt->vm.has_read_only = !IS_GEN_RANGE(i915, 11, 12); /* There are only few exceptions for gen >=6. chv and bxt. * And we are not sure about the latter so play safe for now.
The same read-only affliction as befell Icelake is affecting Tigerlake. Disable the read-only support as cleary it was not fixed. Testcase: igt/i915_selftests/live_gem_context References: 3936867dbc1e ("drm/i915: Disable read only ppgtt support for gen11") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)