xen/arm: bootfd: Fix indentation in process_multiboot_node()
diff mbox series

Message ID 20190911151942.28459-1-julien.grall@arm.com
State New
Headers show
Series
  • xen/arm: bootfd: Fix indentation in process_multiboot_node()
Related show

Commit Message

Julien Grall Sept. 11, 2019, 3:19 p.m. UTC
One line in process_multiboot_node() is using hard tab rather than soft
tab. So fix it!

Signed-off-by: Julien Grall <julien.grall@arm.com>
---
 xen/arch/arm/bootfdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Volodymyr Babchuk Sept. 11, 2019, 5:33 p.m. UTC | #1
Julien Grall writes:

> One line in process_multiboot_node() is using hard tab rather than soft
> tab. So fix it!
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

So, hunting them one-by-one is the preferred way? I'm asking this
because there are more of them:

% find xen/arch/arm -type f -name "*.[ch]" -exec grep -lP "\t" {} \;
xen/arch/arm/traps.c
xen/arch/arm/acpi/boot.c
xen/arch/arm/arm32/lib/assembler.h
xen/arch/arm/arm64/livepatch.c
xen/arch/arm/arm64/lib/find_next_bit.c
xen/arch/arm/arm64/insn.c
xen/arch/arm/alternative.c
xen/arch/arm/bootfdt.c (apparently, I don't have this patch applied)


> ---
>  xen/arch/arm/bootfdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index 258b057f00..623173bc7f 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -264,7 +264,7 @@ static void __init process_multiboot_node(const void *fdt, int node,
>          case 1: kind = BOOTMOD_RAMDISK; break;
>          default: break;
>          }
> -	if ( kind_guess > 1 && has_xsm_magic(start) )
> +        if ( kind_guess > 1 && has_xsm_magic(start) )
>              kind = BOOTMOD_XSM;
>      }
Julien Grall Sept. 11, 2019, 5:58 p.m. UTC | #2
On Wed, 11 Sep 2019, 18:36 Volodymyr Babchuk, <Volodymyr_Babchuk@epam.com>
wrote:

>
> Julien Grall writes:
>
> > One line in process_multiboot_node() is using hard tab rather than soft
> > tab. So fix it!
> >
> > Signed-off-by: Julien Grall <julien.grall@arm.com>
> Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
>
> So, hunting them one-by-one is the preferred way?


I usually do it while I touch code around. I found this one when debugging
a boot regression today. You are welcome to fix the rest although...

I'm asking this
> because there are more of them:
>
> % find xen/arch/arm -type f -name "*.[ch]" -exec grep -lP "\t" {} \;
> xen/arch/arm/traps.c
> xen/arch/arm/acpi/boot.c
> xen/arch/arm/arm32/lib/assembler.h
> xen/arch/arm/arm64/livepatch.c
> xen/arch/arm/arm64/lib/find_next_bit.c
> xen/arch/arm/arm64/insn.c
>

The 4 above are a copy from Linux and therefore hard tab should stay.

Cheers,


>
Stefano Stabellini Sept. 12, 2019, 5:06 p.m. UTC | #3
On Wed, 11 Sep 2019, Volodymyr Babchuk wrote:
> 
> Julien Grall writes:
> 
> > One line in process_multiboot_node() is using hard tab rather than soft
> > tab. So fix it!
> >
> > Signed-off-by: Julien Grall <julien.grall@arm.com>
> Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>

Patch
diff mbox series

diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
index 258b057f00..623173bc7f 100644
--- a/xen/arch/arm/bootfdt.c
+++ b/xen/arch/arm/bootfdt.c
@@ -264,7 +264,7 @@  static void __init process_multiboot_node(const void *fdt, int node,
         case 1: kind = BOOTMOD_RAMDISK; break;
         default: break;
         }
-	if ( kind_guess > 1 && has_xsm_magic(start) )
+        if ( kind_guess > 1 && has_xsm_magic(start) )
             kind = BOOTMOD_XSM;
     }