arm64: dts: renesas: r8a77970: Fix PWM3
diff mbox series

Message ID 20190912103143.985-1-kieran.bingham+renesas@ideasonboard.com
State Accepted
Delegated to: Geert Uytterhoeven
Headers show
Series
  • arm64: dts: renesas: r8a77970: Fix PWM3
Related show

Commit Message

Kieran Bingham Sept. 12, 2019, 10:31 a.m. UTC
The pwm3 was incorrectly added with a compatible reference to the
renesas,pwm-r8a7790 (H2) due to a single characther ommision.

Fix the compatible string.

Fixes: de625477c632 ("arm64: dts: renesas: r8a779{7|8}0: add PWM support")
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
 arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kieran Bingham Sept. 12, 2019, 10:47 a.m. UTC | #1
On 12/09/2019 11:31, Kieran Bingham wrote:
> The pwm3 was incorrectly added with a compatible reference to the
> renesas,pwm-r8a7790 (H2) due to a single characther ommision.

Ugh, my apologies :

 s/characther/character/
 s/ommision/omission/

Please fix up when applying if there's no need to send a v2.

--
Kieran


> 
> Fix the compatible string.
> 
> Fixes: de625477c632 ("arm64: dts: renesas: r8a779{7|8}0: add PWM support")
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index 2c4ab70e2a39..74c2c0024e45 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -652,7 +652,7 @@
>  		};
>  
>  		pwm3: pwm@e6e33000 {
> -			compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
> +			compatible = "renesas,pwm-r8a77970", "renesas,pwm-rcar";
>  			reg = <0 0xe6e33000 0 8>;
>  			#pwm-cells = <2>;
>  			clocks = <&cpg CPG_MOD 523>;
>
Geert Uytterhoeven Sept. 12, 2019, 12:14 p.m. UTC | #2
On Thu, Sep 12, 2019 at 12:47 PM Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
> On 12/09/2019 11:31, Kieran Bingham wrote:
> > The pwm3 was incorrectly added with a compatible reference to the
> > renesas,pwm-r8a7790 (H2) due to a single characther ommision.
>
> Ugh, my apologies :
>
>  s/characther/character/
>  s/ommision/omission/
>
> Please fix up when applying if there's no need to send a v2.
>
> --
> Kieran
>
>
> >
> > Fix the compatible string.
> >
> > Fixes: de625477c632 ("arm64: dts: renesas: r8a779{7|8}0: add PWM support")
> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.5, with the above fixed.

BTW, looks like PWM on R-Car Gen2 needs more love...

> > --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > @@ -652,7 +652,7 @@
> >               };
> >
> >               pwm3: pwm@e6e33000 {
> > -                     compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
> > +                     compatible = "renesas,pwm-r8a77970", "renesas,pwm-rcar";
> >                       reg = <0 0xe6e33000 0 8>;
> >                       #pwm-cells = <2>;
> >                       clocks = <&cpg CPG_MOD 523>;
> >

Gr{oetje,eeting}s,

                        Geert
Simon Horman Sept. 13, 2019, 8:23 a.m. UTC | #3
On Thu, Sep 12, 2019 at 11:31:43AM +0100, Kieran Bingham wrote:
> The pwm3 was incorrectly added with a compatible reference to the
> renesas,pwm-r8a7790 (H2) due to a single characther ommision.
> 
> Fix the compatible string.
> 
> Fixes: de625477c632 ("arm64: dts: renesas: r8a779{7|8}0: add PWM support")
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index 2c4ab70e2a39..74c2c0024e45 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -652,7 +652,7 @@
>  		};
>  
>  		pwm3: pwm@e6e33000 {
> -			compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
> +			compatible = "renesas,pwm-r8a77970", "renesas,pwm-rcar";
>  			reg = <0 0xe6e33000 0 8>;
>  			#pwm-cells = <2>;
>  			clocks = <&cpg CPG_MOD 523>;
> -- 
> 2.20.1
>

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
index 2c4ab70e2a39..74c2c0024e45 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -652,7 +652,7 @@ 
 		};
 
 		pwm3: pwm@e6e33000 {
-			compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
+			compatible = "renesas,pwm-r8a77970", "renesas,pwm-rcar";
 			reg = <0 0xe6e33000 0 8>;
 			#pwm-cells = <2>;
 			clocks = <&cpg CPG_MOD 523>;