| Message ID | 20190913162021.23329-1-andrew.cooper3@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drivers/acpi: Drop "ERST table was not found" message | expand |
On 13.09.2019 18:20, Andrew Cooper wrote: > ERST isn't a mandatory table, and also isn't very common to find. The message > is unnecessary noise during boot. Furthermore, it is redundant with the list > of found ACPI tables printed just ahead. > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Acked-by: Jan Beulich <jbeulich@suse.com>
diff --git a/xen/drivers/acpi/apei/erst.c b/xen/drivers/acpi/apei/erst.c index 23a4e822e7..c5df512b98 100644 --- a/xen/drivers/acpi/apei/erst.c +++ b/xen/drivers/acpi/apei/erst.c @@ -791,10 +791,9 @@ int __init erst_init(void) return -ENODEV; status = acpi_get_table_phys(ACPI_SIG_ERST, 0, &erst_addr, &erst_len); - if (status == AE_NOT_FOUND) { - printk(KERN_INFO "ERST table was not found\n"); + if (status == AE_NOT_FOUND) return -ENODEV; - } + if (ACPI_FAILURE(status)) { const char *msg = acpi_format_exception(status); printk(KERN_WARNING "Failed to get ERST table: %s\n", msg);
ERST isn't a mandatory table, and also isn't very common to find. The message is unnecessary noise during boot. Furthermore, it is redundant with the list of found ACPI tables printed just ahead. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Jan Beulich <JBeulich@suse.com> --- xen/drivers/acpi/apei/erst.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)