[CI,1/2] drm/connector: Share with non-atomic drivers the function to get the single encoder
diff mbox series

Message ID 20190913232857.389834-1-jose.souza@intel.com
State New
Headers show
Series
  • [CI,1/2] drm/connector: Share with non-atomic drivers the function to get the single encoder
Related show

Commit Message

José Roberto de Souza Sept. 13, 2019, 11:28 p.m. UTC
This 3 non-atomic drivers all have the same function getting the
only encoder available in the connector, also atomic drivers have
this fallback. So moving it a common place and sharing between atomic
and non-atomic drivers.

While at it I also removed the mention of
drm_atomic_helper_best_encoder() that was renamed in
commit 297e30b5d9b6 ("drm/atomic-helper: Unexport
drm_atomic_helper_best_encoder").

v3: moving drm_connector_get_single_encoder to drm_kms_helper module

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/ast/ast_mode.c             | 12 ------------
 drivers/gpu/drm/drm_atomic_helper.c        | 15 ++-------------
 drivers/gpu/drm/drm_crtc_helper.c          | 17 ++++++++++++++++-
 drivers/gpu/drm/drm_crtc_helper_internal.h |  3 +++
 drivers/gpu/drm/mgag200/mgag200_mode.c     | 11 -----------
 drivers/gpu/drm/udl/udl_connector.c        |  8 --------
 include/drm/drm_modeset_helper_vtables.h   |  7 +++----
 7 files changed, 24 insertions(+), 49 deletions(-)

Comments

José Roberto de Souza Sept. 16, 2019, 7:34 p.m. UTC | #1
Someone with drm-misc commit access could push this?

Thanks

On Sun, 2019-09-15 at 11:36 +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [CI,1/2] drm/connector: Share with non-
> atomic drivers the function to get the single encoder
> URL   : https://patchwork.freedesktop.org/series/66701/
> State : success
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_6894_full -> Patchwork_14412_full
> ====================================================
> 
> Summary
> -------
> 
>   **SUCCESS**
> 
>   No regressions found.
> 
>   
> 
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_14412_full that come from
> known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_exec_schedule@preempt-contexts-bsd2:
>     - shard-iclb:         [PASS][1] -> [SKIP][2] ([fdo#109276]) +14
> similar issues
>    [1]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb1/igt@gem_exec_schedule@preempt-contexts-bsd2.html
>    [2]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb7/igt@gem_exec_schedule@preempt-contexts-bsd2.html
> 
>   * igt@gem_exec_schedule@preemptive-hang-bsd:
>     - shard-iclb:         [PASS][3] -> [SKIP][4] ([fdo#111325]) +3
> similar issues
>    [3]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb6/igt@gem_exec_schedule@preemptive-hang-bsd.html
>    [4]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
> 
>   * igt@i915_pm_rpm@modeset-stress-extra-wait:
>     - shard-glk:          [PASS][5] -> [DMESG-WARN][6] ([fdo#105763]
> / [fdo#106538])
>    [5]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-glk7/igt@i915_pm_rpm@modeset-stress-extra-wait.html
>    [6]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html
> 
>   * igt@i915_suspend@fence-restore-tiled2untiled:
>     - shard-apl:          [PASS][7] -> [DMESG-WARN][8] ([fdo#108566])
> +3 similar issues
>    [7]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
>    [8]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html
> 
>   * igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent:
>     - shard-snb:          [PASS][9] -> [SKIP][10] ([fdo#109271])
>    [9]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-snb5/igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent.html
>    [10]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-snb7/igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent.html
> 
>   * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
>     - shard-hsw:          [PASS][11] -> [FAIL][12] ([fdo#105767])
>    [11]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
>    [12]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
> 
>   * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
>     - shard-glk:          [PASS][13] -> [FAIL][14] ([fdo#105363])
>    [13]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
>    [14]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
> 
>   * igt@kms_flip@basic-flip-vs-modeset:
>     - shard-apl:          [PASS][15] -> [INCOMPLETE][16]
> ([fdo#103927])
>    [15]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-apl7/igt@kms_flip@basic-flip-vs-modeset.html
>    [16]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-apl3/igt@kms_flip@basic-flip-vs-modeset.html
> 
>   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
>     - shard-apl:          [PASS][17] -> [FAIL][18] ([fdo#105363])
>    [17]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-apl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
>    [18]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-apl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> 
>   * igt@kms
> _frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
>     - shard-iclb:         [PASS][19] -> [FAIL][20] ([fdo#103167]) +7
> similar issues
>    [19]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
>    [20]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
> 
>   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
>     - shard-skl:          [PASS][21] -> [INCOMPLETE][22]
> ([fdo#104108])
>    [21]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
>    [22]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
> 
>   * igt@kms_plane_lowres@pipe-a-tiling-x:
>     - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#103166]) +1
> similar issue
>    [23]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html
>    [24]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-x.html
> 
>   * igt@kms_psr@psr2_cursor_render:
>     - shard-iclb:         [PASS][25] -> [SKIP][26] ([fdo#109441]) +3
> similar issues
>    [25]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
>    [26]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb6/igt@kms_psr@psr2_cursor_render.html
> 
>   * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
>     - shard-skl:          [PASS][27] -> [DMESG-WARN][28]
> ([fdo#106107])
>    [27]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl9/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
>    [28]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl10/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
> 
>   * igt@perf@polling:
>     - shard-skl:          [PASS][29] -> [FAIL][30] ([fdo#110728])
>    [29]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl2/igt@perf@polling.html
>    [30]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl6/igt@perf@polling.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@gem_eio@reset-stress:
>     - shard-iclb:         [FAIL][31] ([fdo#109661]) -> [PASS][32]
>    [31]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb2/igt@gem_eio@reset-stress.html
>    [32]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb6/igt@gem_eio@reset-stress.html
> 
>   * igt@gem_exec_schedule@preempt-queue-bsd1:
>     - shard-iclb:         [SKIP][33] ([fdo#109276]) -> [PASS][34] +10
> similar issues
>    [33]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb6/igt@gem_exec_schedule@preempt-queue-bsd1.html
>    [34]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd1.html
> 
>   * igt@gem_exec_schedule@preempt-self-bsd:
>     - shard-iclb:         [SKIP][35] ([fdo#111325]) -> [PASS][36]
>    [35]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb2/igt@gem_exec_schedule@preempt-self-bsd.html
>    [36]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb6/igt@gem_exec_schedule@preempt-self-bsd.html
> 
>   * igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen:
>     - shard-hsw:          [INCOMPLETE][37] ([fdo#103540]) ->
> [PASS][38]
>    [37]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-hsw8/igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen.html
>    [38]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-hsw1/igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen.html
> 
>   * igt@kms_flip@flip-vs-suspend-interruptible:
>     - shard-kbl:          [DMESG-WARN][39] ([fdo#108566]) ->
> [PASS][40] +1 similar issue
>    [39]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible.html
>    [40]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
>     - shard-iclb:         [FAIL][41] ([fdo#103167]) -> [PASS][42] +2
> similar issues
>    [41]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
>    [42]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
> 
>   * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
>     - shard-apl:          [DMESG-WARN][43] ([fdo#108566]) ->
> [PASS][44] +3 similar issues
>    [43]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
>    [44]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-apl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
> 
>   * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
>     - shard-skl:          [FAIL][45] ([fdo#108145]) -> [PASS][46]
>    [45]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
>    [46]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
> 
>   * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
>     - shard-skl:          [FAIL][47] ([fdo#108145] / [fdo#110403]) ->
> [PASS][48]
>    [47]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
>    [48]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> 
>   * igt@kms_psr@psr2_primary_mmap_gtt:
>     - shard-iclb:         [SKIP][49] ([fdo#109441]) -> [PASS][50] +1
> similar issue
>    [49]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html
>    [50]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
> 
>   * igt@kms_rotation_crc@cursor-rotation-180:
>     - shard-iclb:         [INCOMPLETE][51] ([fdo#107713] /
> [fdo#110026]) -> [PASS][52]
>    [51]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb7/igt@kms_rotation_crc@cursor-rotation-180.html
>    [52]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb8/igt@kms_rotation_crc@cursor-rotation-180.html
> 
>   * igt@perf@blocking:
>     - shard-skl:          [FAIL][53] ([fdo#110728]) -> [PASS][54]
>    [53]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl1/igt@perf@blocking.html
>    [54]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl2/igt@perf@blocking.html
> 
>   
> #### Warnings ####
> 
>   * igt@gem_ctx_isolation@vcs1-nonpriv:
>     - shard-iclb:         [FAIL][55] ([fdo#111329]) -> [SKIP][56]
> ([fdo#109276])
>    [55]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
>    [56]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html
> 
>   * igt@gem_exec_schedule@preempt-queue-chain-bsd:
>     - shard-iclb:         [SKIP][57] ([fdo#111325]) ->
> [INCOMPLETE][58] ([fdo#107713])
>    [57]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb4/igt@gem_exec_schedule@preempt-queue-chain-bsd.html
>    [58]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb7/igt@gem_exec_schedule@preempt-queue-chain-bsd.html
> 
>   * igt@gem_mocs_settings@mocs-reset-bsd2:
>     - shard-iclb:         [FAIL][59] ([fdo#111330]) -> [SKIP][60]
> ([fdo#109276])
>    [59]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb1/igt@gem_mocs_settings@mocs-reset-bsd2.html
>    [60]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb7/igt@gem_mocs_settings@mocs-reset-bsd2.html
> 
>   
>   [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
>   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
>   [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
>   [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
>   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
>   [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
>   [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
>   [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
>   [fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
>   [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
>   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>   [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
>   [fdo#110026]: https://bugs.freedesktop.org/show_bug.cgi?id=110026
>   [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
>   [fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
>   [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
>   [fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
>   [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
> 
> 
> Participating hosts (10 -> 10)
> ------------------------------
> 
>   No changes in participating hosts
> 
> 
> Build changes
> -------------
> 
>   * CI: CI-20190529 -> None
>   * Linux: CI_DRM_6894 -> Patchwork_14412
> 
>   CI-20190529: 20190529
>   CI_DRM_6894: a323fd657c577491b1660662624bac36bb964222 @
> git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5182: f7104497049e3761ac297b66fd5586849b3cfcc8 @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_14412: 71a0b54618371628a5f271b5c2432bcb20deabc8 @
> git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/
Manasi Navare Sept. 16, 2019, 7:39 p.m. UTC | #2
On Mon, Sep 16, 2019 at 07:34:32PM +0000, Souza, Jose wrote:
> Someone with drm-misc commit access could push this?
>

Sure will push this series.

Manasi
 
> Thanks
> 
> On Sun, 2019-09-15 at 11:36 +0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: series starting with [CI,1/2] drm/connector: Share with non-
> > atomic drivers the function to get the single encoder
> > URL   : https://patchwork.freedesktop.org/series/66701/
> > State : success
> > 
> > == Summary ==
> > 
> > CI Bug Log - changes from CI_DRM_6894_full -> Patchwork_14412_full
> > ====================================================
> > 
> > Summary
> > -------
> > 
> >   **SUCCESS**
> > 
> >   No regressions found.
> > 
> >   
> > 
> > Known issues
> > ------------
> > 
> >   Here are the changes found in Patchwork_14412_full that come from
> > known issues:
> > 
> > ### IGT changes ###
> > 
> > #### Issues hit ####
> > 
> >   * igt@gem_exec_schedule@preempt-contexts-bsd2:
> >     - shard-iclb:         [PASS][1] -> [SKIP][2] ([fdo#109276]) +14
> > similar issues
> >    [1]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb1/igt@gem_exec_schedule@preempt-contexts-bsd2.html
> >    [2]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb7/igt@gem_exec_schedule@preempt-contexts-bsd2.html
> > 
> >   * igt@gem_exec_schedule@preemptive-hang-bsd:
> >     - shard-iclb:         [PASS][3] -> [SKIP][4] ([fdo#111325]) +3
> > similar issues
> >    [3]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb6/igt@gem_exec_schedule@preemptive-hang-bsd.html
> >    [4]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
> > 
> >   * igt@i915_pm_rpm@modeset-stress-extra-wait:
> >     - shard-glk:          [PASS][5] -> [DMESG-WARN][6] ([fdo#105763]
> > / [fdo#106538])
> >    [5]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-glk7/igt@i915_pm_rpm@modeset-stress-extra-wait.html
> >    [6]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html
> > 
> >   * igt@i915_suspend@fence-restore-tiled2untiled:
> >     - shard-apl:          [PASS][7] -> [DMESG-WARN][8] ([fdo#108566])
> > +3 similar issues
> >    [7]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
> >    [8]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html
> > 
> >   * igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent:
> >     - shard-snb:          [PASS][9] -> [SKIP][10] ([fdo#109271])
> >    [9]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-snb5/igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent.html
> >    [10]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-snb7/igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent.html
> > 
> >   * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
> >     - shard-hsw:          [PASS][11] -> [FAIL][12] ([fdo#105767])
> >    [11]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
> >    [12]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
> > 
> >   * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
> >     - shard-glk:          [PASS][13] -> [FAIL][14] ([fdo#105363])
> >    [13]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
> >    [14]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
> > 
> >   * igt@kms_flip@basic-flip-vs-modeset:
> >     - shard-apl:          [PASS][15] -> [INCOMPLETE][16]
> > ([fdo#103927])
> >    [15]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-apl7/igt@kms_flip@basic-flip-vs-modeset.html
> >    [16]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-apl3/igt@kms_flip@basic-flip-vs-modeset.html
> > 
> >   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
> >     - shard-apl:          [PASS][17] -> [FAIL][18] ([fdo#105363])
> >    [17]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-apl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> >    [18]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-apl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> > 
> >   * igt@kms
> > _frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
> >     - shard-iclb:         [PASS][19] -> [FAIL][20] ([fdo#103167]) +7
> > similar issues
> >    [19]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
> >    [20]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
> > 
> >   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
> >     - shard-skl:          [PASS][21] -> [INCOMPLETE][22]
> > ([fdo#104108])
> >    [21]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
> >    [22]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
> > 
> >   * igt@kms_plane_lowres@pipe-a-tiling-x:
> >     - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#103166]) +1
> > similar issue
> >    [23]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html
> >    [24]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-x.html
> > 
> >   * igt@kms_psr@psr2_cursor_render:
> >     - shard-iclb:         [PASS][25] -> [SKIP][26] ([fdo#109441]) +3
> > similar issues
> >    [25]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
> >    [26]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb6/igt@kms_psr@psr2_cursor_render.html
> > 
> >   * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
> >     - shard-skl:          [PASS][27] -> [DMESG-WARN][28]
> > ([fdo#106107])
> >    [27]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl9/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
> >    [28]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl10/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
> > 
> >   * igt@perf@polling:
> >     - shard-skl:          [PASS][29] -> [FAIL][30] ([fdo#110728])
> >    [29]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl2/igt@perf@polling.html
> >    [30]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl6/igt@perf@polling.html
> > 
> >   
> > #### Possible fixes ####
> > 
> >   * igt@gem_eio@reset-stress:
> >     - shard-iclb:         [FAIL][31] ([fdo#109661]) -> [PASS][32]
> >    [31]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb2/igt@gem_eio@reset-stress.html
> >    [32]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb6/igt@gem_eio@reset-stress.html
> > 
> >   * igt@gem_exec_schedule@preempt-queue-bsd1:
> >     - shard-iclb:         [SKIP][33] ([fdo#109276]) -> [PASS][34] +10
> > similar issues
> >    [33]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb6/igt@gem_exec_schedule@preempt-queue-bsd1.html
> >    [34]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd1.html
> > 
> >   * igt@gem_exec_schedule@preempt-self-bsd:
> >     - shard-iclb:         [SKIP][35] ([fdo#111325]) -> [PASS][36]
> >    [35]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb2/igt@gem_exec_schedule@preempt-self-bsd.html
> >    [36]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb6/igt@gem_exec_schedule@preempt-self-bsd.html
> > 
> >   * igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen:
> >     - shard-hsw:          [INCOMPLETE][37] ([fdo#103540]) ->
> > [PASS][38]
> >    [37]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-hsw8/igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen.html
> >    [38]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-hsw1/igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen.html
> > 
> >   * igt@kms_flip@flip-vs-suspend-interruptible:
> >     - shard-kbl:          [DMESG-WARN][39] ([fdo#108566]) ->
> > [PASS][40] +1 similar issue
> >    [39]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible.html
> >    [40]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible.html
> > 
> >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
> >     - shard-iclb:         [FAIL][41] ([fdo#103167]) -> [PASS][42] +2
> > similar issues
> >    [41]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
> >    [42]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
> > 
> >   * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
> >     - shard-apl:          [DMESG-WARN][43] ([fdo#108566]) ->
> > [PASS][44] +3 similar issues
> >    [43]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
> >    [44]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-apl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
> > 
> >   * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
> >     - shard-skl:          [FAIL][45] ([fdo#108145]) -> [PASS][46]
> >    [45]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
> >    [46]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
> > 
> >   * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
> >     - shard-skl:          [FAIL][47] ([fdo#108145] / [fdo#110403]) ->
> > [PASS][48]
> >    [47]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> >    [48]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> > 
> >   * igt@kms_psr@psr2_primary_mmap_gtt:
> >     - shard-iclb:         [SKIP][49] ([fdo#109441]) -> [PASS][50] +1
> > similar issue
> >    [49]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html
> >    [50]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
> > 
> >   * igt@kms_rotation_crc@cursor-rotation-180:
> >     - shard-iclb:         [INCOMPLETE][51] ([fdo#107713] /
> > [fdo#110026]) -> [PASS][52]
> >    [51]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb7/igt@kms_rotation_crc@cursor-rotation-180.html
> >    [52]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb8/igt@kms_rotation_crc@cursor-rotation-180.html
> > 
> >   * igt@perf@blocking:
> >     - shard-skl:          [FAIL][53] ([fdo#110728]) -> [PASS][54]
> >    [53]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl1/igt@perf@blocking.html
> >    [54]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl2/igt@perf@blocking.html
> > 
> >   
> > #### Warnings ####
> > 
> >   * igt@gem_ctx_isolation@vcs1-nonpriv:
> >     - shard-iclb:         [FAIL][55] ([fdo#111329]) -> [SKIP][56]
> > ([fdo#109276])
> >    [55]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
> >    [56]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html
> > 
> >   * igt@gem_exec_schedule@preempt-queue-chain-bsd:
> >     - shard-iclb:         [SKIP][57] ([fdo#111325]) ->
> > [INCOMPLETE][58] ([fdo#107713])
> >    [57]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb4/igt@gem_exec_schedule@preempt-queue-chain-bsd.html
> >    [58]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb7/igt@gem_exec_schedule@preempt-queue-chain-bsd.html
> > 
> >   * igt@gem_mocs_settings@mocs-reset-bsd2:
> >     - shard-iclb:         [FAIL][59] ([fdo#111330]) -> [SKIP][60]
> > ([fdo#109276])
> >    [59]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb1/igt@gem_mocs_settings@mocs-reset-bsd2.html
> >    [60]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb7/igt@gem_mocs_settings@mocs-reset-bsd2.html
> > 
> >   
> >   [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
> >   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> >   [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
> >   [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
> >   [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
> >   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> >   [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
> >   [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
> >   [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
> >   [fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
> >   [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
> >   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> >   [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
> >   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> >   [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
> >   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
> >   [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
> >   [fdo#110026]: https://bugs.freedesktop.org/show_bug.cgi?id=110026
> >   [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
> >   [fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
> >   [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
> >   [fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
> >   [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
> > 
> > 
> > Participating hosts (10 -> 10)
> > ------------------------------
> > 
> >   No changes in participating hosts
> > 
> > 
> > Build changes
> > -------------
> > 
> >   * CI: CI-20190529 -> None
> >   * Linux: CI_DRM_6894 -> Patchwork_14412
> > 
> >   CI-20190529: 20190529
> >   CI_DRM_6894: a323fd657c577491b1660662624bac36bb964222 @
> > git://anongit.freedesktop.org/gfx-ci/linux
> >   IGT_5182: f7104497049e3761ac297b66fd5586849b3cfcc8 @
> > git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> >   Patchwork_14412: 71a0b54618371628a5f271b5c2432bcb20deabc8 @
> > git://anongit.freedesktop.org/gfx-ci/linux
> >   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> > git://anongit.freedesktop.org/piglit
> > 
> > == Logs ==
> > 
> > For more details see: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
José Roberto de Souza Sept. 16, 2019, 9:12 p.m. UTC | #3
On Mon, 2019-09-16 at 12:39 -0700, Manasi Navare wrote:
> On Mon, Sep 16, 2019 at 07:34:32PM +0000, Souza, Jose wrote:
> > Someone with drm-misc commit access could push this?
> > 
> 
> Sure will push this series.

Thanks Manasi

> 
> Manasi
>  
> > Thanks
> > 
> > On Sun, 2019-09-15 at 11:36 +0000, Patchwork wrote:
> > > == Series Details ==
> > > 
> > > Series: series starting with [CI,1/2] drm/connector: Share with
> > > non-
> > > atomic drivers the function to get the single encoder
> > > URL   : https://patchwork.freedesktop.org/series/66701/
> > > State : success
> > > 
> > > == Summary ==
> > > 
> > > CI Bug Log - changes from CI_DRM_6894_full ->
> > > Patchwork_14412_full
> > > ====================================================
> > > 
> > > Summary
> > > -------
> > > 
> > >   **SUCCESS**
> > > 
> > >   No regressions found.
> > > 
> > >   
> > > 
> > > Known issues
> > > ------------
> > > 
> > >   Here are the changes found in Patchwork_14412_full that come
> > > from
> > > known issues:
> > > 
> > > ### IGT changes ###
> > > 
> > > #### Issues hit ####
> > > 
> > >   * igt@gem_exec_schedule@preempt-contexts-bsd2:
> > >     - shard-iclb:         [PASS][1] -> [SKIP][2] ([fdo#109276])
> > > +14
> > > similar issues
> > >    [1]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb1/igt@gem_exec_schedule@preempt-contexts-bsd2.html
> > >    [2]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb7/igt@gem_exec_schedule@preempt-contexts-bsd2.html
> > > 
> > >   * igt@gem_exec_schedule@preemptive-hang-bsd:
> > >     - shard-iclb:         [PASS][3] -> [SKIP][4] ([fdo#111325])
> > > +3
> > > similar issues
> > >    [3]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb6/igt@gem_exec_schedule@preemptive-hang-bsd.html
> > >    [4]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
> > > 
> > >   * igt@i915_pm_rpm@modeset-stress-extra-wait:
> > >     - shard-glk:          [PASS][5] -> [DMESG-WARN][6]
> > > ([fdo#105763]
> > > / [fdo#106538])
> > >    [5]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-glk7/igt@i915_pm_rpm@modeset-stress-extra-wait.html
> > >    [6]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html
> > > 
> > >   * igt@i915_suspend@fence-restore-tiled2untiled:
> > >     - shard-apl:          [PASS][7] -> [DMESG-WARN][8]
> > > ([fdo#108566])
> > > +3 similar issues
> > >    [7]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
> > >    [8]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html
> > > 
> > >   * igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent:
> > >     - shard-snb:          [PASS][9] -> [SKIP][10] ([fdo#109271])
> > >    [9]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-snb5/igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent.html
> > >    [10]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-snb7/igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent.html
> > > 
> > >   * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
> > >     - shard-hsw:          [PASS][11] -> [FAIL][12] ([fdo#105767])
> > >    [11]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
> > >    [12]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
> > > 
> > >   * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
> > >     - shard-glk:          [PASS][13] -> [FAIL][14] ([fdo#105363])
> > >    [13]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
> > >    [14]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
> > > 
> > >   * igt@kms_flip@basic-flip-vs-modeset:
> > >     - shard-apl:          [PASS][15] -> [INCOMPLETE][16]
> > > ([fdo#103927])
> > >    [15]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-apl7/igt@kms_flip@basic-flip-vs-modeset.html
> > >    [16]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-apl3/igt@kms_flip@basic-flip-vs-modeset.html
> > > 
> > >   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
> > >     - shard-apl:          [PASS][17] -> [FAIL][18] ([fdo#105363])
> > >    [17]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-apl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> > >    [18]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-apl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> > > 
> > >   * igt@kms
> > > _frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
> > >     - shard-iclb:         [PASS][19] -> [FAIL][20] ([fdo#103167])
> > > +7
> > > similar issues
> > >    [19]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
> > >    [20]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
> > > 
> > >   * igt@kms
> > > _plane@plane-panning-bottom-right-suspend-pipe-b-planes:
> > >     - shard-skl:          [PASS][21] -> [INCOMPLETE][22]
> > > ([fdo#104108])
> > >    [21]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
> > >    [22]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
> > > 
> > >   * igt@kms_plane_lowres@pipe-a-tiling-x:
> > >     - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#103166])
> > > +1
> > > similar issue
> > >    [23]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html
> > >    [24]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-x.html
> > > 
> > >   * igt@kms_psr@psr2_cursor_render:
> > >     - shard-iclb:         [PASS][25] -> [SKIP][26] ([fdo#109441])
> > > +3
> > > similar issues
> > >    [25]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
> > >    [26]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb6/igt@kms_psr@psr2_cursor_render.html
> > > 
> > >   * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
> > >     - shard-skl:          [PASS][27] -> [DMESG-WARN][28]
> > > ([fdo#106107])
> > >    [27]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl9/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
> > >    [28]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl10/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
> > > 
> > >   * igt@perf@polling:
> > >     - shard-skl:          [PASS][29] -> [FAIL][30] ([fdo#110728])
> > >    [29]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl2/igt@perf@polling.html
> > >    [30]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl6/igt@perf@polling.html
> > > 
> > >   
> > > #### Possible fixes ####
> > > 
> > >   * igt@gem_eio@reset-stress:
> > >     - shard-iclb:         [FAIL][31] ([fdo#109661]) -> [PASS][32]
> > >    [31]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb2/igt@gem_eio@reset-stress.html
> > >    [32]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb6/igt@gem_eio@reset-stress.html
> > > 
> > >   * igt@gem_exec_schedule@preempt-queue-bsd1:
> > >     - shard-iclb:         [SKIP][33] ([fdo#109276]) -> [PASS][34]
> > > +10
> > > similar issues
> > >    [33]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb6/igt@gem_exec_schedule@preempt-queue-bsd1.html
> > >    [34]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd1.html
> > > 
> > >   * igt@gem_exec_schedule@preempt-self-bsd:
> > >     - shard-iclb:         [SKIP][35] ([fdo#111325]) -> [PASS][36]
> > >    [35]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb2/igt@gem_exec_schedule@preempt-self-bsd.html
> > >    [36]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb6/igt@gem_exec_schedule@preempt-self-bsd.html
> > > 
> > >   * igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen:
> > >     - shard-hsw:          [INCOMPLETE][37] ([fdo#103540]) ->
> > > [PASS][38]
> > >    [37]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-hsw8/igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen.html
> > >    [38]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-hsw1/igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen.html
> > > 
> > >   * igt@kms_flip@flip-vs-suspend-interruptible:
> > >     - shard-kbl:          [DMESG-WARN][39] ([fdo#108566]) ->
> > > [PASS][40] +1 similar issue
> > >    [39]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible.html
> > >    [40]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible.html
> > > 
> > >   * igt@kms
> > > _frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
> > >     - shard-iclb:         [FAIL][41] ([fdo#103167]) -> [PASS][42]
> > > +2
> > > similar issues
> > >    [41]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
> > >    [42]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
> > > 
> > >   * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
> > >     - shard-apl:          [DMESG-WARN][43] ([fdo#108566]) ->
> > > [PASS][44] +3 similar issues
> > >    [43]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
> > >    [44]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-apl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
> > > 
> > >   * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
> > >     - shard-skl:          [FAIL][45] ([fdo#108145]) -> [PASS][46]
> > >    [45]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
> > >    [46]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
> > > 
> > >   * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
> > >     - shard-skl:          [FAIL][47] ([fdo#108145] /
> > > [fdo#110403]) ->
> > > [PASS][48]
> > >    [47]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> > >    [48]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> > > 
> > >   * igt@kms_psr@psr2_primary_mmap_gtt:
> > >     - shard-iclb:         [SKIP][49] ([fdo#109441]) -> [PASS][50]
> > > +1
> > > similar issue
> > >    [49]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html
> > >    [50]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
> > > 
> > >   * igt@kms_rotation_crc@cursor-rotation-180:
> > >     - shard-iclb:         [INCOMPLETE][51] ([fdo#107713] /
> > > [fdo#110026]) -> [PASS][52]
> > >    [51]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb7/igt@kms_rotation_crc@cursor-rotation-180.html
> > >    [52]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb8/igt@kms_rotation_crc@cursor-rotation-180.html
> > > 
> > >   * igt@perf@blocking:
> > >     - shard-skl:          [FAIL][53] ([fdo#110728]) -> [PASS][54]
> > >    [53]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl1/igt@perf@blocking.html
> > >    [54]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl2/igt@perf@blocking.html
> > > 
> > >   
> > > #### Warnings ####
> > > 
> > >   * igt@gem_ctx_isolation@vcs1-nonpriv:
> > >     - shard-iclb:         [FAIL][55] ([fdo#111329]) -> [SKIP][56]
> > > ([fdo#109276])
> > >    [55]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
> > >    [56]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html
> > > 
> > >   * igt@gem_exec_schedule@preempt-queue-chain-bsd:
> > >     - shard-iclb:         [SKIP][57] ([fdo#111325]) ->
> > > [INCOMPLETE][58] ([fdo#107713])
> > >    [57]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb4/igt@gem_exec_schedule@preempt-queue-chain-bsd.html
> > >    [58]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb7/igt@gem_exec_schedule@preempt-queue-chain-bsd.html
> > > 
> > >   * igt@gem_mocs_settings@mocs-reset-bsd2:
> > >     - shard-iclb:         [FAIL][59] ([fdo#111330]) -> [SKIP][60]
> > > ([fdo#109276])
> > >    [59]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb1/igt@gem_mocs_settings@mocs-reset-bsd2.html
> > >    [60]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb7/igt@gem_mocs_settings@mocs-reset-bsd2.html
> > > 
> > >   
> > >   [fdo#103166]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=103166
> > >   [fdo#103167]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=103167
> > >   [fdo#103540]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=103540
> > >   [fdo#103927]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=103927
> > >   [fdo#104108]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=104108
> > >   [fdo#105363]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=105363
> > >   [fdo#105763]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=105763
> > >   [fdo#105767]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=105767
> > >   [fdo#106107]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=106107
> > >   [fdo#106538]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=106538
> > >   [fdo#107713]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=107713
> > >   [fdo#108145]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=108145
> > >   [fdo#108566]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=108566
> > >   [fdo#109271]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=109271
> > >   [fdo#109276]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=109276
> > >   [fdo#109441]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=109441
> > >   [fdo#109661]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=109661
> > >   [fdo#110026]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=110026
> > >   [fdo#110403]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=110403
> > >   [fdo#110728]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=110728
> > >   [fdo#111325]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=111325
> > >   [fdo#111329]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=111329
> > >   [fdo#111330]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=111330
> > > 
> > > 
> > > Participating hosts (10 -> 10)
> > > ------------------------------
> > > 
> > >   No changes in participating hosts
> > > 
> > > 
> > > Build changes
> > > -------------
> > > 
> > >   * CI: CI-20190529 -> None
> > >   * Linux: CI_DRM_6894 -> Patchwork_14412
> > > 
> > >   CI-20190529: 20190529
> > >   CI_DRM_6894: a323fd657c577491b1660662624bac36bb964222 @
> > > git://anongit.freedesktop.org/gfx-ci/linux
> > >   IGT_5182: f7104497049e3761ac297b66fd5586849b3cfcc8 @
> > > git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> > >   Patchwork_14412: 71a0b54618371628a5f271b5c2432bcb20deabc8 @
> > > git://anongit.freedesktop.org/gfx-ci/linux
> > >   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> > > git://anongit.freedesktop.org/piglit
> > > 
> > > == Logs ==
> > > 
> > > For more details see: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Manasi Navare Sept. 16, 2019, 10:31 p.m. UTC | #4
Thanks for the patch and reviews, pushed to drm-misc

Regards
Manasi

On Mon, Sep 16, 2019 at 02:12:14PM -0700, Souza, Jose wrote:
> On Mon, 2019-09-16 at 12:39 -0700, Manasi Navare wrote:
> > On Mon, Sep 16, 2019 at 07:34:32PM +0000, Souza, Jose wrote:
> > > Someone with drm-misc commit access could push this?
> > > 
> > 
> > Sure will push this series.
> 
> Thanks Manasi
> 
> > 
> > Manasi
> >  
> > > Thanks
> > > 
> > > On Sun, 2019-09-15 at 11:36 +0000, Patchwork wrote:
> > > > == Series Details ==
> > > > 
> > > > Series: series starting with [CI,1/2] drm/connector: Share with
> > > > non-
> > > > atomic drivers the function to get the single encoder
> > > > URL   : https://patchwork.freedesktop.org/series/66701/
> > > > State : success
> > > > 
> > > > == Summary ==
> > > > 
> > > > CI Bug Log - changes from CI_DRM_6894_full ->
> > > > Patchwork_14412_full
> > > > ====================================================
> > > > 
> > > > Summary
> > > > -------
> > > > 
> > > >   **SUCCESS**
> > > > 
> > > >   No regressions found.
> > > > 
> > > >   
> > > > 
> > > > Known issues
> > > > ------------
> > > > 
> > > >   Here are the changes found in Patchwork_14412_full that come
> > > > from
> > > > known issues:
> > > > 
> > > > ### IGT changes ###
> > > > 
> > > > #### Issues hit ####
> > > > 
> > > >   * igt@gem_exec_schedule@preempt-contexts-bsd2:
> > > >     - shard-iclb:         [PASS][1] -> [SKIP][2] ([fdo#109276])
> > > > +14
> > > > similar issues
> > > >    [1]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb1/igt@gem_exec_schedule@preempt-contexts-bsd2.html
> > > >    [2]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb7/igt@gem_exec_schedule@preempt-contexts-bsd2.html
> > > > 
> > > >   * igt@gem_exec_schedule@preemptive-hang-bsd:
> > > >     - shard-iclb:         [PASS][3] -> [SKIP][4] ([fdo#111325])
> > > > +3
> > > > similar issues
> > > >    [3]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb6/igt@gem_exec_schedule@preemptive-hang-bsd.html
> > > >    [4]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
> > > > 
> > > >   * igt@i915_pm_rpm@modeset-stress-extra-wait:
> > > >     - shard-glk:          [PASS][5] -> [DMESG-WARN][6]
> > > > ([fdo#105763]
> > > > / [fdo#106538])
> > > >    [5]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-glk7/igt@i915_pm_rpm@modeset-stress-extra-wait.html
> > > >    [6]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html
> > > > 
> > > >   * igt@i915_suspend@fence-restore-tiled2untiled:
> > > >     - shard-apl:          [PASS][7] -> [DMESG-WARN][8]
> > > > ([fdo#108566])
> > > > +3 similar issues
> > > >    [7]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
> > > >    [8]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html
> > > > 
> > > >   * igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent:
> > > >     - shard-snb:          [PASS][9] -> [SKIP][10] ([fdo#109271])
> > > >    [9]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-snb5/igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent.html
> > > >    [10]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-snb7/igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent.html
> > > > 
> > > >   * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
> > > >     - shard-hsw:          [PASS][11] -> [FAIL][12] ([fdo#105767])
> > > >    [11]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
> > > >    [12]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
> > > > 
> > > >   * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
> > > >     - shard-glk:          [PASS][13] -> [FAIL][14] ([fdo#105363])
> > > >    [13]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
> > > >    [14]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
> > > > 
> > > >   * igt@kms_flip@basic-flip-vs-modeset:
> > > >     - shard-apl:          [PASS][15] -> [INCOMPLETE][16]
> > > > ([fdo#103927])
> > > >    [15]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-apl7/igt@kms_flip@basic-flip-vs-modeset.html
> > > >    [16]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-apl3/igt@kms_flip@basic-flip-vs-modeset.html
> > > > 
> > > >   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
> > > >     - shard-apl:          [PASS][17] -> [FAIL][18] ([fdo#105363])
> > > >    [17]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-apl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> > > >    [18]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-apl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> > > > 
> > > >   * igt@kms
> > > > _frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
> > > >     - shard-iclb:         [PASS][19] -> [FAIL][20] ([fdo#103167])
> > > > +7
> > > > similar issues
> > > >    [19]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
> > > >    [20]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
> > > > 
> > > >   * igt@kms
> > > > _plane@plane-panning-bottom-right-suspend-pipe-b-planes:
> > > >     - shard-skl:          [PASS][21] -> [INCOMPLETE][22]
> > > > ([fdo#104108])
> > > >    [21]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
> > > >    [22]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
> > > > 
> > > >   * igt@kms_plane_lowres@pipe-a-tiling-x:
> > > >     - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#103166])
> > > > +1
> > > > similar issue
> > > >    [23]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html
> > > >    [24]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-x.html
> > > > 
> > > >   * igt@kms_psr@psr2_cursor_render:
> > > >     - shard-iclb:         [PASS][25] -> [SKIP][26] ([fdo#109441])
> > > > +3
> > > > similar issues
> > > >    [25]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
> > > >    [26]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb6/igt@kms_psr@psr2_cursor_render.html
> > > > 
> > > >   * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
> > > >     - shard-skl:          [PASS][27] -> [DMESG-WARN][28]
> > > > ([fdo#106107])
> > > >    [27]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl9/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
> > > >    [28]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl10/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
> > > > 
> > > >   * igt@perf@polling:
> > > >     - shard-skl:          [PASS][29] -> [FAIL][30] ([fdo#110728])
> > > >    [29]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl2/igt@perf@polling.html
> > > >    [30]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl6/igt@perf@polling.html
> > > > 
> > > >   
> > > > #### Possible fixes ####
> > > > 
> > > >   * igt@gem_eio@reset-stress:
> > > >     - shard-iclb:         [FAIL][31] ([fdo#109661]) -> [PASS][32]
> > > >    [31]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb2/igt@gem_eio@reset-stress.html
> > > >    [32]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb6/igt@gem_eio@reset-stress.html
> > > > 
> > > >   * igt@gem_exec_schedule@preempt-queue-bsd1:
> > > >     - shard-iclb:         [SKIP][33] ([fdo#109276]) -> [PASS][34]
> > > > +10
> > > > similar issues
> > > >    [33]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb6/igt@gem_exec_schedule@preempt-queue-bsd1.html
> > > >    [34]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd1.html
> > > > 
> > > >   * igt@gem_exec_schedule@preempt-self-bsd:
> > > >     - shard-iclb:         [SKIP][35] ([fdo#111325]) -> [PASS][36]
> > > >    [35]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb2/igt@gem_exec_schedule@preempt-self-bsd.html
> > > >    [36]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb6/igt@gem_exec_schedule@preempt-self-bsd.html
> > > > 
> > > >   * igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen:
> > > >     - shard-hsw:          [INCOMPLETE][37] ([fdo#103540]) ->
> > > > [PASS][38]
> > > >    [37]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-hsw8/igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen.html
> > > >    [38]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-hsw1/igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen.html
> > > > 
> > > >   * igt@kms_flip@flip-vs-suspend-interruptible:
> > > >     - shard-kbl:          [DMESG-WARN][39] ([fdo#108566]) ->
> > > > [PASS][40] +1 similar issue
> > > >    [39]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible.html
> > > >    [40]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible.html
> > > > 
> > > >   * igt@kms
> > > > _frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
> > > >     - shard-iclb:         [FAIL][41] ([fdo#103167]) -> [PASS][42]
> > > > +2
> > > > similar issues
> > > >    [41]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
> > > >    [42]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
> > > > 
> > > >   * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
> > > >     - shard-apl:          [DMESG-WARN][43] ([fdo#108566]) ->
> > > > [PASS][44] +3 similar issues
> > > >    [43]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
> > > >    [44]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-apl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
> > > > 
> > > >   * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
> > > >     - shard-skl:          [FAIL][45] ([fdo#108145]) -> [PASS][46]
> > > >    [45]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
> > > >    [46]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
> > > > 
> > > >   * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
> > > >     - shard-skl:          [FAIL][47] ([fdo#108145] /
> > > > [fdo#110403]) ->
> > > > [PASS][48]
> > > >    [47]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> > > >    [48]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> > > > 
> > > >   * igt@kms_psr@psr2_primary_mmap_gtt:
> > > >     - shard-iclb:         [SKIP][49] ([fdo#109441]) -> [PASS][50]
> > > > +1
> > > > similar issue
> > > >    [49]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html
> > > >    [50]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
> > > > 
> > > >   * igt@kms_rotation_crc@cursor-rotation-180:
> > > >     - shard-iclb:         [INCOMPLETE][51] ([fdo#107713] /
> > > > [fdo#110026]) -> [PASS][52]
> > > >    [51]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb7/igt@kms_rotation_crc@cursor-rotation-180.html
> > > >    [52]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb8/igt@kms_rotation_crc@cursor-rotation-180.html
> > > > 
> > > >   * igt@perf@blocking:
> > > >     - shard-skl:          [FAIL][53] ([fdo#110728]) -> [PASS][54]
> > > >    [53]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-skl1/igt@perf@blocking.html
> > > >    [54]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-skl2/igt@perf@blocking.html
> > > > 
> > > >   
> > > > #### Warnings ####
> > > > 
> > > >   * igt@gem_ctx_isolation@vcs1-nonpriv:
> > > >     - shard-iclb:         [FAIL][55] ([fdo#111329]) -> [SKIP][56]
> > > > ([fdo#109276])
> > > >    [55]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
> > > >    [56]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html
> > > > 
> > > >   * igt@gem_exec_schedule@preempt-queue-chain-bsd:
> > > >     - shard-iclb:         [SKIP][57] ([fdo#111325]) ->
> > > > [INCOMPLETE][58] ([fdo#107713])
> > > >    [57]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb4/igt@gem_exec_schedule@preempt-queue-chain-bsd.html
> > > >    [58]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb7/igt@gem_exec_schedule@preempt-queue-chain-bsd.html
> > > > 
> > > >   * igt@gem_mocs_settings@mocs-reset-bsd2:
> > > >     - shard-iclb:         [FAIL][59] ([fdo#111330]) -> [SKIP][60]
> > > > ([fdo#109276])
> > > >    [59]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6894/shard-iclb1/igt@gem_mocs_settings@mocs-reset-bsd2.html
> > > >    [60]: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/shard-iclb7/igt@gem_mocs_settings@mocs-reset-bsd2.html
> > > > 
> > > >   
> > > >   [fdo#103166]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=103166
> > > >   [fdo#103167]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=103167
> > > >   [fdo#103540]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=103540
> > > >   [fdo#103927]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=103927
> > > >   [fdo#104108]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=104108
> > > >   [fdo#105363]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=105363
> > > >   [fdo#105763]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=105763
> > > >   [fdo#105767]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=105767
> > > >   [fdo#106107]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=106107
> > > >   [fdo#106538]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=106538
> > > >   [fdo#107713]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=107713
> > > >   [fdo#108145]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=108145
> > > >   [fdo#108566]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=108566
> > > >   [fdo#109271]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=109271
> > > >   [fdo#109276]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=109276
> > > >   [fdo#109441]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=109441
> > > >   [fdo#109661]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=109661
> > > >   [fdo#110026]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=110026
> > > >   [fdo#110403]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=110403
> > > >   [fdo#110728]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=110728
> > > >   [fdo#111325]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=111325
> > > >   [fdo#111329]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=111329
> > > >   [fdo#111330]: 
> > > > https://bugs.freedesktop.org/show_bug.cgi?id=111330
> > > > 
> > > > 
> > > > Participating hosts (10 -> 10)
> > > > ------------------------------
> > > > 
> > > >   No changes in participating hosts
> > > > 
> > > > 
> > > > Build changes
> > > > -------------
> > > > 
> > > >   * CI: CI-20190529 -> None
> > > >   * Linux: CI_DRM_6894 -> Patchwork_14412
> > > > 
> > > >   CI-20190529: 20190529
> > > >   CI_DRM_6894: a323fd657c577491b1660662624bac36bb964222 @
> > > > git://anongit.freedesktop.org/gfx-ci/linux
> > > >   IGT_5182: f7104497049e3761ac297b66fd5586849b3cfcc8 @
> > > > git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> > > >   Patchwork_14412: 71a0b54618371628a5f271b5c2432bcb20deabc8 @
> > > > git://anongit.freedesktop.org/gfx-ci/linux
> > > >   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> > > > git://anongit.freedesktop.org/piglit
> > > > 
> > > > == Logs ==
> > > > 
> > > > For more details see: 
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14412/
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patch
diff mbox series

diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index d349c721501c..eef95e1af06b 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -687,17 +687,6 @@  static void ast_encoder_destroy(struct drm_encoder *encoder)
 	kfree(encoder);
 }
 
-
-static struct drm_encoder *ast_best_single_encoder(struct drm_connector *connector)
-{
-	int enc_id = connector->encoder_ids[0];
-	/* pick the encoder ids */
-	if (enc_id)
-		return drm_encoder_find(connector->dev, NULL, enc_id);
-	return NULL;
-}
-
-
 static const struct drm_encoder_funcs ast_enc_funcs = {
 	.destroy = ast_encoder_destroy,
 };
@@ -847,7 +836,6 @@  static void ast_connector_destroy(struct drm_connector *connector)
 static const struct drm_connector_helper_funcs ast_connector_helper_funcs = {
 	.mode_valid = ast_mode_valid,
 	.get_modes = ast_get_modes,
-	.best_encoder = ast_best_single_encoder,
 };
 
 static const struct drm_connector_funcs ast_connector_funcs = {
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index 4706439fb490..9d7e4da6c292 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -97,17 +97,6 @@  drm_atomic_helper_plane_changed(struct drm_atomic_state *state,
 	}
 }
 
-/*
- * For connectors that support multiple encoders, either the
- * .atomic_best_encoder() or .best_encoder() operation must be implemented.
- */
-static struct drm_encoder *
-pick_single_encoder_for_connector(struct drm_connector *connector)
-{
-	WARN_ON(connector->encoder_ids[1]);
-	return drm_encoder_find(connector->dev, NULL, connector->encoder_ids[0]);
-}
-
 static int handle_conflicting_encoders(struct drm_atomic_state *state,
 				       bool disable_conflicting_encoders)
 {
@@ -135,7 +124,7 @@  static int handle_conflicting_encoders(struct drm_atomic_state *state,
 		else if (funcs->best_encoder)
 			new_encoder = funcs->best_encoder(connector);
 		else
-			new_encoder = pick_single_encoder_for_connector(connector);
+			new_encoder = drm_connector_get_single_encoder(connector);
 
 		if (new_encoder) {
 			if (encoder_mask & drm_encoder_mask(new_encoder)) {
@@ -359,7 +348,7 @@  update_connector_routing(struct drm_atomic_state *state,
 	else if (funcs->best_encoder)
 		new_encoder = funcs->best_encoder(connector);
 	else
-		new_encoder = pick_single_encoder_for_connector(connector);
+		new_encoder = drm_connector_get_single_encoder(connector);
 
 	if (!new_encoder) {
 		DRM_DEBUG_ATOMIC("No suitable encoder found for [CONNECTOR:%d:%s]\n",
diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index a51824a7e7c1..4a7447a53cea 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -460,6 +460,17 @@  drm_crtc_helper_disable(struct drm_crtc *crtc)
 	__drm_helper_disable_unused_functions(dev);
 }
 
+/*
+ * For connectors that support multiple encoders, either the
+ * .atomic_best_encoder() or .best_encoder() operation must be implemented.
+ */
+struct drm_encoder *
+drm_connector_get_single_encoder(struct drm_connector *connector)
+{
+	WARN_ON(connector->encoder_ids[1]);
+	return drm_encoder_find(connector->dev, NULL, connector->encoder_ids[0]);
+}
+
 /**
  * drm_crtc_helper_set_config - set a new config from userspace
  * @set: mode set configuration
@@ -625,7 +636,11 @@  int drm_crtc_helper_set_config(struct drm_mode_set *set,
 		new_encoder = connector->encoder;
 		for (ro = 0; ro < set->num_connectors; ro++) {
 			if (set->connectors[ro] == connector) {
-				new_encoder = connector_funcs->best_encoder(connector);
+				if (connector_funcs->best_encoder)
+					new_encoder = connector_funcs->best_encoder(connector);
+				else
+					new_encoder = drm_connector_get_single_encoder(connector);
+
 				/* if we can't get an encoder for a connector
 				   we are setting now - then fail */
 				if (new_encoder == NULL)
diff --git a/drivers/gpu/drm/drm_crtc_helper_internal.h b/drivers/gpu/drm/drm_crtc_helper_internal.h
index b5ac1581e623..f0a66ef47e5a 100644
--- a/drivers/gpu/drm/drm_crtc_helper_internal.h
+++ b/drivers/gpu/drm/drm_crtc_helper_internal.h
@@ -75,3 +75,6 @@  enum drm_mode_status drm_encoder_mode_valid(struct drm_encoder *encoder,
 					    const struct drm_display_mode *mode);
 enum drm_mode_status drm_connector_mode_valid(struct drm_connector *connector,
 					      struct drm_display_mode *mode);
+
+struct drm_encoder *
+drm_connector_get_single_encoder(struct drm_connector *connector);
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
index 5e778b5f1a10..68226556044b 100644
--- a/drivers/gpu/drm/mgag200/mgag200_mode.c
+++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
@@ -1638,16 +1638,6 @@  static enum drm_mode_status mga_vga_mode_valid(struct drm_connector *connector,
 	return MODE_OK;
 }
 
-static struct drm_encoder *mga_connector_best_encoder(struct drm_connector
-						  *connector)
-{
-	int enc_id = connector->encoder_ids[0];
-	/* pick the encoder ids */
-	if (enc_id)
-		return drm_encoder_find(connector->dev, NULL, enc_id);
-	return NULL;
-}
-
 static void mga_connector_destroy(struct drm_connector *connector)
 {
 	struct mga_connector *mga_connector = to_mga_connector(connector);
@@ -1659,7 +1649,6 @@  static void mga_connector_destroy(struct drm_connector *connector)
 static const struct drm_connector_helper_funcs mga_vga_connector_helper_funcs = {
 	.get_modes = mga_vga_get_modes,
 	.mode_valid = mga_vga_mode_valid,
-	.best_encoder = mga_connector_best_encoder,
 };
 
 static const struct drm_connector_funcs mga_vga_connector_funcs = {
diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c
index ddb61a60c610..b4ae3e89a7b4 100644
--- a/drivers/gpu/drm/udl/udl_connector.c
+++ b/drivers/gpu/drm/udl/udl_connector.c
@@ -90,13 +90,6 @@  udl_detect(struct drm_connector *connector, bool force)
 	return connector_status_connected;
 }
 
-static struct drm_encoder*
-udl_best_single_encoder(struct drm_connector *connector)
-{
-	int enc_id = connector->encoder_ids[0];
-	return drm_encoder_find(connector->dev, NULL, enc_id);
-}
-
 static int udl_connector_set_property(struct drm_connector *connector,
 				      struct drm_property *property,
 				      uint64_t val)
@@ -120,7 +113,6 @@  static void udl_connector_destroy(struct drm_connector *connector)
 static const struct drm_connector_helper_funcs udl_connector_helper_funcs = {
 	.get_modes = udl_get_modes,
 	.mode_valid = udl_mode_valid,
-	.best_encoder = udl_best_single_encoder,
 };
 
 static const struct drm_connector_funcs udl_connector_funcs = {
diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h
index 6b18c8adfe9d..5a87f1bd7a3f 100644
--- a/include/drm/drm_modeset_helper_vtables.h
+++ b/include/drm/drm_modeset_helper_vtables.h
@@ -955,9 +955,8 @@  struct drm_connector_helper_funcs {
 	 * @atomic_best_encoder.
 	 *
 	 * You can leave this function to NULL if the connector is only
-	 * attached to a single encoder and you are using the atomic helpers.
-	 * In this case, the core will call drm_atomic_helper_best_encoder()
-	 * for you.
+	 * attached to a single encoder. In this case, the core will call
+	 * drm_connector_get_single_encoder() for you.
 	 *
 	 * RETURNS:
 	 *
@@ -977,7 +976,7 @@  struct drm_connector_helper_funcs {
 	 *
 	 * This function is used by drm_atomic_helper_check_modeset().
 	 * If it is not implemented, the core will fallback to @best_encoder
-	 * (or drm_atomic_helper_best_encoder() if @best_encoder is NULL).
+	 * (or drm_connector_get_single_encoder() if @best_encoder is NULL).
 	 *
 	 * NOTE:
 	 *