| Message ID | 20190914000812.10188-1-navid.emamdoost@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d563131ef23cbc756026f839a82598c8445bc45f |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rsi: release skb if rsi_prepare_beacon fails | expand |
Navid Emamdoost <navid.emamdoost@gmail.com> wrote: > In rsi_send_beacon, if rsi_prepare_beacon fails the allocated skb should > be released. > > Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> Patch applied to wireless-drivers-next.git, thanks. d563131ef23c rsi: release skb if rsi_prepare_beacon fails
diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c index 6c7f26ef6476..9cc8a335d519 100644 --- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c +++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c @@ -1756,6 +1756,7 @@ static int rsi_send_beacon(struct rsi_common *common) skb_pull(skb, (64 - dword_align_bytes)); if (rsi_prepare_beacon(common, skb)) { rsi_dbg(ERR_ZONE, "Failed to prepare beacon\n"); + dev_kfree_skb(skb); return -EINVAL; } skb_queue_tail(&common->tx_queue[MGMT_BEACON_Q], skb);
In rsi_send_beacon, if rsi_prepare_beacon fails the allocated skb should be released. Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> --- drivers/net/wireless/rsi/rsi_91x_mgmt.c | 1 + 1 file changed, 1 insertion(+)