Message ID | 1568648453-5482-1-git-send-email-cai@lca.pw (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | mm/memcontrol: fix a -Wunused-function warning | expand |
On Mon 16-09-19 11:40:53, Qian Cai wrote: > mem_cgroup_id_get() was introduced in the commit 73f576c04b94 > ("mm:memcontrol: fix cgroup creation failure after many small jobs"). > > Later, it no longer has any user since the commits, > > 1f47b61fb407 ("mm: memcontrol: fix swap counter leak on swapout from offline cgroup") > 58fa2a5512d9 ("mm: memcontrol: add sanity checks for memcg->id.ref on get/put") > > so safe to remove it. > > Signed-off-by: Qian Cai <cai@lca.pw> Acked-by: Michal Hocko <mhocko@suse.com> > --- > mm/memcontrol.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 9ec5e12486a7..9a375b376157 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4675,11 +4675,6 @@ static void mem_cgroup_id_put_many(struct mem_cgroup *memcg, unsigned int n) > } > } > > -static inline void mem_cgroup_id_get(struct mem_cgroup *memcg) > -{ > - mem_cgroup_id_get_many(memcg, 1); > -} > - > static inline void mem_cgroup_id_put(struct mem_cgroup *memcg) > { > mem_cgroup_id_put_many(memcg, 1); > -- > 1.8.3.1
diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 9ec5e12486a7..9a375b376157 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -4675,11 +4675,6 @@ static void mem_cgroup_id_put_many(struct mem_cgroup *memcg, unsigned int n) } } -static inline void mem_cgroup_id_get(struct mem_cgroup *memcg) -{ - mem_cgroup_id_get_many(memcg, 1); -} - static inline void mem_cgroup_id_put(struct mem_cgroup *memcg) { mem_cgroup_id_put_many(memcg, 1);
mem_cgroup_id_get() was introduced in the commit 73f576c04b94 ("mm:memcontrol: fix cgroup creation failure after many small jobs"). Later, it no longer has any user since the commits, 1f47b61fb407 ("mm: memcontrol: fix swap counter leak on swapout from offline cgroup") 58fa2a5512d9 ("mm: memcontrol: add sanity checks for memcg->id.ref on get/put") so safe to remove it. Signed-off-by: Qian Cai <cai@lca.pw> --- mm/memcontrol.c | 5 ----- 1 file changed, 5 deletions(-)