From patchwork Tue Sep 17 09:12:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aurabindo Pillai X-Patchwork-Id: 11148313 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8A7FC13BD for ; Tue, 17 Sep 2019 09:12:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C4832067B for ; Tue, 17 Sep 2019 09:12:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=aurabindo.in header.i=@aurabindo.in header.b="eQjSy21K" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726512AbfIQJMY (ORCPT ); Tue, 17 Sep 2019 05:12:24 -0400 Received: from mail-40132.protonmail.ch ([185.70.40.132]:48377 "EHLO mail-40132.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726292AbfIQJMX (ORCPT ); Tue, 17 Sep 2019 05:12:23 -0400 Date: Tue, 17 Sep 2019 09:12:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aurabindo.in; s=protonmail; t=1568711541; bh=ZKYIzKdgRRtrB7OyOmWDzTMGg6uay9ipjlu1WQonyTU=; h=Date:To:From:Cc:Reply-To:Subject:Feedback-ID:From; b=eQjSy21KM5OSXxxHfL1Q0qHO98l3ynqXu8fnUA4rHJu0AHrC6MQbLJr3PyVby+VLd HftIbwWlow6/FRq+UwbpO4l5ArWqYTCd+B5WEmp/Ozjw7Y/szu+/yOmVBRq/qx4u4A NkAgdHx082bP+SO2K8f2zMj/58ejxv+TrWH7LCa4= To: broonie@kernel.org, palmer@sifive.com, paul.walmsley@sifive.com From: Aurabindo Jayamohanan Cc: linux-spi@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Reply-To: Aurabindo Jayamohanan Subject: [PATCH] spi: sifive: check return value for platform_get_resource() Message-ID: <20190917091207.4925-1-mail@aurabindo.in> Feedback-ID: D1Wwva8zb0UdpJtanaReRLGO3iCsewpGmDn8ZDKmpao-Gnxd2qXPmwwrSQ99r5Q15lmK-D8x6vKzqhUKCgzweA==:Ext:ProtonMail MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.protonmail.ch Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org platform_get_resource() may return NULL. If it is so, return -ENXIO Signed-off-by: Aurabindo Jayamohanan --- drivers/spi/spi-sifive.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/spi/spi-sifive.c b/drivers/spi/spi-sifive.c index 93ec2c6cdbfd..67485067a694 100644 --- a/drivers/spi/spi-sifive.c +++ b/drivers/spi/spi-sifive.c @@ -308,6 +308,12 @@ static int sifive_spi_probe(struct platform_device *pdev) platform_set_drvdata(pdev, master); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + dev_err(&pdev->dev, "no IOMEM resource found\n"); + ret = -ENXIO; + goto put_master; + } + spi->regs = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(spi->regs)) { ret = PTR_ERR(spi->regs);