ASoC: soc-component.h: tidyup for soc-component.h
diff mbox series

Message ID 87h859hrv1.wl-kuninori.morimoto.gx@renesas.com
State New
Headers show
Series
  • ASoC: soc-component.h: tidyup for soc-component.h
Related show

Commit Message

Kuninori Morimoto Sept. 19, 2019, 3:44 a.m. UTC
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

soc-component.h already has SPDX License, GPL explanation
is not needed.
And it is included from soc.h only. No need to header-test.
This patch tidyup these.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
Mark

	this is for for-5.4

 include/Kbuild                | 1 +
 include/sound/soc-component.h | 6 ------
 2 files changed, 1 insertion(+), 6 deletions(-)

Comments

Mark Brown Sept. 19, 2019, 11:15 a.m. UTC | #1
On Thu, Sep 19, 2019 at 12:44:50PM +0900, Kuninori Morimoto wrote:

> And it is included from soc.h only. No need to header-test.

We don't currently ever use this but it's still good practice to try to
make sure that headers can be independently included so it's better to
keep the include, it doens't do any harm at the minute and may help
someone in future.
Kuninori Morimoto Sept. 20, 2019, 12:19 a.m. UTC | #2
Hi Mark

> > And it is included from soc.h only. No need to header-test.
> 
> We don't currently ever use this but it's still good practice to try to
> make sure that headers can be independently included so it's better to
> keep the include, it doens't do any harm at the minute and may help
> someone in future.

Not 100% sure yet, but actually I'm thinking that
current some sound headers are very spaghetti code.
Someday, we want to cleanup it (this was one of for it).

Anyway, OK, let's keep soc.h.
But, the idea of removing GPL comment is still valid ?
Can I post v2 as "remove unneeded GPL comment for SPDX" ?

Thank you for your help !!
Best regards
---
Kuninori Morimoto
Mark Brown Sept. 20, 2019, 11:08 a.m. UTC | #3
On Fri, Sep 20, 2019 at 09:19:05AM +0900, Kuninori Morimoto wrote:

> Not 100% sure yet, but actually I'm thinking that
> current some sound headers are very spaghetti code.
> Someday, we want to cleanup it (this was one of for it).

Part of the reason they're the way they are at the minute is that
someone (IIRC Liam) got part way through splitting a lot of stuff out of
soc.h which was getting very big but didn't quite complete the
transition.

Patch
diff mbox series

diff --git a/include/Kbuild b/include/Kbuild
index c38f0d4..c6909b5 100644
--- a/include/Kbuild
+++ b/include/Kbuild
@@ -1052,6 +1052,7 @@  header-test-			+= sound/soc-acpi-intel-match.h
 header-test-			+= sound/soc-dai.h
 header-test-			+= sound/soc-dapm.h
 header-test-			+= sound/soc-dpcm.h
+header-test-			+= sound/soc-component.h
 header-test-			+= sound/sof/control.h
 header-test-			+= sound/sof/dai-intel.h
 header-test-			+= sound/sof/dai.h
diff --git a/include/sound/soc-component.h b/include/sound/soc-component.h
index 5d80b2e..a869199 100644
--- a/include/sound/soc-component.h
+++ b/include/sound/soc-component.h
@@ -3,16 +3,10 @@ 
  * soc-component.h
  *
  * Copyright (c) 2019 Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
  */
 #ifndef __SOC_COMPONENT_H
 #define __SOC_COMPONENT_H
 
-#include <sound/soc.h>
-
 /*
  * Component probe and remove ordering levels for components with runtime
  * dependencies.