| Message ID | 20190919052822.10403-5-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: rockchip: ROC-PC fixes | expand |
Hi Jagan, Am Donnerstag, 19. September 2019, 07:28:20 CEST schrieb Jagan Teki: > Though the ROC-PC is manufactured by firefly, it is co-designed > by libretch like other Libretech computer boards from allwinner, > amlogic does. > > So, it is always meaningful to keep maintain those vendors who > are part of design participation so-that the linux mainline > code will expose outside world who are the makers of such > hardware prototypes. > > So, rename the existing rk3399-roc-pc.dts with libretch notation, > rk3399-libretech-roc-rk3399-pc.dts > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > arch/arm64/boot/dts/rockchip/Makefile | 2 +- > .../{rk3399-roc-pc.dts => rk3399-libretech-roc-rk3399-pc.dts} | 0 Somewhat "randomly" renaming files for "exposure" of the maker isn't the way to go. Especially as the file name itself is merely a handle and not meant for fame. The board filename should mainly enable developers to hopefully the correct board file to use/change - and "rk3399-roc-pc" is sufficiently unique to do that. Similar to how the NanoPi boards do that. And renames not only loose the history of changes but also in this case the file is in the kernel since july 2018 - more than a year, so this might actually affect the workflow of someone. So I'd really expect an actual technical reason for a rename. Heiko > 2 files changed, 1 insertion(+), 1 deletion(-) > rename arch/arm64/boot/dts/rockchip/{rk3399-roc-pc.dts => rk3399-libretech-roc-rk3399-pc.dts} (100%) > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index 1f18a9392d15..73c10ddb4300 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -21,12 +21,12 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-khadas-edge.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-khadas-edge-captain.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-khadas-edge-v.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-leez-p710.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-libretech-roc-rk3399-pc.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-nanopc-t4.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-nanopi-m4.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-nanopi-neo4.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-orangepi.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-puma-haikou.dtb > -dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-roc-pc.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-pi-4.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock960.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64.dtb > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3399-libretech-roc-rk3399-pc.dts > similarity index 100% > rename from arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts > rename to arch/arm64/boot/dts/rockchip/rk3399-libretech-roc-rk3399-pc.dts >
On Mon, Sep 30, 2019 at 3:02 AM Heiko Stuebner <heiko@sntech.de> wrote: > > Hi Jagan, > > Am Donnerstag, 19. September 2019, 07:28:20 CEST schrieb Jagan Teki: > > Though the ROC-PC is manufactured by firefly, it is co-designed > > by libretch like other Libretech computer boards from allwinner, > > amlogic does. > > > > So, it is always meaningful to keep maintain those vendors who > > are part of design participation so-that the linux mainline > > code will expose outside world who are the makers of such > > hardware prototypes. > > > > So, rename the existing rk3399-roc-pc.dts with libretch notation, > > rk3399-libretech-roc-rk3399-pc.dts > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > arch/arm64/boot/dts/rockchip/Makefile | 2 +- > > .../{rk3399-roc-pc.dts => rk3399-libretech-roc-rk3399-pc.dts} | 0 > > Somewhat "randomly" renaming files for "exposure" of the maker isn't the > way to go. Especially as the file name itself is merely a handle and not > meant for fame. The board filename should mainly enable developers to > hopefully the correct board file to use/change - and "rk3399-roc-pc" > is sufficiently unique to do that. > > Similar to how the NanoPi boards do that. > > And renames not only loose the history of changes but also in this case > the file is in the kernel since july 2018 - more than a year, so this might > actually affect the workflow of someone. Yes, I agreed this point. > > So I'd really expect an actual technical reason for a rename. This changes purely based on the recent changes on naming conventions that have been followed in amlogic and allwinner with regards to libretech [1]. I have seen few Bananapi boards from Allwinner H3 has been converted as per Libretech computer recently. I assume these changes are because libretech has part of co-designed vendor and also open source forum supported for these hardware. For further information, may be Da Xue can comment on this. [1] https://libre.computer/products/boards/
On Tue, Oct 1, 2019 at 6:34 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > On Mon, Sep 30, 2019 at 3:02 AM Heiko Stuebner <heiko@sntech.de> wrote: > > > > Hi Jagan, > > > > Am Donnerstag, 19. September 2019, 07:28:20 CEST schrieb Jagan Teki: > > > Though the ROC-PC is manufactured by firefly, it is co-designed > > > by libretch like other Libretech computer boards from allwinner, > > > amlogic does. > > > > > > So, it is always meaningful to keep maintain those vendors who > > > are part of design participation so-that the linux mainline > > > code will expose outside world who are the makers of such > > > hardware prototypes. > > > > > > So, rename the existing rk3399-roc-pc.dts with libretch notation, > > > rk3399-libretech-roc-rk3399-pc.dts > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > > --- > > > arch/arm64/boot/dts/rockchip/Makefile | 2 +- > > > .../{rk3399-roc-pc.dts => rk3399-libretech-roc-rk3399-pc.dts} | 0 > > > > Somewhat "randomly" renaming files for "exposure" of the maker isn't the > > way to go. Especially as the file name itself is merely a handle and not > > meant for fame. The board filename should mainly enable developers to > > hopefully the correct board file to use/change - and "rk3399-roc-pc" > > is sufficiently unique to do that. > > > > Similar to how the NanoPi boards do that. > > > > And renames not only loose the history of changes but also in this case > > the file is in the kernel since july 2018 - more than a year, so this might > > actually affect the workflow of someone. > > Yes, I agreed this point. > > > > > So I'd really expect an actual technical reason for a rename. > > This changes purely based on the recent changes on naming conventions > that have been followed in amlogic and allwinner with regards to > libretech [1]. I have seen few Bananapi boards from Allwinner H3 has > been converted as per Libretech computer recently. I assume these The DTS file for AML-S905X-CC has never been renamed. The ALL-H3-CC was only reworked to split out the common bits to accommodate the different SoC (H3 vs H5) variants for the same board. Even after the rework, the board DTS files retained their original naming scheme. Same goes for the Bananapi M2+. However we have never renamed Bananapi files to Libretech. Since Libre Computer and Firefly both have the ROC-RK3399-PC, renaming it is likely to cause some confusion. ChenYu > changes are because libretech has part of co-designed vendor and also > open source forum supported for these hardware. > > For further information, may be Da Xue can comment on this. > > [1] https://libre.computer/products/boards/ > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile index 1f18a9392d15..73c10ddb4300 100644 --- a/arch/arm64/boot/dts/rockchip/Makefile +++ b/arch/arm64/boot/dts/rockchip/Makefile @@ -21,12 +21,12 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-khadas-edge.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-khadas-edge-captain.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-khadas-edge-v.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-leez-p710.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-libretech-roc-rk3399-pc.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-nanopc-t4.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-nanopi-m4.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-nanopi-neo4.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-orangepi.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-puma-haikou.dtb -dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-roc-pc.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-pi-4.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock960.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64.dtb diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3399-libretech-roc-rk3399-pc.dts similarity index 100% rename from arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts rename to arch/arm64/boot/dts/rockchip/rk3399-libretech-roc-rk3399-pc.dts
Though the ROC-PC is manufactured by firefly, it is co-designed by libretch like other Libretech computer boards from allwinner, amlogic does. So, it is always meaningful to keep maintain those vendors who are part of design participation so-that the linux mainline code will expose outside world who are the makers of such hardware prototypes. So, rename the existing rk3399-roc-pc.dts with libretch notation, rk3399-libretech-roc-rk3399-pc.dts Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- arch/arm64/boot/dts/rockchip/Makefile | 2 +- .../{rk3399-roc-pc.dts => rk3399-libretech-roc-rk3399-pc.dts} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename arch/arm64/boot/dts/rockchip/{rk3399-roc-pc.dts => rk3399-libretech-roc-rk3399-pc.dts} (100%)