diff mbox series

kernel-shark: Always show the true PID of the entry in the Context menu

Message ID 20190919072230.24945-1-y.karadz@gmail.com (mailing list archive)
State Accepted
Commit b69f563eeaaa44aaecd75d5f17770f6c5d04f455
Headers show
Series kernel-shark: Always show the true PID of the entry in the Context menu | expand

Commit Message

Yordan Karadzhov Sept. 19, 2019, 7:22 a.m. UTC 
All data fields of the kshark_entry object can be modified by plugins
(including the  Process Id). This is usually done in order to modify
the way some events are visualized. However, the Context menu should
always show the true (unmodified) value of the PID.

Reported-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Fixing: 4828dc763 (kernel-shark-qt: Add centralized context menu for View and Graph widgets)
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
 kernel-shark/src/KsQuickContextMenu.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/kernel-shark/src/KsQuickContextMenu.cpp b/kernel-shark/src/KsQuickContextMenu.cpp
index 728ecbd..a84444e 100644
--- a/kernel-shark/src/KsQuickContextMenu.cpp
+++ b/kernel-shark/src/KsQuickContextMenu.cpp
@@ -142,7 +142,7 @@  KsQuickContextMenu::KsQuickContextMenu(KsDataStore *data, size_t row,
 			descr = "Remove [";
 			descr += taskName;
 			descr += "-";
-			descr += QString("%1").arg(_data->rows()[_row]->pid);
+			descr += QString("%1").arg(pid);
 			descr += "] plot";
 			lamAddAction(&_removeTaskPlotAction,
 				     &KsQuickContextMenu::_removeTaskPlot);
@@ -150,7 +150,7 @@  KsQuickContextMenu::KsQuickContextMenu(KsDataStore *data, size_t row,
 			descr = "Add [";
 			descr += taskName;
 			descr += "-";
-			descr += QString("%1").arg(_data->rows()[_row]->pid);
+			descr += QString("%1").arg(pid);
 			descr += "] plot";
 			lamAddAction(&_addTaskPlotAction,
 				     &KsQuickContextMenu::_addTaskPlot);