diff mbox series

[xf86-video-intel,19/21] uxa: Get rid of -Wno-shift-negative-value

Message ID 20190919163113.17402-20-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series Compiler warn elimination | expand

Commit Message

Ville Syrjälä Sept. 19, 2019, 4:31 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The minimum CS URB entry size is 1. Let's use that
instead of 0 so that we don't end up left shifting
a -1.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 src/uxa/i965_render.c | 2 +-
 src/uxa/i965_video.c  | 2 +-
 src/uxa/meson.build   | 1 -
 3 files changed, 2 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/src/uxa/i965_render.c b/src/uxa/i965_render.c
index c1943fb6b5a8..32dbf2f95173 100644
--- a/src/uxa/i965_render.c
+++ b/src/uxa/i965_render.c
@@ -277,7 +277,7 @@  i965_check_composite_texture(ScreenPtr screen, PicturePtr picture)
 /* Set up a default static partitioning of the URB, which is supposed to
  * allow anything we would want to do, at potentially lower performance.
  */
-#define URB_CS_ENTRY_SIZE     0
+#define URB_CS_ENTRY_SIZE     1
 #define URB_CS_ENTRIES	      0
 
 #define URB_VS_ENTRY_SIZE     1	// each 512-bit row
diff --git a/src/uxa/i965_video.c b/src/uxa/i965_video.c
index 9b9203b66f25..fcd5657d9426 100644
--- a/src/uxa/i965_video.c
+++ b/src/uxa/i965_video.c
@@ -378,7 +378,7 @@  static void i965_post_draw_debug(ScrnInfoPtr scrn)
 #define URB_SF_ENTRY_SIZE     2
 
 #define URB_CS_ENTRIES	      0
-#define URB_CS_ENTRY_SIZE     0
+#define URB_CS_ENTRY_SIZE     1
 
 static void i965_create_dst_surface_state(ScrnInfoPtr scrn,
 					PixmapPtr pixmap,
diff --git a/src/uxa/meson.build b/src/uxa/meson.build
index 5f0929ae32a9..f4a3302d3655 100644
--- a/src/uxa/meson.build
+++ b/src/uxa/meson.build
@@ -58,7 +58,6 @@  uxa = static_library('uxa',
 		     include_directories : inc,
 		     c_args : [
 		       '-Wno-deprecated-declarations',
-		       '-Wno-shift-negative-value',
 		       '-Wno-unused-parameter',
 		       '-Wno-sign-compare',
 		     ],