@@ -385,7 +385,6 @@ KsCaptureMonitor::KsCaptureMonitor(QWidget *parent)
: QWidget(parent),
_mergedChannels(false),
_argsModified(false),
- _captureStatus(false),
_panel(this),
_name("Output display", this),
_space("max size ", this),
@@ -523,9 +522,6 @@ void KsCaptureMonitor::_captureFinished(int exit, QProcess::ExitStatus status)
_consolOutput.appendPlainText(errMessage);
QCoreApplication::processEvents();
- _captureStatus = false;
- } else {
- _captureStatus = true;
}
}
@@ -585,6 +581,17 @@ void KsCaptureDialog::_capture()
_captureProc.start();
_captureProc.waitForFinished();
+ /* Reset the _argsModified flag. */
+ _captureMon._argsModified = false;
+
+ if (_captureProc.exitCode() != 0 ||
+ _captureProc.exitStatus() != QProcess::NormalExit)
+ return;
+
+ /*
+ * Capture finished successfully. Open the produced tracing data file
+ * in KernelShark.
+ */
argc = argv.count();
for (int i = 0; i < argc; ++i) {
if (argv[i] == "-o") {
@@ -592,9 +599,6 @@ void KsCaptureDialog::_capture()
break;
}
}
-
- /* Reset the _argsModified flag. */
- _captureMon._argsModified = false;
}
void KsCaptureDialog::_setChannelMode(int state)
@@ -610,9 +614,6 @@ void KsCaptureDialog::_sendOpenReq(const QString &fileName)
{
QLocalSocket *socket;
- if (!_captureMon._captureStatus)
- return;
-
socket = new QLocalSocket(this);
socket->connectToServer("KSCapture", QIODevice::WriteOnly);
if (socket->waitForConnected()) {
@@ -141,8 +141,6 @@ public:
*/
bool _argsModified;
- bool _captureStatus;
-
private:
QVBoxLayout _layout;
My original intend was to fix a Doxygen warning complaining about a data member of a class not being documented. However, when I tried to write explanation for this data member (KsCaptureMonitor::_captureStatus), I realized that it is completely useless and that it actually violates the encapsulation principle, since it holds the return status of the capture process, but the capture process itself is owned by another class (KsCaptureDialog). Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com> --- kernel-shark/src/KsCaptureDialog.cpp | 21 +++++++++++---------- kernel-shark/src/KsCaptureDialog.hpp | 2 -- 2 files changed, 11 insertions(+), 12 deletions(-)