drm/komeda: Fix typos in komeda_splitter_validate
diff mbox series

Message ID 20190920151117.22725-1-mihail.atanassov@arm.com
State New
Headers show
Series
  • drm/komeda: Fix typos in komeda_splitter_validate
Related show

Commit Message

Mihail Atanassov Sept. 20, 2019, 3:11 p.m. UTC
Fix both the string and the struct member being printed.

Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support")
Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
---
 drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

james qian wang (Arm Technology China) Sept. 23, 2019, 2:40 a.m. UTC | #1
Hi Mihail

On Fri, Sep 20, 2019 at 03:11:34PM +0000, Mihail Atanassov wrote:
> Fix both the string and the struct member being printed.
> 
> Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support")
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> index 950235af1e79..de64a6a9964e 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> @@ -564,8 +564,8 @@ komeda_splitter_validate(struct komeda_splitter *splitter,
>  	}
>  
>  	if (!in_range(&splitter->vsize, dflow->in_h)) {
> -		DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n",
> -				 dflow->in_w);
> +		DRM_DEBUG_ATOMIC("split in_h: %d exceed the acceptable range.\n",
> +				 dflow->in_h);


Thank you for the patch.

Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>

>  		return -EINVAL;
>  	}
>  
> -- 
> 2.23.0
Liviu Dudau Sept. 27, 2019, 12:33 p.m. UTC | #2
On Fri, Sep 20, 2019 at 03:11:34PM +0000, Mihail Atanassov wrote:
> Fix both the string and the struct member being printed.
> 
> Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support")
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> index 950235af1e79..de64a6a9964e 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> @@ -564,8 +564,8 @@ komeda_splitter_validate(struct komeda_splitter *splitter,
>  	}
>  
>  	if (!in_range(&splitter->vsize, dflow->in_h)) {
> -		DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n",
> -				 dflow->in_w);
> +		DRM_DEBUG_ATOMIC("split in_h: %d exceed the acceptable range.\n",

Being pedandic: s/exceed/exceeds/.

Best regards,
Liviu

> +				 dflow->in_h);
>  		return -EINVAL;
>  	}
>  
> -- 
> 2.23.0
>

Patch
diff mbox series

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
index 950235af1e79..de64a6a9964e 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
@@ -564,8 +564,8 @@  komeda_splitter_validate(struct komeda_splitter *splitter,
 	}
 
 	if (!in_range(&splitter->vsize, dflow->in_h)) {
-		DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n",
-				 dflow->in_w);
+		DRM_DEBUG_ATOMIC("split in_h: %d exceed the acceptable range.\n",
+				 dflow->in_h);
 		return -EINVAL;
 	}