[V2,2/3] dt-bindings: Add Logic PD Type 28 display panel
diff mbox series

Message ID 20190923134449.22326-2-aford173@gmail.com
State New
Headers show
Series
  • [V2,1/3] drm/panel: simple: Add Logic PD Type 28 display support
Related show

Commit Message

Adam Ford Sept. 23, 2019, 1:44 p.m. UTC
This patch adds documentation of device tree bindings for the WVGA panel
Logic PD Type 28 display.

Signed-off-by: Adam Ford <aford173@gmail.com>
---
V2:  Use YAML instead of TXT for binding

Comments

Rob Herring Sept. 24, 2019, 6:56 p.m. UTC | #1
On Mon, Sep 23, 2019 at 8:45 AM Adam Ford <aford173@gmail.com> wrote:
>
> This patch adds documentation of device tree bindings for the WVGA panel
> Logic PD Type 28 display.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V2:  Use YAML instead of TXT for binding

Fails to build with 'make dt_binding_check':

https://patchwork.ozlabs.org/patch/1166057/

Looks like a tab character used perhaps.

Rob
Adam Ford Sept. 24, 2019, 7 p.m. UTC | #2
On Tue, Sep 24, 2019 at 1:56 PM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Mon, Sep 23, 2019 at 8:45 AM Adam Ford <aford173@gmail.com> wrote:
> >
> > This patch adds documentation of device tree bindings for the WVGA panel
> > Logic PD Type 28 display.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> > ---
> > V2:  Use YAML instead of TXT for binding
>
> Fails to build with 'make dt_binding_check':
>
> https://patchwork.ozlabs.org/patch/1166057/
>
> Looks like a tab character used perhaps.

I am not familiar with yaml.  I thought I copied an existing file but
apparently it didn't work.  Is there a recommended editor that know
this markup language?  Better yet, is there a script I can run to
convert a text file to the yaml?

adam
>
> Rob

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml
new file mode 100644
index 000000000000..707e2a17c8c2
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml
@@ -0,0 +1,39 @@ 
+# SPDX-License-Identifier: (GPL-2.0+ OR X11)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/ronbo,rb070d30.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Logic PD Type 28 4.3" WQVGA TFT LCD panel
+
+properties:
+  compatible:
+    const: logicpd,type28
+
+  power-supply:
+    description: Regulator to provide the supply voltage
+    maxItems: 1
+
+  enable-gpios:
+    description: GPIO pin to enable or disable the panel
+    maxItems: 1
+
+  backlight:
+    description: Backlight used by the panel
+    $ref: "/schemas/types.yaml#/definitions/phandle"
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+	lcd0: display {
+		compatible = "logicpd,type28";
+		enable-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>;
+		port {
+			lcd_in: endpoint {
+				remote-endpoint = <&dpi_out>;
+			};
+		};
+	};