| Message ID | 20190924162924.9914-1-tony@atomide.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: Fix gpio0 flags for am335x-icev2 | expand |
On 24/09/19 9:59 PM, Tony Lindgren wrote: > The ti,no-idle-on-init and ti,no-reset-on-init flags need to be at > the interconnect target module level for the modules that have it > defined. Otherwise we get the following warnings: > > dts flag should be at module level for ti,no-idle-on-init > dts flag should be at module level for ti,no-reset-on-init > > Fixes: 87fc89ced3a7 ("ARM: dts: am335x: Move l4 child devices to probe them with ti-sysc") > Cc: Lokesh Vutla <lokeshvutla@ti.com> > Reported-by: Suman Anna <s-anna@ti.com> > Signed-off-by: Tony Lindgren <tony@atomide.com> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com> Thanks and regards, Lokesh > --- > arch/arm/boot/dts/am335x-icev2.dts | 2 +- > arch/arm/boot/dts/am33xx-l4.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/am335x-icev2.dts b/arch/arm/boot/dts/am335x-icev2.dts > --- a/arch/arm/boot/dts/am335x-icev2.dts > +++ b/arch/arm/boot/dts/am335x-icev2.dts > @@ -432,7 +432,7 @@ > pinctrl-0 = <&mmc0_pins_default>; > }; > > -&gpio0 { > +&gpio0_target { > /* Do not idle the GPIO used for holding the VTT regulator */ > ti,no-reset-on-init; > ti,no-idle-on-init; > diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi > --- a/arch/arm/boot/dts/am33xx-l4.dtsi > +++ b/arch/arm/boot/dts/am33xx-l4.dtsi > @@ -127,7 +127,7 @@ > ranges = <0x0 0x5000 0x1000>; > }; > > - target-module@7000 { /* 0x44e07000, ap 14 20.0 */ > + gpio0_target: target-module@7000 { /* 0x44e07000, ap 14 20.0 */ > compatible = "ti,sysc-omap2", "ti,sysc"; > ti,hwmods = "gpio1"; > reg = <0x7000 0x4>, >
diff --git a/arch/arm/boot/dts/am335x-icev2.dts b/arch/arm/boot/dts/am335x-icev2.dts --- a/arch/arm/boot/dts/am335x-icev2.dts +++ b/arch/arm/boot/dts/am335x-icev2.dts @@ -432,7 +432,7 @@ pinctrl-0 = <&mmc0_pins_default>; }; -&gpio0 { +&gpio0_target { /* Do not idle the GPIO used for holding the VTT regulator */ ti,no-reset-on-init; ti,no-idle-on-init; diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi --- a/arch/arm/boot/dts/am33xx-l4.dtsi +++ b/arch/arm/boot/dts/am33xx-l4.dtsi @@ -127,7 +127,7 @@ ranges = <0x0 0x5000 0x1000>; }; - target-module@7000 { /* 0x44e07000, ap 14 20.0 */ + gpio0_target: target-module@7000 { /* 0x44e07000, ap 14 20.0 */ compatible = "ti,sysc-omap2", "ti,sysc"; ti,hwmods = "gpio1"; reg = <0x7000 0x4>,
The ti,no-idle-on-init and ti,no-reset-on-init flags need to be at the interconnect target module level for the modules that have it defined. Otherwise we get the following warnings: dts flag should be at module level for ti,no-idle-on-init dts flag should be at module level for ti,no-reset-on-init Fixes: 87fc89ced3a7 ("ARM: dts: am335x: Move l4 child devices to probe them with ti-sysc") Cc: Lokesh Vutla <lokeshvutla@ti.com> Reported-by: Suman Anna <s-anna@ti.com> Signed-off-by: Tony Lindgren <tony@atomide.com> --- arch/arm/boot/dts/am335x-icev2.dts | 2 +- arch/arm/boot/dts/am33xx-l4.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)