[rdma-core,v2] srp_daemon: print maximum initiator to target IU size
diff mbox series

Message ID 20190925004200.32401-1-honli@redhat.com
State Accepted
Delegated to: Jason Gunthorpe
Headers show
Series
  • [rdma-core,v2] srp_daemon: print maximum initiator to target IU size
Related show

Commit Message

Honggang LI Sept. 25, 2019, 12:42 a.m. UTC
From: Honggang Li <honli@redhat.com>

The 'Send Message Size' field of IOControllerProfile attributes
contains the maximum initiator to target IU size.

When there is something wrong with SRP login to a third party
SRP target, whose ib_srpt parameters can't be collected with
ordinary method, dump the 'Send Message Size' may help us to
diagnose the problem.

Signed-off-by: Honggang Li <honli@redhat.com>
---
 srp_daemon/srp_daemon.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Bart Van Assche Sept. 25, 2019, 1:23 a.m. UTC | #1
On 2019-09-24 17:42, Honggang LI wrote:
> From: Honggang Li <honli@redhat.com>
> 
> The 'Send Message Size' field of IOControllerProfile attributes
> contains the maximum initiator to target IU size.
> 
> When there is something wrong with SRP login to a third party
> SRP target, whose ib_srpt parameters can't be collected with
> ordinary method, dump the 'Send Message Size' may help us to
> diagnose the problem.
> 
> Signed-off-by: Honggang Li <honli@redhat.com>
> ---
>  srp_daemon/srp_daemon.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/srp_daemon/srp_daemon.c b/srp_daemon/srp_daemon.c
> index 337b21c7..cf046b79 100644
> --- a/srp_daemon/srp_daemon.c
> +++ b/srp_daemon/srp_daemon.c
> @@ -1022,6 +1022,8 @@ static int do_port(struct resources *res, uint16_t pkey, uint16_t dlid,
>  			pr_human("        vendor ID: %06x\n", be32toh(target->ioc_prof.vendor_id) >> 8);
>  			pr_human("        device ID: %06x\n", be32toh(target->ioc_prof.device_id));
>  			pr_human("        IO class : %04hx\n", be16toh(target->ioc_prof.io_class));
> +			pr_human("        Maximum size of Send Messages in bytes: %d\n",
> +				 be32toh(target->ioc_prof.send_size));
>  			pr_human("        ID:        %s\n", target->ioc_prof.id);
>  			pr_human("        service entries: %d\n", target->ioc_prof.service_entries);
>  
> 

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Jason Gunthorpe Oct. 29, 2019, 7:37 p.m. UTC | #2
On Wed, Sep 25, 2019 at 08:42:00AM +0800, Honggang LI wrote:
> From: Honggang Li <honli@redhat.com>
> 
> The 'Send Message Size' field of IOControllerProfile attributes
> contains the maximum initiator to target IU size.
> 
> When there is something wrong with SRP login to a third party
> SRP target, whose ib_srpt parameters can't be collected with
> ordinary method, dump the 'Send Message Size' may help us to
> diagnose the problem.
> 
> Signed-off-by: Honggang Li <honli@redhat.com>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> ---
>  srp_daemon/srp_daemon.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks

Things will go faster if you send rdma-core patches as PRs.. It saves
me a bunch of work :)

Jason

Patch
diff mbox series

diff --git a/srp_daemon/srp_daemon.c b/srp_daemon/srp_daemon.c
index 337b21c7..cf046b79 100644
--- a/srp_daemon/srp_daemon.c
+++ b/srp_daemon/srp_daemon.c
@@ -1022,6 +1022,8 @@  static int do_port(struct resources *res, uint16_t pkey, uint16_t dlid,
 			pr_human("        vendor ID: %06x\n", be32toh(target->ioc_prof.vendor_id) >> 8);
 			pr_human("        device ID: %06x\n", be32toh(target->ioc_prof.device_id));
 			pr_human("        IO class : %04hx\n", be16toh(target->ioc_prof.io_class));
+			pr_human("        Maximum size of Send Messages in bytes: %d\n",
+				 be32toh(target->ioc_prof.send_size));
 			pr_human("        ID:        %s\n", target->ioc_prof.id);
 			pr_human("        service entries: %d\n", target->ioc_prof.service_entries);