[10/13] xfs_scrub: report all progressbar creation failures
diff mbox series

Message ID 156944726395.297677.157416048420551315.stgit@magnolia
State New
Headers show
Series
  • libfrog/xfs_scrub: fix error handling
Related show

Commit Message

Darrick J. Wong Sept. 25, 2019, 9:34 p.m. UTC
From: Darrick J. Wong <darrick.wong@oracle.com>

Always report failures when creating progress bars.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 scrub/progress.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Eric Sandeen Oct. 9, 2019, 9:47 p.m. UTC | #1
On 9/25/19 4:34 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Always report failures when creating progress bars.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  scrub/progress.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> 
> diff --git a/scrub/progress.c b/scrub/progress.c
> index 08c7233e..5fda4ccb 100644
> --- a/scrub/progress.c
> +++ b/scrub/progress.c
> @@ -198,8 +198,10 @@ progress_init_phase(
>  	}
>  
>  	ret = pthread_create(&pt.thread, NULL, progress_report_thread, NULL);
> -	if (ret)
> +	if (ret) {
> +		str_liberror(ctx, ret, _("creating progress reporting thread"));
>  		goto out_ptcounter;
> +	}
>  
>  	return true;
>  
>

Patch
diff mbox series

diff --git a/scrub/progress.c b/scrub/progress.c
index 08c7233e..5fda4ccb 100644
--- a/scrub/progress.c
+++ b/scrub/progress.c
@@ -198,8 +198,10 @@  progress_init_phase(
 	}
 
 	ret = pthread_create(&pt.thread, NULL, progress_report_thread, NULL);
-	if (ret)
+	if (ret) {
+		str_liberror(ctx, ret, _("creating progress reporting thread"));
 		goto out_ptcounter;
+	}
 
 	return true;