ACPI: PM: Revert "ACPI / PM: Blacklist Low Power S0 Idle _DSM for Dell XPS13 9360"
diff mbox series

Message ID 1569514137-2307-1-git-send-email-mario.limonciello@dell.com
State Awaiting Upstream
Delegated to: Rafael Wysocki
Headers show
Series
  • ACPI: PM: Revert "ACPI / PM: Blacklist Low Power S0 Idle _DSM for Dell XPS13 9360"
Related show

Commit Message

Mario Limonciello Sept. 26, 2019, 4:08 p.m. UTC
This reverts part of
commit 71630b7a832f ("ACPI / PM: Blacklist Low Power S0 Idle _DSM for Dell XPS13 9360")
to remove the S0ix blacklist for the XPS 9360.

The problems with this system occurred in one possible NVME SSD when
putting system into s0ix.  As the NVME sleep behavior has been adjusted
in d916b1be this is expected to be now resolved.

Cc: 'Paul Menzel <pmenzel@molgen.mpg.de>'
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=196907
Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
---
The particular failing configuration was reported by only ever failed for Paul Menzel, so hopefully
he can test on his failing system.

 drivers/acpi/sleep.c | 13 -------------
 1 file changed, 13 deletions(-)

Comments

Paul Menzel Oct. 7, 2019, 10:44 p.m. UTC | #1
Dear Mario,


On 26.09.19 18:08, Mario Limonciello wrote:
> This reverts part of
> commit 71630b7a832f ("ACPI / PM: Blacklist Low Power S0 Idle _DSM for Dell XPS13 9360")
> to remove the S0ix blacklist for the XPS 9360.
> 
> The problems with this system occurred in one possible NVME SSD when
> putting system into s0ix.  As the NVME sleep behavior has been adjusted
> in d916b1be this is expected to be now resolved.

1.  Please add, that it was the Hynix(?) SSD.
2.  Please add the commit message summary of d916b1be.

     nvme-pci: use host managed power state for suspend

> Cc: 'Paul Menzel <pmenzel@molgen.mpg.de>'
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=196907
> Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>

Tag it for the stable series? d916b1be (first tag v5.3-rc1) is not 
tagged for stable.

> ---
> The particular failing configuration was reported by only ever failed for Paul Menzel, so hopefully
> he can test on his failing system.

I successfully tested Linux 5.4-rc1+ with this commit last Friday on the 
Dell XPS 13 9360.

Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>

[…]


Kind regards,

Paul
Mario Limonciello Oct. 8, 2019, 1:44 a.m. UTC | #2
> On 26.09.19 18:08, Mario Limonciello wrote:
> > This reverts part of
> > commit 71630b7a832f ("ACPI / PM: Blacklist Low Power S0 Idle _DSM for
> > Dell XPS13 9360") to remove the S0ix blacklist for the XPS 9360.
> >
> > The problems with this system occurred in one possible NVME SSD when
> > putting system into s0ix.  As the NVME sleep behavior has been
> > adjusted in d916b1be this is expected to be now resolved.
> 
> 1.  Please add, that it was the Hynix(?) SSD.
> 2.  Please add the commit message summary of d916b1be.
> 
>      nvme-pci: use host managed power state for suspend
> 

Rafael, let me know if you want me to adjust the commit message and resubmit
or if you would just handle this task.

> > Cc: 'Paul Menzel <pmenzel@molgen.mpg.de>'
> > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=196907
> > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> 
> Tag it for the stable series? d916b1be (first tag v5.3-rc1) is not tagged for stable.
> 

Although Dell arranged a lot of testing with partners I don't feel d916b1be is a stable
candidate.  Rafael found a corner case with regards to ASPM configuration last minute
in 5.3rcX, I found a another corner case related to order of events and timing around
PC10 entry that's getting fixed in 5.4.

> > ---
> > The particular failing configuration was reported by only ever failed
> > for Paul Menzel, so hopefully he can test on his failing system.
> 
> I successfully tested Linux 5.4-rc1+ with this commit last Friday on the Dell XPS
> 13 9360.
> 
> Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>
> 

Well that's great, appreciate your testing and confirmation.
Rafael J. Wysocki Oct. 10, 2019, 8:51 a.m. UTC | #3
On Tue, Oct 8, 2019 at 3:44 AM <Mario.Limonciello@dell.com> wrote:
>
> > On 26.09.19 18:08, Mario Limonciello wrote:
> > > This reverts part of
> > > commit 71630b7a832f ("ACPI / PM: Blacklist Low Power S0 Idle _DSM for
> > > Dell XPS13 9360") to remove the S0ix blacklist for the XPS 9360.
> > >
> > > The problems with this system occurred in one possible NVME SSD when
> > > putting system into s0ix.  As the NVME sleep behavior has been
> > > adjusted in d916b1be this is expected to be now resolved.
> >
> > 1.  Please add, that it was the Hynix(?) SSD.
> > 2.  Please add the commit message summary of d916b1be.
> >
> >      nvme-pci: use host managed power state for suspend
> >
>
> Rafael, let me know if you want me to adjust the commit message and resubmit
> or if you would just handle this task.
>
> > > Cc: 'Paul Menzel <pmenzel@molgen.mpg.de>'
> > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=196907
> > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> >
> > Tag it for the stable series? d916b1be (first tag v5.3-rc1) is not tagged for stable.
> >
>
> Although Dell arranged a lot of testing with partners I don't feel d916b1be is a stable
> candidate.  Rafael found a corner case with regards to ASPM configuration last minute
> in 5.3rcX, I found a another corner case related to order of events and timing around
> PC10 entry that's getting fixed in 5.4.
>
> > > ---
> > > The particular failing configuration was reported by only ever failed
> > > for Paul Menzel, so hopefully he can test on his failing system.
> >
> > I successfully tested Linux 5.4-rc1+ with this commit last Friday on the Dell XPS
> > 13 9360.
> >
> > Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>
> >
>
> Well that's great, appreciate your testing and confirmation.

Applying, thanks!

Patch
diff mbox series

diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
index 9fa77d7..2af937a 100644
--- a/drivers/acpi/sleep.c
+++ b/drivers/acpi/sleep.c
@@ -362,19 +362,6 @@  static const struct dmi_system_id acpisleep_dmi_table[] __initconst = {
 		},
 	},
 	/*
-	 * https://bugzilla.kernel.org/show_bug.cgi?id=196907
-	 * Some Dell XPS13 9360 cannot do suspend-to-idle using the Low Power
-	 * S0 Idle firmware interface.
-	 */
-	{
-	.callback = init_default_s3,
-	.ident = "Dell XPS13 9360",
-	.matches = {
-		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
-		DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),
-		},
-	},
-	/*
 	 * ThinkPad X1 Tablet(2016) cannot do suspend-to-idle using
 	 * the Low Power S0 Idle firmware interface (see
 	 * https://bugzilla.kernel.org/show_bug.cgi?id=199057).