From patchwork Fri Sep 27 03:50:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "(Exiting) Baolin Wang" X-Patchwork-Id: 11163713 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 097FD17D4 for ; Fri, 27 Sep 2019 03:51:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA8CC214D9 for ; Fri, 27 Sep 2019 03:51:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EFd+uioU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727505AbfI0DvR (ORCPT ); Thu, 26 Sep 2019 23:51:17 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:38155 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728464AbfI0DvR (ORCPT ); Thu, 26 Sep 2019 23:51:17 -0400 Received: by mail-pl1-f193.google.com with SMTP id w8so52888plq.5 for ; Thu, 26 Sep 2019 20:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=V9DS/QOwqeJEc++1RGa0/GFPq1bWylLG/sK8PIeSOjM=; b=EFd+uioUEzXYPg/htXgdnnNhmWIF6tsNx2mGdy29mHoJwPkK6SpCy4sMbYc1lcsoha yuA0KRB9ZGpDS79Stj6fUwL39iEAXtDcxHCztSXrK0dKUTZgY72fIy0B3HUUu43XkY+I J1a7FG+2DHFRSzWZ/y8nwusy1Pz1vY4rKUa8uuX73GENBBPGPv1zrhnLgnVfkzi4bcL5 z5OdMy2QOlPRVIWMDM+Gf8ZKDpXAKVj6I+HVXLp6yibpCu3dgVr07X/RgJ34l0+oG5fM kL6gTCTINPcsWvayxAbydV97Olw22mGY4ClTx4JSrqPRAUMlxMP8aCTb4wX8jW38TMit Uj6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=V9DS/QOwqeJEc++1RGa0/GFPq1bWylLG/sK8PIeSOjM=; b=OOclSMl9dRQi/LPWSDS25Qn+nbLkXReaBZ/xNLx1TRgv4676uY3ZyOzhxB5tmgZI54 lTbJrNk2JCW6ToRg7sRzIaRuD8rdCPuz1JP94ihMmMSMq9f1E0ACTi88BWB9rtW6wAVJ QNKZnZcE9nIQ9aBNeB+h0biWa4gIo62NOAk3bn/TjuO45M7FeeiGuiFbpDEcFiT0tQgm QStYyHTU6fg1KpRzYJYRAOGzsNY20n43c8nQCVG8UMpQ5djtdi6YkNI0EhWQvC3M6Gkz bKgY4fKgkAckhwaRNHHbURkCDtEmLggFbnb3rQC5vOXp3bSYe+KT6l/qYu4Xy7GBppHW 5D/Q== X-Gm-Message-State: APjAAAXapCP8wl2UJyc+/N1+62njvoC1/L48SuET2JYhZNRgxhDXFjRh qOcJ18ESLPyeswscbVt1zCnGgg== X-Google-Smtp-Source: APXvYqzNTK6RbAVCanSAplvzHuRnqO4cljDQPwRdB1e36UzREEZiifwl0eCjvwxvg7s6wj91v/1Hew== X-Received: by 2002:a17:902:b902:: with SMTP id bf2mr2370343plb.56.1569556275985; Thu, 26 Sep 2019 20:51:15 -0700 (PDT) Received: from baolinwangubtpc.spreadtrum.com ([117.18.48.82]) by smtp.gmail.com with ESMTPSA id n66sm753640pfn.90.2019.09.26.20.51.12 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 26 Sep 2019 20:51:15 -0700 (PDT) From: Baolin Wang To: mturquette@baylibre.com, sboyd@kernel.org Cc: orsonzhai@gmail.com, baolin.wang@linaro.org, zhang.lyra@gmail.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle() Date: Fri, 27 Sep 2019 11:50:53 +0800 Message-Id: X-Mailer: git-send-email 1.7.9.5 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org The syscon_regmap_lookup_by_phandle() will never return NULL, thus use IS_ERR() to validate the return value instead of IS_ERR_OR_NULL(). Signed-off-by: Baolin Wang --- drivers/clk/sprd/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c index 9d56eac..7ad5ba2 100644 --- a/drivers/clk/sprd/common.c +++ b/drivers/clk/sprd/common.c @@ -46,7 +46,7 @@ int sprd_clk_regmap_init(struct platform_device *pdev, if (of_find_property(node, "sprd,syscon", NULL)) { regmap = syscon_regmap_lookup_by_phandle(node, "sprd,syscon"); - if (IS_ERR_OR_NULL(regmap)) { + if (IS_ERR(regmap)) { pr_err("%s: failed to get syscon regmap\n", __func__); return PTR_ERR(regmap); }