| Message ID | 20190927060448.7056-1-jgross@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xen/debugtrace: fix buffer allocation | expand |
On 27.09.2019 08:04, Juergen Gross wrote: > Commit 6338c9ead9ff9ef6 ("debugtrace: add per-cpu buffer option") had > a rebase error when using per-cpu buffers: the global buffer address > would always be set to the one of the last per-cpu buffer allocated. > > The result would be that when dumping the buffers the last cpu's buffer > is always shown as empty as those entries are printed in the global > buffer's dump already. > > Fix that. > > Signed-off-by: Juergen Gross <jgross@suse.com> Reviewed-by: Jan Beulich <jbeulich@suse.com>
diff --git a/xen/common/debugtrace.c b/xen/common/debugtrace.c index 7313e89389..a788e55b4c 100644 --- a/xen/common/debugtrace.c +++ b/xen/common/debugtrace.c @@ -259,7 +259,6 @@ static void debugtrace_alloc_buffer(struct debugtrace_data **ptr, memset(data, '\0', debugtrace_bytes + sizeof(*data)); - dt_data = data; *ptr = data; }
Commit 6338c9ead9ff9ef6 ("debugtrace: add per-cpu buffer option") had a rebase error when using per-cpu buffers: the global buffer address would always be set to the one of the last per-cpu buffer allocated. The result would be that when dumping the buffers the last cpu's buffer is always shown as empty as those entries are printed in the global buffer's dump already. Fix that. Signed-off-by: Juergen Gross <jgross@suse.com> --- xen/common/debugtrace.c | 1 - 1 file changed, 1 deletion(-)