| Message ID | 20190928190334.6897-1-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | configure: Remove s390 (31-bit mode) from the list of supported CPUs | expand |
On 28.09.19 21:03, Thomas Huth wrote: > On IBM Z, KVM in the kernel is only implemented for 64-bit mode, and > with regards to TCG, we also only support 64-bit host CPUs (see the > check at the beginning of tcg/s390/tcg-target.inc.c), so we should > remove s390 (without "x", i.e. the old 31-bit mode CPUs) from the > list of supported CPUs. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 397bb476e1..a4488c6705 100755 > --- a/configure > +++ b/configure > @@ -728,7 +728,7 @@ ARCH= > # Normalise host CPU name and set ARCH. > # Note that this case should only have supported host CPUs, not guests. > case "$cpu" in > - ppc|ppc64|s390|s390x|sparc64|x32|riscv32|riscv64) > + ppc|ppc64|s390x|sparc64|x32|riscv32|riscv64) > supported_cpu="yes" > ;; > ppc64le) > Not sure if that ever worked Reviewed-by: David Hildenbrand <david@redhat.com>
On 30/09/2019 09.51, David Hildenbrand wrote: > On 28.09.19 21:03, Thomas Huth wrote: >> On IBM Z, KVM in the kernel is only implemented for 64-bit mode, and >> with regards to TCG, we also only support 64-bit host CPUs (see the >> check at the beginning of tcg/s390/tcg-target.inc.c), so we should >> remove s390 (without "x", i.e. the old 31-bit mode CPUs) from the >> list of supported CPUs. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> >> --- >> configure | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configure b/configure >> index 397bb476e1..a4488c6705 100755 >> --- a/configure >> +++ b/configure >> @@ -728,7 +728,7 @@ ARCH= >> # Normalise host CPU name and set ARCH. >> # Note that this case should only have supported host CPUs, not guests. >> case "$cpu" in >> - ppc|ppc64|s390|s390x|sparc64|x32|riscv32|riscv64) >> + ppc|ppc64|s390x|sparc64|x32|riscv32|riscv64) >> supported_cpu="yes" >> ;; >> ppc64le) >> > > Not sure if that ever worked I think it likely worked with dyngen (the predecessor of TCG), see commit fb3e5849bb1 ... but I think it's broken since QEMU switched from dyngen to TCG. Thomas
Thomas Huth <thuth@redhat.com> writes: > On IBM Z, KVM in the kernel is only implemented for 64-bit mode, and > with regards to TCG, we also only support 64-bit host CPUs (see the > check at the beginning of tcg/s390/tcg-target.inc.c), so we should > remove s390 (without "x", i.e. the old 31-bit mode CPUs) from the > list of supported CPUs. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 397bb476e1..a4488c6705 100755 > --- a/configure > +++ b/configure > @@ -728,7 +728,7 @@ ARCH= > # Normalise host CPU name and set ARCH. > # Note that this case should only have supported host CPUs, not guests. > case "$cpu" in > - ppc|ppc64|s390|s390x|sparc64|x32|riscv32|riscv64) > + ppc|ppc64|s390x|sparc64|x32|riscv32|riscv64) > supported_cpu="yes" > ;; > ppc64le) -- Alex Bennée
On 28.09.19 21:03, Thomas Huth wrote: > On IBM Z, KVM in the kernel is only implemented for 64-bit mode, and > with regards to TCG, we also only support 64-bit host CPUs (see the > check at the beginning of tcg/s390/tcg-target.inc.c), so we should > remove s390 (without "x", i.e. the old 31-bit mode CPUs) from the > list of supported CPUs. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 397bb476e1..a4488c6705 100755 > --- a/configure > +++ b/configure > @@ -728,7 +728,7 @@ ARCH= > # Normalise host CPU name and set ARCH. > # Note that this case should only have supported host CPUs, not guests. > case "$cpu" in > - ppc|ppc64|s390|s390x|sparc64|x32|riscv32|riscv64) > + ppc|ppc64|s390x|sparc64|x32|riscv32|riscv64) > supported_cpu="yes" > ;; > ppc64le) > Thanks applied to s390-next.
diff --git a/configure b/configure index 397bb476e1..a4488c6705 100755 --- a/configure +++ b/configure @@ -728,7 +728,7 @@ ARCH= # Normalise host CPU name and set ARCH. # Note that this case should only have supported host CPUs, not guests. case "$cpu" in - ppc|ppc64|s390|s390x|sparc64|x32|riscv32|riscv64) + ppc|ppc64|s390x|sparc64|x32|riscv32|riscv64) supported_cpu="yes" ;; ppc64le)
On IBM Z, KVM in the kernel is only implemented for 64-bit mode, and with regards to TCG, we also only support 64-bit host CPUs (see the check at the beginning of tcg/s390/tcg-target.inc.c), so we should remove s390 (without "x", i.e. the old 31-bit mode CPUs) from the list of supported CPUs. Signed-off-by: Thomas Huth <thuth@redhat.com> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)