arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box
diff mbox series

Message ID 20190929032230.24628-1-npcomplete13@gmail.com
State New
Headers show
Series
  • arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box
Related show

Commit Message

Vivek Unune Sept. 29, 2019, 3:22 a.m. UTC
Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3

Signed-off-by: Vivek Unune <npcomplete13@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Vicente Bergas Sept. 29, 2019, 11:22 a.m. UTC | #1
On Sunday, September 29, 2019 5:22:30 AM CEST, Vivek Unune wrote:
> Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
>
> Signed-off-by: Vivek Unune <npcomplete13@gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts 
> b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> index 0d1f5f9a0de9..c133e8d64b2a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> @@ -644,7 +644,7 @@
>  	status = "okay";
>  
>  	u2phy0_host: host-port {
> -		phy-supply = <&vcc5v0_host>;
> +		phy-supply = <&vcc5v0_typec>;
>  		status = "okay";
>  	};
>  
> @@ -712,7 +712,7 @@
>  
>  &usbdrd_dwc3_0 {
>  	status = "okay";
> -	dr_mode = "otg";
> +	dr_mode = "host";
>  };
>  
>  &usbdrd3_1 {

Hi Vivek,

which is the relationship of your patch and this commit:

e1d9149e8389f1690cdd4e4056766dd26488a0fe
arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire

with respect to this other commit:

c09b73cfac2a9317f1104169045c519c6021aa1d
usb: dwc3: don't set gadget->is_otg flag

?

I did not test reverting e1d9149e since c09b73cf was applied.

Regards,
  Vicenç.
Vivek Unune Sept. 29, 2019, 11:46 p.m. UTC | #2
On Sun, Sep 29, 2019 at 01:22:17PM +0200, Vicente Bergas wrote:
> On Sunday, September 29, 2019 5:22:30 AM CEST, Vivek Unune wrote:
> > Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
> > 
> > Signed-off-by: Vivek Unune <npcomplete13@gmail.com>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > index 0d1f5f9a0de9..c133e8d64b2a 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > @@ -644,7 +644,7 @@
> >  	status = "okay";
> >  	u2phy0_host: host-port {
> > -		phy-supply = <&vcc5v0_host>;
> > +		phy-supply = <&vcc5v0_typec>;
> >  		status = "okay";
> >  	};
> > @@ -712,7 +712,7 @@
> >  &usbdrd_dwc3_0 {
> >  	status = "okay";
> > -	dr_mode = "otg";
> > +	dr_mode = "host";
> >  };
> >  &usbdrd3_1 {
> 
> Hi Vivek,
> 
> which is the relationship of your patch and this commit:
> 
> e1d9149e8389f1690cdd4e4056766dd26488a0fe
> arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire
> 
> with respect to this other commit:
> 
> c09b73cfac2a9317f1104169045c519c6021aa1d
> usb: dwc3: don't set gadget->is_otg flag
> 
> ?
> 
> I did not test reverting e1d9149e since c09b73cf was applied.
> 
> Regards,
>  Vicenç.
> 

Hi Vicenç,

Indeed, I was motivated by e1d9149e ("arm64: dts: rockchip: Fix USB3 
Type-C on rk3399-sapphire"). X99 TV box showed exact same symptoms
with usb-c port. After applying the fix, it worked.

I was not aware of c09b73cf ("usb: dwc3: don't set gadget->is_otg
 flag") and it will be interesting to test it. This might render
my fix unecessary.

Thanks,

Vivek
Heiko Stübner Oct. 4, 2019, 9:45 p.m. UTC | #3
Hi Vivek,

Am Montag, 30. September 2019, 01:46:15 CEST schrieb Vivek Unune:
> On Sun, Sep 29, 2019 at 01:22:17PM +0200, Vicente Bergas wrote:
> > On Sunday, September 29, 2019 5:22:30 AM CEST, Vivek Unune wrote:
> > > Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
> > > 
> > > Signed-off-by: Vivek Unune <npcomplete13@gmail.com>
> > > ---
> > >  arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > index 0d1f5f9a0de9..c133e8d64b2a 100644
> > > --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > @@ -644,7 +644,7 @@
> > >  	status = "okay";
> > >  	u2phy0_host: host-port {
> > > -		phy-supply = <&vcc5v0_host>;
> > > +		phy-supply = <&vcc5v0_typec>;
> > >  		status = "okay";
> > >  	};
> > > @@ -712,7 +712,7 @@
> > >  &usbdrd_dwc3_0 {
> > >  	status = "okay";
> > > -	dr_mode = "otg";
> > > +	dr_mode = "host";
> > >  };
> > >  &usbdrd3_1 {
> > 
> > Hi Vivek,
> > 
> > which is the relationship of your patch and this commit:
> > 
> > e1d9149e8389f1690cdd4e4056766dd26488a0fe
> > arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire
> > 
> > with respect to this other commit:
> > 
> > c09b73cfac2a9317f1104169045c519c6021aa1d
> > usb: dwc3: don't set gadget->is_otg flag
> > 
> > ?
> > 
> > I did not test reverting e1d9149e since c09b73cf was applied.
> > 
> > Regards,
> >  Vicenç.
> > 
> 
> Hi Vicenç,
> 
> Indeed, I was motivated by e1d9149e ("arm64: dts: rockchip: Fix USB3 
> Type-C on rk3399-sapphire"). X99 TV box showed exact same symptoms
> with usb-c port. After applying the fix, it worked.
> 
> I was not aware of c09b73cf ("usb: dwc3: don't set gadget->is_otg
>  flag") and it will be interesting to test it. This might render
> my fix unecessary.

So I'll let this patch sit here for now.
Once you've done the testing, can you please respond with the
result (both positive and negative results please).

Thanks
Heiko
Vivek Unune Oct. 5, 2019, 12:52 a.m. UTC | #4
On Fri, Oct 04, 2019 at 11:45:08PM +0200, Heiko Stuebner wrote:
> Hi Vivek,
> 
> Am Montag, 30. September 2019, 01:46:15 CEST schrieb Vivek Unune:
> > On Sun, Sep 29, 2019 at 01:22:17PM +0200, Vicente Bergas wrote:
> > > On Sunday, September 29, 2019 5:22:30 AM CEST, Vivek Unune wrote:
> > > > Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
> > > > 
> > > > Signed-off-by: Vivek Unune <npcomplete13@gmail.com>
> > > > ---
> > > >  arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > > b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > > index 0d1f5f9a0de9..c133e8d64b2a 100644
> > > > --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > > @@ -644,7 +644,7 @@
> > > >  	status = "okay";
> > > >  	u2phy0_host: host-port {
> > > > -		phy-supply = <&vcc5v0_host>;
> > > > +		phy-supply = <&vcc5v0_typec>;
> > > >  		status = "okay";
> > > >  	};
> > > > @@ -712,7 +712,7 @@
> > > >  &usbdrd_dwc3_0 {
> > > >  	status = "okay";
> > > > -	dr_mode = "otg";
> > > > +	dr_mode = "host";
> > > >  };
> > > >  &usbdrd3_1 {
> > > 
> > > Hi Vivek,
> > > 
> > > which is the relationship of your patch and this commit:
> > > 
> > > e1d9149e8389f1690cdd4e4056766dd26488a0fe
> > > arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire
> > > 
> > > with respect to this other commit:
> > > 
> > > c09b73cfac2a9317f1104169045c519c6021aa1d
> > > usb: dwc3: don't set gadget->is_otg flag
> > > 
> > > ?
> > > 
> > > I did not test reverting e1d9149e since c09b73cf was applied.
> > > 
> > > Regards,
> > >  Vicenç.
> > > 
> > 
> > Hi Vicenç,
> > 
> > Indeed, I was motivated by e1d9149e ("arm64: dts: rockchip: Fix USB3 
> > Type-C on rk3399-sapphire"). X99 TV box showed exact same symptoms
> > with usb-c port. After applying the fix, it worked.
> > 
> > I was not aware of c09b73cf ("usb: dwc3: don't set gadget->is_otg
> >  flag") and it will be interesting to test it. This might render
> > my fix unecessary.
> 
> So I'll let this patch sit here for now.
> Once you've done the testing, can you please respond with the
> result (both positive and negative results please).
> 
> Thanks
> Heiko
> 
> 

Hi Heiko,

I tested the c09b73cf patch without modifying exsisting dts. I can confirm
that that patch doesn't work for me. No usb-c devices were recognized.

Vicenç - were you able to test it?

As soon as I apply dts patch, usb-c devices are recognized.

Thanks,

Vivek
Vicente Bergas Oct. 6, 2019, 7:50 p.m. UTC | #5
On Saturday, October 5, 2019 2:52:00 AM CEST, Vivek Unune wrote:
> On Fri, Oct 04, 2019 at 11:45:08PM +0200, Heiko Stuebner wrote:
>> Hi Vivek,
>> 
>> Am Montag, 30. September 2019, 01:46:15 CEST schrieb Vivek Unune: ...
>
> Hi Heiko,
>
> I tested the c09b73cf patch without modifying exsisting dts. I can confirm
> that that patch doesn't work for me. No usb-c devices were recognized.
>
> Vicenç - were you able to test it?

I can also confirm that

c09b73cfac2a9317f1104169045c519c6021aa1d
usb: dwc3: don't set gadget->is_otg flag

alone does not fix the issue.

e1d9149e8389f1690cdd4e4056766dd26488a0fe
arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire

is still required for the USB-C to work on the Sapphire board.

Regards,
  Vicenç.

> As soon as I apply dts patch, usb-c devices are recognized.
>
> Thanks,
>
> Vivek
Heiko Stübner Oct. 10, 2019, 9:30 p.m. UTC | #6
Am Sonntag, 29. September 2019, 05:22:30 CEST schrieb Vivek Unune:
> Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
> 
> Signed-off-by: Vivek Unune <npcomplete13@gmail.com>

applied as fix for 5.4

Thanks
Heiko

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
index 0d1f5f9a0de9..c133e8d64b2a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
@@ -644,7 +644,7 @@ 
 	status = "okay";
 
 	u2phy0_host: host-port {
-		phy-supply = <&vcc5v0_host>;
+		phy-supply = <&vcc5v0_typec>;
 		status = "okay";
 	};
 
@@ -712,7 +712,7 @@ 
 
 &usbdrd_dwc3_0 {
 	status = "okay";
-	dr_mode = "otg";
+	dr_mode = "host";
 };
 
 &usbdrd3_1 {