| Message ID | 20190930122231.33029-1-mihail.atanassov@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/komeda: Fix typos in komeda_splitter_validate | expand |
On Mon, Sep 30, 2019 at 12:23:07PM +0000, Mihail Atanassov wrote: > Fix both the string and the struct member being printed. > > Changes since v1: > - Now with a bonus grammar fix, too. > > Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support") > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> > --- > drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c > index 950235af1e79..2b624bfe1751 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c > @@ -564,8 +564,8 @@ komeda_splitter_validate(struct komeda_splitter *splitter, > } > > if (!in_range(&splitter->vsize, dflow->in_h)) { > - DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n", > - dflow->in_w); > + DRM_DEBUG_ATOMIC("split in_h: %d exceeds the acceptable range.\n", > + dflow->in_h); Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com> > return -EINVAL; > } >
On Wednesday, 16 October 2019 09:23:03 BST james qian wang (Arm Technology China) wrote: > On Mon, Sep 30, 2019 at 12:23:07PM +0000, Mihail Atanassov wrote: > > Fix both the string and the struct member being printed. > > > > Changes since v1: > > - Now with a bonus grammar fix, too. > > > > Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support") > > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> > > --- > > drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c > > index 950235af1e79..2b624bfe1751 100644 > > --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c > > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c > > @@ -564,8 +564,8 @@ komeda_splitter_validate(struct komeda_splitter *splitter, > > } > > > > if (!in_range(&splitter->vsize, dflow->in_h)) { > > - DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n", > > - dflow->in_w); > > + DRM_DEBUG_ATOMIC("split in_h: %d exceeds the acceptable range.\n", > > + dflow->in_h); > > Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com> Thanks for the review, applied to drm-misc-fixes - 8ae501e295cce9bc6e0dd82d5204a1d5faef44f8. > > return -EINVAL; > > } > > >
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c index 950235af1e79..2b624bfe1751 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c @@ -564,8 +564,8 @@ komeda_splitter_validate(struct komeda_splitter *splitter, } if (!in_range(&splitter->vsize, dflow->in_h)) { - DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n", - dflow->in_w); + DRM_DEBUG_ATOMIC("split in_h: %d exceeds the acceptable range.\n", + dflow->in_h); return -EINVAL; }
Fix both the string and the struct member being printed. Changes since v1: - Now with a bonus grammar fix, too. Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support") Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> --- drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)