x86/Kconfig: Invert the defaults for CONFIG_{PVH_GUEST, PV_SHIM}
diff mbox series

Message ID 20191001163237.17361-1-andrew.cooper3@citrix.com
State New
Headers show
Series
  • x86/Kconfig: Invert the defaults for CONFIG_{PVH_GUEST, PV_SHIM}
Related show

Commit Message

Andrew Cooper Oct. 1, 2019, 4:32 p.m. UTC
This is a minor UI change, but users which have elected to enable
XEN_GUEST (which still defaults to no) will definitely need one of these
options, and will typically want both.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wl@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Juergen Gross <jgross@suse.com>

RFC For-4.13 - Minor usibility tweak.
---
 xen/arch/x86/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Wei Liu Oct. 1, 2019, 4:41 p.m. UTC | #1
On Tue, Oct 01, 2019 at 05:32:37PM +0100, Andrew Cooper wrote:
> This is a minor UI change, but users which have elected to enable
> XEN_GUEST (which still defaults to no) will definitely need one of these
> options, and will typically want both.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Makes sense. 

Acked-by: Wei Liu <wl@xen.org>
Jan Beulich Oct. 2, 2019, 8:43 a.m. UTC | #2
On 01.10.2019 18:32, Andrew Cooper wrote:
> This is a minor UI change, but users which have elected to enable
> XEN_GUEST (which still defaults to no) will definitely need one of these
> options, and will typically want both.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>
Jürgen Groß Oct. 2, 2019, 8:44 a.m. UTC | #3
On 01.10.19 18:32, Andrew Cooper wrote:
> This is a minor UI change, but users which have elected to enable
> XEN_GUEST (which still defaults to no) will definitely need one of these
> options, and will typically want both.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Wei Liu <wl@xen.org>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Juergen Gross <jgross@suse.com>
> 
> RFC For-4.13 - Minor usibility tweak.

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen

Patch
diff mbox series

diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index 288dc6c042..f85f5e8627 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -169,16 +169,16 @@  config XEN_GUEST
 	  If unsure, say N.
 
 config PVH_GUEST
-	def_bool n
+	def_bool y
 	prompt "PVH Guest"
 	depends on XEN_GUEST
 	---help---
 	  Support booting using the PVH ABI.
 
-	  If unsure, say N.
+	  If unsure, say Y.
 
 config PV_SHIM
-	def_bool n
+	def_bool y
 	prompt "PV Shim"
 	depends on PV && XEN_GUEST
 	---help---
@@ -186,7 +186,7 @@  config PV_SHIM
 	  in an HVM/PVH container. This mode can only be enabled with command
 	  line option.
 
-	  If unsure, say N.
+	  If unsure, say Y.
 
 config PV_SHIM_EXCLUSIVE
 	def_bool n