| Message ID | 1570035113-56848-1-git-send-email-pbonzini@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/1570035113-56848-1-git-send-email-pbonzini@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1570035113-56848-1-git-send-email-pbonzini@redhat.com
Subject: [PULL 00/30] Misc patches for 2010-10-02
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
ece968f accel/kvm: ensure ret always set
f809af7 tests/docker: only enable ubsan for test-clang
42bb4d8 win32: work around main-loop busy loop on socket/fd event
6dc6f67 tests: skip serial test on windows
81d8378 util: WSAEWOULDBLOCK on connect should map to EINPROGRESS
68a8749 Fix wrong behavior of cpu_memory_rw_debug() function in SMM
ba6a8cb memory: allow memory_region_register_iommu_notifier() to fail
31fb63b vfio: Turn the container error into an Error handle
9cb898e i386: Add CPUID bit for CLZERO and XSAVEERPTR
223539f docker: test-debug: disable LeakSanitizer
ddc831e lm32: do not leak memory on object_new/object_unref
7e7f903 cris: do not leak struct cris_disasm_data
71ddec4 mips: fix memory leaks in board initialization
0a4aae1 hppa: fix leak from g_strdup_printf
1681302 mcf5208: fix leak from qemu_allocate_irqs
975e236 microblaze: fix leak of fdevice tree blob
3b04059 ide: fix leak from qemu_allocate_irqs
ef7140c hw/isa: Introduce a CONFIG_ISA_SUPERIO switch for isa-superio.c
22144ad Makefile: Remove generated files when doing 'distclean'
b2315db replay: don't synchronize memory operations in replay mode
a8748fb qemu-pr-helper: fix crash in mpath_reconstruct_sense
62af60b target/i386/kvm: Silence warning from Valgrind about uninitialized bytes
354aebb target/i386: work around KVM_GET_MSRS bug for secondary execution controls
6dec780 target/i386: add VMX features
0aabf14 vmxcap: correct the name of the variables
79691b9 target/i386: add VMX definitions
31a4f80 target/i386: expand feature words to 64 bits
107c503 target/i386: introduce generic feature dependency mechanism
2444ee0 target/i386: handle filtered_features in a new function mark_unavailable_features
ebcabe7 tests/migration: Add a test for auto converge
=== OUTPUT BEGIN ===
1/30 Checking commit ebcabe7df2b9 (tests/migration: Add a test for auto converge)
2/30 Checking commit 2444ee0a386b (target/i386: handle filtered_features in a new function mark_unavailable_features)
ERROR: suspect code indent for conditional statements (4, 9)
#27: FILE: target/i386/cpu.c:3103:
+ for (w = 0; w < FEATURE_WORDS; w++) {
+ if (cpu->filtered_features[w]) {
ERROR: suspect code indent for conditional statements (9, 13)
#28: FILE: target/i386/cpu.c:3104:
+ if (cpu->filtered_features[w]) {
+ return true;
WARNING: line over 80 characters
#139: FILE: target/i386/cpu.c:5215:
+ mark_unavailable_features(cpu, FEAT_7_0_EBX, CPUID_7_0_EBX_INTEL_PT, prefix);
total: 2 errors, 1 warnings, 147 lines checked
Patch 2/30 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/30 Checking commit 107c50351a12 (target/i386: introduce generic feature dependency mechanism)
WARNING: line over 80 characters
#126: FILE: target/i386/cpu.c:5114:
+ uint32_t unavailable_features = env->features[d->to.index] & d->to.mask;
WARNING: line over 80 characters
#133: FILE: target/i386/cpu.c:5116:
+ /* Not an error unless the dependent feature was added explicitly. */
ERROR: line over 90 characters
#135: FILE: target/i386/cpu.c:5118:
+ unavailable_features & env->user_features[d->to.index],
total: 1 errors, 2 warnings, 110 lines checked
Patch 3/30 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/30 Checking commit 31a4f805635b (target/i386: expand feature words to 64 bits)
WARNING: line over 80 characters
#153: FILE: target/i386/cpu.c:3442:
+ assert(bitnr < 32 || !(name && feature_word_info[w].type == CPUID_FEATURE_WORD));
WARNING: line over 80 characters
#209: FILE: target/i386/cpu.c:5117:
+ uint64_t unavailable_features = env->features[d->to.index] & d->to.mask;
total: 0 errors, 2 warnings, 235 lines checked
Patch 4/30 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/30 Checking commit 79691b91fef6 (target/i386: add VMX definitions)
6/30 Checking commit 0aabf142d06c (vmxcap: correct the name of the variables)
7/30 Checking commit 6dec78064317 (target/i386: add VMX features)
ERROR: line over 90 characters
#32: FILE: target/i386/cpu.c:1244:
+ "vmx-cr8-store-exit", "vmx-flexpriority", "vmx-vnmi-pending", "vmx-movdr-exit",
WARNING: line over 80 characters
#34: FILE: target/i386/cpu.c:1246:
+ "vmx-msr-bitmap", "vmx-monitor-exit", "vmx-pause-exit", "vmx-secondary-ctls",
WARNING: line over 80 characters
#45: FILE: target/i386/cpu.c:1257:
+ "vmx-apicv-x2apic", "vmx-vpid", "vmx-wbinvd-exit", "vmx-unrestricted-guest",
WARNING: line over 80 characters
#47: FILE: target/i386/cpu.c:1259:
+ "vmx-invpcid-exit", "vmx-vmfunc", "vmx-shadow-vmcs", "vmx-encls-exit",
WARNING: Block comments use a leading /* on a separate line
#84: FILE: target/i386/cpu.c:1296:
+ NULL, NULL /* vmx-exit-host-addr-space-size */, NULL, NULL,
ERROR: line over 90 characters
#103: FILE: target/i386/cpu.c:1315:
+ NULL, "vmx-entry-load-perf-global-ctrl", "vmx-entry-load-pat", "vmx-entry-load-efer",
WARNING: line over 80 characters
#145: FILE: target/i386/cpu.c:1357:
+ "vmx-invvpid-all-context", "vmx-invept-single-context-noglobals",
WARNING: line over 80 characters
#166: FILE: target/i386/cpu.c:1378:
+ /* Just to be safe - we don't support setting the MSEG version field. */
WARNING: line over 80 characters
#216: FILE: target/i386/cpu.c:1441:
+ .from = { FEAT_VMX_PROCBASED_CTLS, VMX_CPU_BASED_ACTIVATE_SECONDARY_CONTROLS },
WARNING: line over 80 characters
#245: FILE: target/i386/cpu.c:1470:
+ .to = { FEAT_VMX_SECONDARY_CTLS, VMX_SECONDARY_EXEC_UNRESTRICTED_GUEST },
WARNING: Block comments use a leading /* on a separate line
#366: FILE: target/i386/kvm.c:2464:
+ /* If a feature bit is set, the control can be either set or clear.
ERROR: code indent should never use tabs
#427: FILE: target/i386/kvm.c:2525:
+^I MSR_VMX_EPT_UC | MSR_VMX_EPT_WB : 0);$
WARNING: line over 80 characters
#438: FILE: target/i386/kvm.c:2536:
+ f[FEAT_VMX_EXIT_CTLS]) | fixed_vmx_exit);
total: 3 errors, 10 warnings, 448 lines checked
Patch 7/30 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/30 Checking commit 354aebbf3e19 (target/i386: work around KVM_GET_MSRS bug for secondary execution controls)
WARNING: line over 80 characters
#26: FILE: target/i386/kvm.c:483:
+ if (kvm_arch_get_supported_cpuid(s, 0xD, 1, R_ECX) & CPUID_XSAVE_XSAVES) {
WARNING: line over 80 characters
#32: FILE: target/i386/kvm.c:489:
+ if (kvm_arch_get_supported_cpuid(s, 7, 0, R_EBX) & CPUID_7_0_EBX_INVPCID) {
WARNING: line over 80 characters
#35: FILE: target/i386/kvm.c:492:
+ if (kvm_arch_get_supported_cpuid(s, 7, 0, R_EBX) & CPUID_7_0_EBX_RDSEED) {
WARNING: line over 80 characters
#38: FILE: target/i386/kvm.c:495:
+ if (kvm_arch_get_supported_cpuid(s, 0x80000001, 0, R_EDX) & CPUID_EXT2_RDTSCP) {
total: 0 errors, 4 warnings, 23 lines checked
Patch 8/30 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/30 Checking commit 62af60b3e536 (target/i386/kvm: Silence warning from Valgrind about uninitialized bytes)
10/30 Checking commit a8748fbecf3f (qemu-pr-helper: fix crash in mpath_reconstruct_sense)
11/30 Checking commit b2315db46b26 (replay: don't synchronize memory operations in replay mode)
12/30 Checking commit 22144ade9a59 (Makefile: Remove generated files when doing 'distclean')
13/30 Checking commit ef7140c5d5ab (hw/isa: Introduce a CONFIG_ISA_SUPERIO switch for isa-superio.c)
14/30 Checking commit 3b04059cc6e9 (ide: fix leak from qemu_allocate_irqs)
15/30 Checking commit 975e23643625 (microblaze: fix leak of fdevice tree blob)
16/30 Checking commit 1681302ceb65 (mcf5208: fix leak from qemu_allocate_irqs)
17/30 Checking commit 0a4aae1a68b7 (hppa: fix leak from g_strdup_printf)
18/30 Checking commit 71ddec44dba9 (mips: fix memory leaks in board initialization)
19/30 Checking commit 7e7f903148f1 (cris: do not leak struct cris_disasm_data)
ERROR: space prohibited between function name and open parenthesis '('
#23: FILE: disas/cris.c:1298:
+cris_parse_disassembler_options (struct cris_disasm_data *disdata,
ERROR: code indent should never use tabs
#24: FILE: disas/cris.c:1299:
+^I^I^I^I char *disassembler_options,$
ERROR: space prohibited between function name and open parenthesis '('
#39: FILE: disas/cris.c:1305:
+ || (strcmp (disassembler_options, "nocase") != 0));
ERROR: space prohibited between function name and open parenthesis '('
#55: FILE: disas/cris.c:2734:
+ cris_parse_disassembler_options (&disdata, info->disassembler_options,
ERROR: code indent should never use tabs
#56: FILE: disas/cris.c:2735:
+^I^I^I^I cris_dis_v0_v10);$
ERROR: space prohibited between function name and open parenthesis '('
#69: FILE: disas/cris.c:2746:
+ cris_parse_disassembler_options (&disdata, info->disassembler_options,
ERROR: code indent should never use tabs
#70: FILE: disas/cris.c:2747:
+^I^I^I^I cris_dis_v32);$
ERROR: space prohibited between function name and open parenthesis '('
#83: FILE: disas/cris.c:2761:
+ cris_parse_disassembler_options (&disdata, info->disassembler_options,
ERROR: code indent should never use tabs
#84: FILE: disas/cris.c:2762:
+^I^I^I^I cris_dis_common_v10_v32);$
ERROR: space prohibited between function name and open parenthesis '('
#97: FILE: disas/cris.c:2774:
+ cris_parse_disassembler_options (&disdata, info->disassembler_options,
ERROR: code indent should never use tabs
#98: FILE: disas/cris.c:2775:
+^I^I^I^I cris_dis_v0_v10);$
ERROR: space prohibited between function name and open parenthesis '('
#111: FILE: disas/cris.c:2787:
+ cris_parse_disassembler_options (&disdata, info->disassembler_options,
ERROR: code indent should never use tabs
#112: FILE: disas/cris.c:2788:
+^I^I^I^I cris_dis_v32);$
ERROR: space prohibited between function name and open parenthesis '('
#125: FILE: disas/cris.c:2801:
+ cris_parse_disassembler_options (&disdata, info->disassembler_options,
ERROR: code indent should never use tabs
#126: FILE: disas/cris.c:2802:
+^I^I^I^I cris_dis_common_v10_v32);$
total: 15 errors, 0 warnings, 107 lines checked
Patch 19/30 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/30 Checking commit ddc831e53ac1 (lm32: do not leak memory on object_new/object_unref)
21/30 Checking commit 223539fbc024 (docker: test-debug: disable LeakSanitizer)
22/30 Checking commit 9cb898e8c1c1 (i386: Add CPUID bit for CLZERO and XSAVEERPTR)
WARNING: line over 80 characters
#35: FILE: target/i386/cpu.h:726:
+#define CPUID_8000_0008_EBX_CLZERO (1U << 0) /* CLZERO instruction */
ERROR: code indent should never use tabs
#35: FILE: target/i386/cpu.h:726:
+#define CPUID_8000_0008_EBX_CLZERO^I^I(1U << 0) /* CLZERO instruction */$
ERROR: line over 90 characters
#36: FILE: target/i386/cpu.h:727:
+#define CPUID_8000_0008_EBX_XSAVEERPTR (1U << 2) /* Always save/restore FP error pointers */
ERROR: code indent should never use tabs
#36: FILE: target/i386/cpu.h:727:
+#define CPUID_8000_0008_EBX_XSAVEERPTR^I(1U << 2) /* Always save/restore FP error pointers */$
total: 3 errors, 1 warnings, 16 lines checked
Patch 22/30 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/30 Checking commit 31fb63bad4e1 (vfio: Turn the container error into an Error handle)
24/30 Checking commit ba6a8cbc61f9 (memory: allow memory_region_register_iommu_notifier() to fail)
25/30 Checking commit 68a87498010f (Fix wrong behavior of cpu_memory_rw_debug() function in SMM)
26/30 Checking commit 81d837865a80 (util: WSAEWOULDBLOCK on connect should map to EINPROGRESS)
27/30 Checking commit 6dc6f6766496 (tests: skip serial test on windows)
28/30 Checking commit 42bb4d8c516b (win32: work around main-loop busy loop on socket/fd event)
29/30 Checking commit f809af7acc61 (tests/docker: only enable ubsan for test-clang)
30/30 Checking commit ece968fbb77f (accel/kvm: ensure ret always set)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1570035113-56848-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01 13:13:38 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to 52c8850d80c5bf34afd3b203b912217f45327a9e: accel/kvm: ensure ret always set (2019-10-02 18:37:27 +0200) ---------------------------------------------------------------- * Compilation fix for KVM (Alex) * SMM fix (Dmitry) * VFIO error reporting (Eric) * win32 fixes and workarounds (Marc-André) * qemu-pr-helper crash bugfix (Maxim) * VMX feature flags (myself) * Memory leak fixes (myself) * Record-replay deadlock (Pavel) * i386 CPUID bits (Sebastian) * kconfig tweak (Thomas) * Valgrind fix (Thomas) * distclean improvement (Thomas) * Autoconverge test (Yury) ---------------------------------------------------------------- Alex Bennée (1): accel/kvm: ensure ret always set Dmitry Poletaev (1): Fix wrong behavior of cpu_memory_rw_debug() function in SMM Eric Auger (2): vfio: Turn the container error into an Error handle memory: allow memory_region_register_iommu_notifier() to fail Marc-André Lureau (3): util: WSAEWOULDBLOCK on connect should map to EINPROGRESS tests: skip serial test on windows win32: work around main-loop busy loop on socket/fd event Maxim Levitsky (1): qemu-pr-helper: fix crash in mpath_reconstruct_sense Paolo Bonzini (16): target/i386: handle filtered_features in a new function mark_unavailable_features target/i386: introduce generic feature dependency mechanism target/i386: expand feature words to 64 bits target/i386: add VMX definitions vmxcap: correct the name of the variables target/i386: add VMX features target/i386: work around KVM_GET_MSRS bug for secondary execution controls ide: fix leak from qemu_allocate_irqs microblaze: fix leak of fdevice tree blob mcf5208: fix leak from qemu_allocate_irqs hppa: fix leak from g_strdup_printf mips: fix memory leaks in board initialization cris: do not leak struct cris_disasm_data lm32: do not leak memory on object_new/object_unref docker: test-debug: disable LeakSanitizer tests/docker: only enable ubsan for test-clang Pavel Dovgaluk (1): replay: don't synchronize memory operations in replay mode Sebastian Andrzej Siewior (1): i386: Add CPUID bit for CLZERO and XSAVEERPTR Thomas Huth (3): target/i386/kvm: Silence warning from Valgrind about uninitialized bytes Makefile: Remove generated files when doing 'distclean' hw/isa: Introduce a CONFIG_ISA_SUPERIO switch for isa-superio.c Yury Kotov (1): tests/migration: Add a test for auto converge Makefile | 6 +- accel/kvm/kvm-all.c | 6 +- disas/cris.c | 59 +++--- exec.c | 23 ++- hw/arm/smmuv3.c | 18 +- hw/hppa/dino.c | 1 + hw/hppa/machine.c | 4 +- hw/i386/amd_iommu.c | 17 +- hw/i386/intel_iommu.c | 8 +- hw/ide/cmd646.c | 1 + hw/isa/Kconfig | 10 +- hw/isa/Makefile.objs | 2 +- hw/m68k/mcf5208.c | 2 + hw/microblaze/boot.c | 1 + hw/mips/Kconfig | 1 + hw/mips/mips_int.c | 1 + hw/mips/mips_jazz.c | 2 + hw/ppc/spapr_iommu.c | 8 +- hw/timer/lm32_timer.c | 6 +- hw/timer/milkymist-sysctl.c | 10 +- hw/vfio/common.c | 52 +++-- hw/vfio/spapr.c | 4 +- hw/virtio/vhost.c | 9 +- include/exec/memory.h | 21 +- include/hw/vfio/vfio-common.h | 2 +- include/sysemu/kvm.h | 2 +- memory.c | 31 +-- scripts/kvm/vmxcap | 14 +- scsi/qemu-pr-helper.c | 6 +- target/i386/cpu.c | 447 +++++++++++++++++++++++++++++++++--------- target/i386/cpu.h | 146 +++++++++++++- target/i386/helper.c | 5 +- target/i386/kvm.c | 183 ++++++++++++++++- tests/Makefile.include | 12 +- tests/docker/test-clang | 4 +- tests/docker/test-debug | 1 + tests/migration-test.c | 157 +++++++++++++-- tests/test-char.c | 4 +- util/async.c | 6 +- util/oslib-win32.c | 6 +- 40 files changed, 1050 insertions(+), 248 deletions(-)