diff mbox series

[1/4] scripts: namespace.pl: handle lib-ksyms.o as lib.a

Message ID 20191003031312.252507322@gmail.com (mailing list archive)
State New, archived
Headers show
Series scripts: update namespace.pl | expand

Commit Message

Randy Dunlap Oct. 3, 2019, 3:13 a.m. UTC
Fix these warnings:
  No source file found for drivers/firmware/efi/libstub/lib-ksyms.o
  No source file found for arch/x86/lib/lib-ksyms.o
  No source file found for lib/lib-ksyms.o

In scripts/Makefile.build, any resulting lib-ksyms.o file is renamed to
lib.a, so handle that rename here also.

Signed-off-by: Randy Dunlap <rd.dunlab@gmail.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
---
patch 1/4:
 scripts/namespace.pl |    3 +++
 1 file changed, 3 insertions(+)

Comments

Masahiro Yamada Oct. 23, 2019, 5:22 a.m. UTC | #1
Randy,

On Thu, Oct 3, 2019 at 12:18 PM <rd.dunlab@gmail.com> wrote:


> In scripts/Makefile.build, any resulting lib-ksyms.o file is renamed to
> lib.a, so handle that rename here also.

This description is incorrect.
lib-ksyms.o is included in built-in.a


The code attempts to suppress the warnings
in a strange way.


I think the following is a more straightforward way.


diff --git a/scripts/namespace.pl b/scripts/namespace.pl
index 4a545ba868f8..f0c94333a23d 100755
--- a/scripts/namespace.pl
+++ b/scripts/namespace.pl
@@ -166,6 +166,7 @@ sub linux_objects
        if (/.*\.o$/ &&
                ! (
                m:/built-in.a$:
+               || m:/lib-ksyms.o$:
                || m:arch/x86/vdso/:
                || m:arch/x86/boot/:
                || m:arch/ia64/ia32/ia32.o$:





--
Best Regards
Masahiro Yamada
diff mbox series

Patch

--- linux-next-20191002.orig/scripts/namespace.pl
+++ linux-next-20191002/scripts/namespace.pl
@@ -231,6 +231,9 @@  sub do_nm
 		return;
 	}
 	($source = $basename) =~ s/\.o$//;
+	if ($basename eq "lib-ksyms.o") { # modified in scripts/Makefile.build
+		$basename = "lib.a";	# from lib.a to lib-ksyms.o
+	}
 	if (-e "$source.c" || -e "$source.S") {
 		$source = File::Spec->catfile($objtree, $File::Find::dir, $source)
 	} else {