| Message ID | 20191003123845.2895-1-cavery@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [kvm-unit-tests] svm: Fixed error code comparison in test npt_rsvd_pfwalk | expand |
On 03/10/19 14:38, Cathy Avery wrote: > According to the AMD64 spec Bit 3 (RSV) in exitinfo1 should be set > to 1 if reserved bits were set in the corresponding nested page > table entry. Exitinfo1 should be checking against error code > 0x20000000eULL not 0x200000006ULL. > > Signed-off-by: Cathy Avery <cavery@redhat.com> > --- > x86/svm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/x86/svm.c b/x86/svm.c > index bc74e7c..bb39934 100644 > --- a/x86/svm.c > +++ b/x86/svm.c > @@ -1066,7 +1066,7 @@ static bool npt_rsvd_pfwalk_check(struct test *test) > pdpe[0] &= ~(1ULL << 8); > > return (test->vmcb->control.exit_code == SVM_EXIT_NPF) > - && (test->vmcb->control.exit_info_1 == 0x200000006ULL); > + && (test->vmcb->control.exit_info_1 == 0x20000000eULL); > } > > static void npt_l1mmio_prepare(struct test *test) > Queued, thanks. Paolo
diff --git a/x86/svm.c b/x86/svm.c index bc74e7c..bb39934 100644 --- a/x86/svm.c +++ b/x86/svm.c @@ -1066,7 +1066,7 @@ static bool npt_rsvd_pfwalk_check(struct test *test) pdpe[0] &= ~(1ULL << 8); return (test->vmcb->control.exit_code == SVM_EXIT_NPF) - && (test->vmcb->control.exit_info_1 == 0x200000006ULL); + && (test->vmcb->control.exit_info_1 == 0x20000000eULL); } static void npt_l1mmio_prepare(struct test *test)
According to the AMD64 spec Bit 3 (RSV) in exitinfo1 should be set to 1 if reserved bits were set in the corresponding nested page table entry. Exitinfo1 should be checking against error code 0x20000000eULL not 0x200000006ULL. Signed-off-by: Cathy Avery <cavery@redhat.com> --- x86/svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)